Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that all WinForms controls have unit tests coverage for public APIs #10453

Open
27 of 29 tasks
Tanya-Solyanik opened this issue Dec 8, 2023 · 2 comments · Fixed by #10476
Open
27 of 29 tasks

Ensure that all WinForms controls have unit tests coverage for public APIs #10453

Tanya-Solyanik opened this issue Dec 8, 2023 · 2 comments · Fixed by #10476
Assignees
@Olina-Zhang
Labels
🚧 work in progress Work that is current in progress test-enhancement Improvements of test source code
Milestone
.NET 10.0

Comments

@Tanya-Solyanik
Copy link
Member

Tanya-Solyanik commented Dec 8, 2023 •
edited by LeafShi1
Loading

Following controls are missing test coverage for public methods:
System.Windows.Forms
@Tanya-Solyanik Tanya-Solyanik added this to the .NET 9.0 milestone Dec 8, 2023
@LeafShi1 LeafShi1 changed the title Ensure that all WinForms controls ahve unit tests coverage Ensure that all WinForms controls have unit tests coverage Dec 11, 2023
@elachlan elachlan added the test-enhancement Improvements of test source code label Dec 11, 2023
@Epica3055 Epica3055 mentioned this issue Dec 13, 2023
Merged
@paul1956
Copy link
Contributor

paul1956 commented Dec 25, 2023 •
edited
Loading

@Olina-Zhang @Tanya-Solyanik I don't think the VB code has much test coverage. I added some in my yet to be merged PR #9867. I was not able to add anything for Network Uploads as I have no idea how to access a server to upload to.

@Tanya-Solyanik
Copy link
Member Author

@paul1956 - good point about the missing VB-specific coverage. We'll add it after the C# coverage is in done.

@SimonZhao888 SimonZhao888 mentioned this issue Dec 28, 2023
Merged
@ghost ghost added the 🚧 work in progress Work that is current in progress label Dec 28, 2023
@LeafShi1 LeafShi1 mentioned this issue Jan 8, 2024
Closed
@ghost ghost removed the 🚧 work in progress Work that is current in progress label Jan 10, 2024
@LeafShi1 LeafShi1 reopened this Jan 12, 2024
@LeafShi1 LeafShi1 removed their assignment Jan 17, 2024
@SimonZhao888 SimonZhao888 mentioned this issue Jan 29, 2024
Merged
This was referenced Jan 31, 2024
Open
Merged
@Olina-Zhang Olina-Zhang mentioned this issue Feb 1, 2024
Merged
@Tanya-Solyanik Tanya-Solyanik mentioned this issue Feb 16, 2024
Closed
@Tanya-Solyanik Tanya-Solyanik changed the title Ensure that all WinForms controls have unit tests coverage Ensure that all WinForms controls have unit tests coverage for public APIs Feb 16, 2024
@Zheng-Li01 Zheng-Li01 mentioned this issue Feb 21, 2024
Merged
@Olina-Zhang Olina-Zhang mentioned this issue Mar 1, 2024
Merged
@MelonWang1 MelonWang1 mentioned this issue Mar 1, 2024
Merged
@Zheng-Li01 Zheng-Li01 mentioned this issue Mar 5, 2024
Merged
@Eudora-Li01 Eudora-Li01 mentioned this issue Mar 11, 2024
Merged
@John-Qiao John-Qiao mentioned this issue Mar 12, 2024
Merged
@Zheng-Li01 Zheng-Li01 mentioned this issue Mar 12, 2024
Closed
@dotnet-policy-service dotnet-policy-service bot added the 🚧 work in progress Work that is current in progress label Mar 12, 2024
@Syareel-Sukeri Syareel-Sukeri mentioned this issue Jan 3, 2025
Merged
@Olina-Zhang Olina-Zhang mentioned this issue Jan 3, 2025
Merged
@Zheng-Li01 Zheng-Li01 mentioned this issue Jan 6, 2025
Merged
@Olina-Zhang Olina-Zhang mentioned this issue Jan 6, 2025
Merged
Tanya-Solyanik pushed a commit that referenced this issue Jan 7, 2025
@Olina-Zhang
Add unit tests for DataGridViewTopLeftHeaderCellAccessibleObject (#12707
cdcff18 
)

related #10453

Proposed changes
Add unit tests for DataGridViewTopLeftHeaderCellAccessibleObject to test its DefaultAction, Name properties, State and DoDefaultAction, Navigate events
Enable nullability in DataGridViewTopLeftHeaderCellAccessibleObjectTests.cs.
Update to use the TheoryData<> pattern for theory tests
Tanya-Solyanik pushed a commit that referenced this issue Jan 7, 2025
@Syareel-Sukeri
Add unit tests for NumericUpDownAcceleration (#12705)
f292cd2 
Related #10453

Proposed changes
Add unit tests for NumericUpDownAcceleration.cs to test its properties & methods
Enable nullability in NumericUpDownAccelerationTests.cs
Tanya-Solyanik pushed a commit that referenced this issue Jan 7, 2025
@Olina-Zhang
Add unit tests for LinkUtilities (#12647)
e1a1553 
related #10453

Proposed changes
Add unit tests for LinkUtilities to test its GetIELinkBehavior and EnsureLinkFonts methods.
Tanya-Solyanik pushed a commit that referenced this issue Jan 7, 2025
@Zheng-Li01
Add code coverage for ToolStripPanelControlCollection_XYComparer (#12711
a3da2c9 
)

related #10453

Proposed changes
Add unit tests for ToolStripPanelControlCollectionXYComparer.cs to test its methods
Tanya-Solyanik pushed a commit that referenced this issue Jan 8, 2025
@Olina-Zhang
Add unit tests for DataGridViewTextBoxColumn (#12713)
a54a4a9 
related #10453

Proposed changes
Add unit tests for DataGridViewTextBoxColumn to test its Constructor, CellTemplate, MaxInputLength, SortMode properties and ToString() method
Enable nullability in DataGridViewTextBoxColumnTests.cs
Tanya-Solyanik pushed a commit that referenced this issue Jan 8, 2025
@Zheng-Li01
Add code coverage for DataGridViewRowHeightInfoPushedEventArgs (#12673)
7c956a3 
related #10453

Proposed changes
Add unit tests for DataGridViewRowHeightInfoPushedEventArgs.cs to test its properties
ricardobossan pushed a commit to ricardobossan/winforms that referenced this issue Jan 9, 2025
@Olina-Zhang
Add unit tests for DataGridViewTopLeftHeaderCellAccessibleObject (dot…
1f11886 
…net#12707)

related dotnet#10453

Proposed changes
Add unit tests for DataGridViewTopLeftHeaderCellAccessibleObject to test its DefaultAction, Name properties, State and DoDefaultAction, Navigate events
Enable nullability in DataGridViewTopLeftHeaderCellAccessibleObjectTests.cs.
Update to use the TheoryData<> pattern for theory tests
ricardobossan pushed a commit to ricardobossan/winforms that referenced this issue Jan 9, 2025
@Syareel-Sukeri
Add unit tests for NumericUpDownAcceleration (dotnet#12705)
a5462cd 
Related dotnet#10453

Proposed changes
Add unit tests for NumericUpDownAcceleration.cs to test its properties & methods
Enable nullability in NumericUpDownAccelerationTests.cs
ricardobossan pushed a commit to ricardobossan/winforms that referenced this issue Jan 9, 2025
@Olina-Zhang
Add unit tests for LinkUtilities (dotnet#12647)
cecb0ef 
related dotnet#10453

Proposed changes
Add unit tests for LinkUtilities to test its GetIELinkBehavior and EnsureLinkFonts methods.
ricardobossan pushed a commit to ricardobossan/winforms that referenced this issue Jan 9, 2025
@Zheng-Li01
Add code coverage for ToolStripPanelControlCollection_XYComparer (dot…
f81c7d7 
…net#12711)

related dotnet#10453

Proposed changes
Add unit tests for ToolStripPanelControlCollectionXYComparer.cs to test its methods
ricardobossan pushed a commit to ricardobossan/winforms that referenced this issue Jan 9, 2025
@Olina-Zhang
Add unit tests for DataGridViewTextBoxColumn (dotnet#12713)
b982435 
related dotnet#10453

Proposed changes
Add unit tests for DataGridViewTextBoxColumn to test its Constructor, CellTemplate, MaxInputLength, SortMode properties and ToString() method
Enable nullability in DataGridViewTextBoxColumnTests.cs
ricardobossan pushed a commit to ricardobossan/winforms that referenced this issue Jan 9, 2025
@Zheng-Li01
Add code coverage for DataGridViewRowHeightInfoPushedEventArgs (dotne…
485232b 
…t#12673)

related dotnet#10453

Proposed changes
Add unit tests for DataGridViewRowHeightInfoPushedEventArgs.cs to test its properties
This was referenced Jan 9, 2025
Merged
Merged
@Olina-Zhang Olina-Zhang mentioned this issue Jan 13, 2025
Merged
This was referenced Jan 14, 2025
Merged
Closed
Tanya-Solyanik pushed a commit that referenced this issue Jan 16, 2025
@Zheng-Li01
Add code coverage for DataGridViewColumnConverter (#12766)
3b8e1a6 
related #10453

Proposed changes
Add unit tests for DataGridViewColumnConverter.cs to test its methods
Tanya-Solyanik pushed a commit that referenced this issue Jan 16, 2025
@Olina-Zhang
Add unit tests for DataGridViewSortCompareEventArgs (#12768)
85a762d 
related #10453

Proposed changes
Add unit tests for DataGridViewSortCompareEventArgs to test its Constructor initialization, SortResult property
Enable nullability in DataGridViewSortCompareEventArgsTests.cs
@Zheng-Li01 Zheng-Li01 mentioned this issue Jan 20, 2025
Merged
Tanya-Solyanik pushed a commit that referenced this issue Jan 22, 2025
@Zheng-Li01
Add code coverage for DataGridViewButtonColumn (#12814)
c3a752b 
related #10453

Proposed changes
Add unit tests for DataGridViewButtonColumn.cs to test its methods & properties
This was referenced Feb 5, 2025
Merged
Merged
@Olina-Zhang Olina-Zhang mentioned this issue Feb 10, 2025
Merged
@Zheng-Li01 Zheng-Li01 mentioned this issue Feb 14, 2025
Merged
@dotnet dotnet deleted a comment from SimonZhao888 Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Olina-Zhang Olina-Zhang

Labels
🚧 work in progress Work that is current in progress test-enhancement Improvements of test source code
Projects
None yet
Milestone
.NET 10.0
6 participants
@elachlan @paul1956 @Tanya-Solyanik @Olina-Zhang @LeafShi1 @SimonZhao888