Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for RichTextBox #10994

Merged
merged 7 commits into from
Mar 19, 2024
Merged

Add code coverage for RichTextBox #10994

merged 7 commits into from
Mar 19, 2024

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented Mar 5, 2024

related #10453

Proposed changes

  • Add unit tests for RichTextBox to test its DrawToBitmap()/LoadFile()/SaveFile()/Paste() methods

Customer Impact

  • None

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Unit tests
Microsoft Reviewers: Open in CodeFlow

@Zheng-Li01 Zheng-Li01 requested a review from a team as a code owner March 5, 2024 08:54
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 97.97980% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 73.23597%. Comparing base (5e635c5) to head (f82ba91).
Report is 34 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10994         +/-   ##
===================================================
+ Coverage   73.19881%   73.23597%   +0.03716%     
===================================================
  Files           3097        3096          -1     
  Lines         634289      633817        -472     
  Branches       47364       47338         -26     
===================================================
- Hits          464292      464182        -110     
+ Misses        166453      166089        -364     
- Partials        3544        3546          +2     
Flag Coverage Δ
Debug 73.23597% <97.97980%> (+0.03716%) ⬆️
integration 18.42168% <ø> (-0.02558%) ⬇️
production 46.72061% <ø> (+0.01158%) ⬆️
test 94.98148% <97.97980%> (+0.01015%) ⬆️
unit 43.60598% <ø> (-0.00078%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

2. Add unit tests for Label to test its events: DragDrop, DragEnter, DragLeave, DragOver, GiveFeedback,QueryContinueDrag
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are moving towards adopting Fluent Assertions for tests. Take inspiration from these recent commits:

For a detailed guide, refer to the Fluent Assertions documentation here.

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Mar 6, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Mar 7, 2024
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Mar 7, 2024
@ricardobossan
Copy link
Member

LGTM

@SimonZhao888 SimonZhao888 added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Mar 8, 2024
resolved the feedbacks
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Mar 12, 2024
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Mar 13, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments on param names, but otherwise LGTM!

@lonitra lonitra added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Mar 15, 2024
Handle FeedBacks
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Mar 18, 2024
@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label Mar 18, 2024
@lonitra lonitra added ready-to-merge PRs that are ready to merge but worth notifying the internal team. and removed waiting-review This item is waiting on review by one or more members of team labels Mar 18, 2024
@LeafShi1 LeafShi1 merged commit 022b1fe into dotnet:main Mar 19, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview3 milestone Mar 19, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Mar 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants