Skip to content

Add unit tests for DataGridViewSortCompareEventArgs #12768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Olina-Zhang
Copy link
Member

@Olina-Zhang Olina-Zhang commented Jan 13, 2025

related #10453

Proposed changes

  • Add unit tests for DataGridViewSortCompareEventArgs to test its Constructor initialization, SortResult property
  • Enable nullability in DataGridViewSortCompareEventArgsTests.cs
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.18836%. Comparing base (9780820) to head (8f49b9e).
Report is 15 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12768         +/-   ##
===================================================
+ Coverage   76.18717%   76.18836%   +0.00119%     
===================================================
  Files           3193        3196          +3     
  Lines         640306      640439        +133     
  Branches       47237       47239          +2     
===================================================
+ Hits          487831      487940        +109     
- Misses        148942      148963         +21     
- Partials        3533        3536          +3     
Flag Coverage Δ
Debug 76.18836% <100.00000%> (+0.00119%) ⬆️
integration 18.15337% <ø> (-0.02474%) ⬇️
production 50.12355% <ø> (-0.00476%) ⬇️
test 97.02142% <100.00000%> (-0.00171%) ⬇️
unit 47.55024% <ø> (+0.00792%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a small comment, LGTM!

@ricardobossan ricardobossan added the waiting-author-feedback The team requires more information from the author label Jan 14, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jan 15, 2025
ricardobossan
ricardobossan previously approved these changes Jan 15, 2025
Copy link
Member

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@LeafShi1 LeafShi1 added the waiting-review This item is waiting on review by one or more members of team label Jan 16, 2025
@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Jan 16, 2025
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jan 16, 2025
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit 85a762d into dotnet:main Jan 16, 2025
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Jan 16, 2025
@Olina-Zhang Olina-Zhang deleted the UnitTest_For_DataGridViewSortCompareEventArgs branch January 17, 2025 09:17
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants