Add code coverage for DataGridViewButtonColumn#12814
Merged
Tanya-Solyanik merged 2 commits intodotnet:mainfrom Jan 22, 2025
Merged
Add code coverage for DataGridViewButtonColumn#12814Tanya-Solyanik merged 2 commits intodotnet:mainfrom
Tanya-Solyanik merged 2 commits intodotnet:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12814 +/- ##
===================================================
+ Coverage 76.18925% 76.23617% +0.04692%
===================================================
Files 3195 3200 +5
Lines 640404 640608 +204
Branches 47239 47231 -8
===================================================
+ Hits 487919 488375 +456
+ Misses 148947 148708 -239
+ Partials 3538 3525 -13
Flags with carried forward coverage won't be shown. Click here to find out more. |
Zheng-Li01
added
the
waiting-review
Tanya-Solyanik
added
waiting-author-feedback
Member
ricardobossan
left a comment
ricardobossan
left a comment
There was a problem hiding this comment.
Other than small comments, LGTM
dotnet-policy-service
Bot
removed
the
waiting-author-feedback
Zheng-Li01
added
the
waiting-review
Tanya-Solyanik
approved these changes
Jan 22, 2025
Contributor
Tanya-Solyanik
left a comment
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Looks good, thank you!
dotnet-policy-service
Bot
removed
the
waiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related #10453
Proposed changes
Add unit tests for DataGridViewButtonColumn.cs to test its methods & properties
Microsoft Reviewers: Open in CodeFlow