[Kernel-Spark][DSv2] Add CCv2 routing to SparkTable and SnapshotManagerFactory #5678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: TimothyW553 <[email protected]>
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: TimothyW553 <[email protected]>
Signed-off-by: TimothyW553 <[email protected]>
This was referenced Dec 11, 2025
TimothyW553
changed the title
5 tasks
TimothyW553
force-pushed
the
stack/snapshotmanager-factory-wireup
branch
from
998c638 to
c0df33e
Compare
TimothyW553
requested review from
huan233usc and
scottsand-db
and removed request for
scottsand-db
TimothyW553
force-pushed
the
stack/snapshotmanager-factory-wireup
branch
from
c0df33e to
05f823d
Compare
TimothyW553
force-pushed
the
stack/snapshotmanager-factory-wireup
branch
from
05f823d to
52b46af
Compare
TimothyW553
force-pushed
the
stack/snapshotmanager-factory-wireup
branch
from
52b46af to
5f7b865
Compare
TimothyW553
force-pushed
the
stack/snapshotmanager-factory-wireup
branch
from
5f7b865 to
d59108e
Compare
TimothyW553
force-pushed
the
stack/snapshotmanager-factory-wireup
branch
from
d59108e to
6538c8b
Compare
huan233usc
reviewed
Dec 12, 2025
| UCTableInfo tableInfo, Configuration hadoopConf) { | ||
| UCClient ucClient = new UCTokenBasedRestClient(tableInfo.getUcUri(), tableInfo.getUcToken()); | ||
| UCCatalogManagedClient ucCatalogClient = new UCCatalogManagedClient(ucClient); | ||
| Engine engine = DefaultEngine.create(hadoopConf); |
Collaborator
There was a problem hiding this comment.
Let's create DefaultEngine in SparkTable and pass it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Which Delta project/connector is this regarding?
Description
This PR introduces a factory that returns the appropriate snapshot manager for a
SparkTable. This factory checks theCatalogTableto determine if the snapshot manager should be a PathBasedSnapshotManager, UCManagedTableSnapshotManager, or another CatalogedManagedSnapshotManager in the future.How was this patch tested?
Locally and CI.
Does this PR introduce any user-facing changes?
No.