-
Notifications
You must be signed in to change notification settings - Fork 2k
[Kernel-Spark][DSv2] Wireframe for UCManagedSnapshotManager #5655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TimothyW553
wants to merge
58
commits into
delta-io:master
Choose a base branch
from
TimothyW553:stack/snapshotmanager-wireframe
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Kernel-Spark][DSv2] Wireframe for UCManagedSnapshotManager #5655
TimothyW553
wants to merge
58
commits into
delta-io:master
from
TimothyW553:stack/snapshotmanager-wireframe
+93
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 9, 2025
This was referenced Dec 9, 2025
huan233usc
reviewed
Dec 9, 2025
kernel-spark/src/main/java/io/delta/kernel/spark/snapshot/unitycatalog/UCUtils.java
Outdated
Show resolved
Hide resolved
Collaborator
|
Plz update the description |
c3f5582 to
904366f
Compare
huan233usc
approved these changes
Dec 9, 2025
Collaborator
huan233usc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
raveeram-db
reviewed
Dec 9, 2025
Collaborator
raveeram-db
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit, looks great overall!
...park/src/main/java/io/delta/kernel/spark/snapshot/unitycatalog/UCManagedSnapshotManager.java
Outdated
Show resolved
Hide resolved
e8ed10e to
27edff4
Compare
tdas
reviewed
Dec 10, 2025
...src/main/java/io/delta/kernel/spark/snapshot/unitycatalog/UCManagedTableSnapshotManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: TimothyW553 <[email protected]>
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: TimothyW553 <[email protected]>
f0a3671 to
f7ac077
Compare
…ing UCCatalogManagedClient
f7ac077 to
7a36ab2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Which Delta project/connector is this regarding?
Description
This PR:
kernelUnityCatalogas a dependency forsparkV2to wire in UC-managed functionality.UCManagedSnapshotManagerskeleton for UC-managed tables that will delegate snapshot/commit operations to UCCatalogManagedClient (methods currently TODO).
(Orange is the previous PR, green is what we've introduced in this PR. Routing is deferred)
flowchart TB A["Spark table CatalogTable"] -- decide snapshot manager --> B{"Select snapshot manager"} B -- path based --> P["PathBasedSnapshotManager loadLatestSnapshot loadSnapshotAt"] C["UCCatalogManagedClient"] -- build UC REST client --> D["UC REST client"] D -- GET ratified commits and table metadata --> U["Unity Catalog server"] X["UCUtils extractTableInfo<br>(tableId, path, uri, token)"] -- needs UC table details --> M["UCManagedSnapshotManager<br>(UCCatalogManagedClient(UCClient))"] B -- UC managed --> X M --> C C:::added X:::extraction M:::added classDef extraction fill:#ffb347,stroke:#d97706,color:#000 classDef added fill:#b7e1a1,stroke:#2d6a4f,color:#000How was this patch tested?
Locally and CI.
Does this PR introduce any user-facing changes?
No.