Skip to content

Conversation

@TimothyW553
Copy link
Collaborator

@TimothyW553 TimothyW553 commented Dec 9, 2025

🥞 Stacked PR

Use this link to review incremental changes.


Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

This PR:

  • Adds kernelUnityCatalog as a dependency for sparkV2 to wire in UC-managed functionality.
  • Introduces UCManagedSnapshotManager skeleton for UC-managed tables that will delegate snapshot/
    commit operations to UCCatalogManagedClient (methods currently TODO).

(Orange is the previous PR, green is what we've introduced in this PR. Routing is deferred)

flowchart TB
    A["Spark table CatalogTable"] -- decide snapshot manager --> B{"Select snapshot manager"}
    B -- path based --> P["PathBasedSnapshotManager loadLatestSnapshot loadSnapshotAt"]
    C["UCCatalogManagedClient"] -- build UC REST client --> D["UC REST client"]
    D -- GET ratified commits and table metadata --> U["Unity Catalog server"]
    X["UCUtils extractTableInfo<br>(tableId, path, uri, token)"] -- needs UC table details --> M["UCManagedSnapshotManager<br>(UCCatalogManagedClient(UCClient))"]
    B -- UC managed --> X
    M --> C

     C:::added
     X:::extraction
     M:::added
    classDef extraction fill:#ffb347,stroke:#d97706,color:#000
    classDef added fill:#b7e1a1,stroke:#2d6a4f,color:#000
Loading

How was this patch tested?

Locally and CI.

Does this PR introduce any user-facing changes?

No.

@huan233usc
Copy link
Collaborator

Plz update the description

Copy link
Collaborator

@huan233usc huan233usc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimothyW553 TimothyW553 marked this pull request as ready for review December 9, 2025 21:19
Copy link
Collaborator

@raveeram-db raveeram-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, looks great overall!

@TimothyW553 TimothyW553 force-pushed the stack/snapshotmanager-wireframe branch 3 times, most recently from e8ed10e to 27edff4 Compare December 10, 2025 19:42
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: TimothyW553 <[email protected]>
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: TimothyW553 <[email protected]>
@TimothyW553 TimothyW553 force-pushed the stack/snapshotmanager-wireframe branch 5 times, most recently from f0a3671 to f7ac077 Compare December 11, 2025 00:21
@TimothyW553 TimothyW553 force-pushed the stack/snapshotmanager-wireframe branch from f7ac077 to 7a36ab2 Compare December 11, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants