[Kernel-Spark][DSv2] Implement UCManagedSnapshotManager operations using UCCatalogManagedClient #5677
+642
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: TimothyW553 <[email protected]>
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: Timothy Wang <[email protected]>
Signed-off-by: TimothyW553 <[email protected]>
Signed-off-by: TimothyW553 <[email protected]>
This was referenced Dec 11, 2025
TimothyW553
changed the title
5 tasks
huan233usc
reviewed
Dec 11, 2025
...src/main/java/io/delta/kernel/spark/snapshot/unitycatalog/UCManagedTableSnapshotManager.java
Outdated
Show resolved
Hide resolved
huan233usc
reviewed
Dec 11, 2025
Collaborator
Author
There was a problem hiding this comment.
The Java one is for constructor validation. The other uses Scala because there are a number of scala utils that help with testing such as UCCatalogManagedTestUtils and InMemoryUCClient (written in Scala) so it is easier to write the bulk of the tests in Scala.
This is the reason, but we could
- Get rid of the Java tests (as they are just simple constructor tests)
- Test the Java code and consolidate them in the Scala test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Which Delta project/connector is this regarding?
Description
This PR implements the wireframe introduced in the previous PR of the stack. For this specific
UCManagedTableSnapshotManager, it delegates snapshot loading operations to theUCCatalogCommitClient.getActiveCommitAtTime(t)loads the latest snapshot, gets its commits, and uses those along withDeltaHistoryManager.getActiveCommitAtTimestamp(t, catalogCommits, ...)to get the appropriate commit at timet.How was this patch tested?
Locally and CI.
Does this PR introduce any user-facing changes?
No.