Repository navigation
fix(workbook): preserve numeric condition precision - #65
Open
rudycelekli wants to merge 2 commits into
Open
rudycelekli wants to merge 2 commits into
rudycelekli wants to merge 2 commits into
Conversation
Freeze exact public condition evaluation using original positive and negative integer and fractional operands. Preserve ordinary numeric equivalence, exponent notation, leading zeros and string comparison controls. Production and CI are unchanged; no provider requests or credentials are required. Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
Compare finite numeric condition operands as exact decimals while preserving existing nonfinite numeric and lexical fallback behavior. Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Compare finite workbook condition operands as exact decimals so adjacent large integers and fractional values remain distinct. Preserve existing text comparison and NaN/infinity behavior.
Verification
evaluate_conditionfixture: 26 cases cover positive/negative adjacent integers, fractions, numeric cell values, and ordinary numeric/text controls.f1759a2: 14 expected precision assertion failures; 2104 passed, 134 skipped, 3 deselected. Accepted-main baseline: 2092 passed with the same skips/deselection; the 12 control passes are established by that count difference.cebd09e: all four jobs passed (SQLite, PostgreSQL integrity, frontend lint/tests/build, real browser regressions). SQLite: 2118 passed, 134 skipped, 3 deselected; no failures.AI-assisted implementation and review. Signed commits carry DCO sign-off. No provider or live enrichment calls were added to the tests.
Upstream CI passed all four required jobs at this exact source head: SQLite, PostgreSQL integrity, frontend lint/tests/build, and real browser regressions. The BEFORE/AFTER qualification results above belong to the unchanged ownfork workflows.