Repository navigation
fix(workbook): preserve stable column IDs across display aliases - #66
Open
rudycelekli wants to merge 3 commits into
Open
rudycelekli wants to merge 3 commits into
rudycelekli wants to merge 3 commits into
Conversation
Add eight public HTTP and SQLite fixture cases without production changes. Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
Hydrate stored inputs before failed computed snapshots invalidate materialized values. Keep condition IDs authoritative over display aliases. Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
Read input values from an immutable raw-data snapshot while preserving the original single-loop alias assignment order. Retain separate condition aliases so stable IDs take precedence. Freeze two intentional public ambiguous-name rejection controls after their native baseline pass; original eight stable-ID assertions remain unchanged. Supersedes the held two-pass hydration change without rewriting its evidence. Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve workbook stable column IDs when another column's display name collides with them.
Native verification
The existing four CI jobs are unchanged.
The original eight assertions were preserved throughout. An earlier supplemental fixture incorrectly expected successful ambiguous-name resolution; its two failures were rejected as fixture errors and add no defect evidence. The final two controls freeze the actual typed rejection contract. The earlier two-pass source was superseded by the immutable input snapshot; its passing run is not used as current-head qualification.
Scope and review
This changes only two workbook source files and their existing HTTP test owner. PR #65 changes the numeric comparator in a separate hunk; that comparator is byte-identical here, and no unmerged source from #65 is included. No workflow, provider call, tenancy or application execution behavior is added.
Prepared with AI assistance; source and native evidence were independently reviewed. All three candidate commits have verified signatures and DCO signoffs.
Upstream CI is pending for this newly submitted pull request; the results above are from the exact current head in the author fork.