Skip to content

fix(workbook): preserve numeric condition precision #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rudycelekli wants to merge 2 commits into
base: main
Choose a base branch
from
+50 −3
Open

fix(workbook): preserve numeric condition precision #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1759a2
test(workbook): qualify numeric condition precision
rudycelekli Oct 8, 2026
cebd09e
fix(workbook): preserve numeric condition precision
rudycelekli Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions apps/api/services/workbook/conditions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

import logging
import re
from decimal import Decimal, InvalidOperation
from typing import Dict

logger = logging.getLogger("workbook.conditions")
Expand Down Expand Up @@ -192,15 +193,20 @@ def _compare(left: str, right: str, op: str) -> bool:
"""Compare two values with the given operator."""
# Try numeric comparison
try:
left_num = float(left)
right_num = float(right)
left_num = Decimal(left)
right_num = Decimal(right)
# Finite decimal operands retain the digits supplied by the caller.
# Preserve the existing float semantics for NaN and infinities.
if not left_num.is_finite() or not right_num.is_finite():
left_num = float(left)
right_num = float(right)
if op == "==": return left_num == right_num
if op == "!=": return left_num != right_num
if op == ">": return left_num > right_num
if op == "<": return left_num < right_num
if op == ">=": return left_num >= right_num
if op == "<=": return left_num <= right_num
except (ValueError, TypeError):
except (InvalidOperation, ValueError, TypeError):
pass

# String comparison
Expand Down
41 changes: 41 additions & 0 deletions tests/test_workbook_condition_precision.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
"""Public workbook conditions preserve numeric distinctions in actual row values."""

import pytest

from apps.api.services.workbook.conditions import evaluate_condition


@pytest.mark.parametrize("value, threshold, operator, expected", [
("9007199254740993", "9007199254740992", "==", False),
("9007199254740993", "9007199254740992", "!=", True),
("9007199254740993", "9007199254740992", ">", True),
("9007199254740993", "9007199254740992", "<", False),
("9007199254740993", "9007199254740992", ">=", True),
("9007199254740993", "9007199254740992", "<=", False),
("-9007199254740993", "-9007199254740992", "==", False),
("-9007199254740993", "-9007199254740992", "!=", True),
("-9007199254740993", "-9007199254740992", ">", False),
("-9007199254740993", "-9007199254740992", "<", True),
("-9007199254740993", "-9007199254740992", ">=", False),
("-9007199254740993", "-9007199254740992", "<=", True),
("9007199254740992.5", "9007199254740992.25", "==", False),
("9007199254740992.5", "9007199254740992.25", "!=", True),
("9007199254740992.5", "9007199254740992.25", ">", True),
("9007199254740992.5", "9007199254740992.25", "<", False),
("9007199254740992.5", "9007199254740992.25", ">=", True),
("9007199254740992.5", "9007199254740992.25", "<=", False),
(9007199254740993, "9007199254740992", "==", False),
(-9007199254740993, "-9007199254740992", "<", True),
("3.50", "3.5", "==", True),
("1e3", "1000", "==", True),
("009", "9", "==", True),
("-4.25", "-4", "<", True),
("Acme", '"Acme"', "==", True),
("Other", '"Acme"', "!=", True),
])
def test_numeric_conditions_keep_original_operand_distinctions(
value, threshold, operator, expected,
):
cells = {"score": {"value": value, "status": "complete"}}
expression = f"{{score}} {operator} {threshold}"
assert evaluate_condition(expression, cells, []) is expected
Loading