Gst rtsp server

[FlyingSamson]

Checklist

• Used a personal fork of the feedstock to propose changes
• Bumped the build number (if the version is unchanged)
• Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
• Ensured the license file is being packaged.

This builds up on the work by @solonovamax in PR #159 and resolves #149.

In addition to his prior work, I only removed some remnant code that caused the build on macOS to fail.

I'm unsure if I need to bump the build number in this case of adding a sub-package to the main package.

[conda-forge-admin]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

• ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
• ℹ️ The feedstock is lowering the image versions for one or more platforms: {'linux_64': 'cos7'} (the default is alma9). Unless you are in the very rare case of repackaging binary artifacts, consider removing these overrides from conda-forge.yml in the top feedstock directory.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18994227013. Examine the logs at this URL for more detail.}

[FlyingSamson]

This is the PR in the admin-requests repo for adding the gst-rtsp-server plugin as output to this feedstock:
conda-forge/admin-requests#1737

[tjwilli58]

I don't see any problems with these changes.

[tjwilli58]

@conda-forge-admin, please rerender

[conda-forge-admin]

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

[conda-forge-admin]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

• ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
• ℹ️ The feedstock is lowering the image versions for one or more platforms: {'linux_64': 'cos7'} (the default is alma9). Unless you are in the very rare case of repackaging binary artifacts, consider removing these overrides from conda-forge.yml in the top feedstock directory.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19113773640. Examine the logs at this URL for more detail.}

[tjwilli58]

@FlyingSamson , I resolved to merge conflicts but you may want to check your meta.yaml. The one where I was added as maintainer was easy. The other one I guessed "keep both changes:.

[tjwilli58]

Updated hashes

[yishai1999]

General question that this PR made me think about, maybe @hmaarrfk will know the answer. Why aren't all the gatreamer subprojects included in this feedstock?

[hmaarrfk]

Keeping licenses separated (some are GPL) and keeping the recipe complexity down has been a historical desire.

If the contributor of rstp (for example) is no longer active, are we allow to merge the broken recipe?

it does make the gstreamer ecosystem spread out but it really helps delegate.

finally, on qt we started to hit the time limit. So splitting it across projects really helped keep the compilation time under control.

You can look for the qt6- packages

[tjwilli58]

Also, not everyone needs gst-plugins-bad, gst-plugins-ugly. It makes sense to have gst-plugins-base, gst-plugins-good along with gstreamer, especially -base. I'm on the fence about having gst-plugins-good having its own feedstock.

[hmaarrfk]

To be clear. I removed myself from a maintainer to allow you all to make the best decisions that work for you.

Happy to share my historical knowledge and let you maneuver as you see fit.

Ps. These kinds of package renames are very natural to do at version changes. So minor version changes are quite natural. But maybe patch version also work. I haven’t thought it through.

[yishai1999]

So wouldn't that mean tsp should be a separate feedstock too?

[tjwilli58]

@hmaarrfk ,
Is this still needed in meta.yaml?

        # 20221027 - hmaarrfk
        # 3.11 doesn't have distutils which mesons needs???
        - cross-python_{{ target_platform }} 3.10  # [build_platform != target_platform]

[tjwilli58]

So wouldn't that mean tsp should be a separate feedstock too?

Maybe? I'm looking at the list of subprojects, and I'm thinking that this is on the same level as gst-libav. I'm not really familiar with either of those packages, so may as well leave them where they are. It makes sense to me to have gst-plugins-bad, gst-plugins-ugly, gst-python in their own feedstocks.

After looking at issue #146 again, maybe this is an argument for putting that in a separate feedstock.

[hmaarrfk]

@hmaarrfk , Is this still needed in meta.yaml?

        # 20221027 - hmaarrfk
        # 3.11 doesn't have distutils which mesons needs???
        - cross-python_{{ target_platform }} 3.10  # [build_platform != target_platform]

You can try removing it

[yishai1999]

Closing now that conda-forge/staged-recipes#31457 is merged.

[tjwilli58]

Thanks. I was planning to close it after I did a conda search on it.

[tjwilli58]

@FlyingSamson , @solonovamax ,
Please check out and test gst-rtsp-server on conda-forge. I don't have any experience with that part of gstreamer.

[FlyingSamson]

Thank you @tjwilli58 for moving this into its own feedstock.

Unfortunately, there is currently no macOS ARM-64 build provided through conda-forge. Is this intentional, or does it only take some time until everything is build and uploaded?

[tjwilli58]

@FlyingSamson , I had a lot of help from @hmaarrfk and @yishai1999 on that. As to the macOS build, I basically started from what was in this PR. I'll look at the other gstreamer feedstocks to see what's different about that. Maybe it does take a few more days. I don't know about that.

[tjwilli58]

@hmaarrfk , @yishai1999,

Do I need to add this to my conda-forge.yaml file?

build_platform:
  linux_aarch64: linux_64
  linux_ppc64le: linux_64
  osx_arm64: osx_64

[tjwilli58]

Added PR#3. Waiting for review.

[tjwilli58]

Hi @FlyingSamson ,
conda-forge/gst-rtsp-server-feedstock#3
has been merged. Let me know if this works for you.

[hmaarrfk]

@hmaarrfk , @yishai1999,

Do I need to add this to my conda-forge.yaml file?

build_platform:
  linux_aarch64: linux_64
  linux_ppc64le: linux_64
  osx_arm64: osx_64

Probably best to follow https://conda-forge.org/docs/maintainer/knowledge_base/#apple-silicon-builds

[tjwilli58]

I just did a quick read of this. Once I'm sure I understand it all, I'll open a new PR with that. In the meantime, I'd like to see if @FlyingSamson has issues with the current build.

[tjwilli58]

Created issue so I don't forget about it
conda-forge/gst-rtsp-server-feedstock#4

[FlyingSamson]

Sorry for the delay. Installing from conda-forge now succeeded without any issues.

However, I just ran into the issue with the cross-compiled prebuilt packages not having introspection support enabled. In order to test the new feedstock I hence built the main branch of the gstreamer feedstock locally using the build_locally.py script and then, setting EXTRA_CB_OPTIONS to include that build as additional channel to conda-forge, built the main branch of the new gst-rtsp-server feedstock using its build_locally.py script.

I'm a complete novice with regard to the gst-rtsp-server (and gstreamer as a whole really) but the small example script that I had previously up and running with the branch behind this MR still runs perfectly with the rtsp-server from the new feedstock.

Thanks again for the work put in by all of you!

[tjwilli58]

@FlyingSamson , I'm back at work now since the US gov't shutdown is over, so I don't have as much time as before. I'll look into it though.

[tjwilli58]

@FlyingSamson ,
Can you create an issue on https://github.com/conda-forge/gst-rtsp-server-feedstock and also drop your sample script so I can have something to start from?

Thanks

[tjwilli58]

@FlyingSamson ,
I tried to enable introspection in this PR, but the ones that failed were the cross compile ones.
I'll look into it further.

[hmaarrfk]

if it is linux based platforms you care about, you can try to build them with "emulation", its much slower, but it helps with these introspection issues.

[tjwilli58]

I believe @FlyingSamson is on a Mac, but if I can build the other linux platforms that way, then that'll support people on those platforms. How do I do that?

BTW, I looked into https://conda-forge.org/docs/maintainer/knowledge_base/#apple-silicon-builds, and I'll probably submit a PR on that soon.

[tjwilli58]

Looking at https://conda-forge.org/docs/maintainer/knowledge_base/#emulated-builds now.

[hmaarrfk]

all that bot will do is submit the osx arm PR you've already enabled.

[tjwilli58]

So don't bother with a PR to add gst-rtsp-server to https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/main/recipe/migration_support/osx_arm64.txt ?

[FlyingSamson]

Yes I'm on a ARM64 machine running macOS. From what I understand from sifting through related issues it seems that it is still not possible to use g-ir-scanner in a cross compilation environment, so I guess I'll have to continue building these feedstocks locally for now.

[hmaarrfk]

conda-forge/gst-rtsp-server-feedstock#6 (comment)

maybe open an issue on gst-rtsp-server's feedstock so we can monitor progress there.