Skip to content

Conversation

@tjwilli58
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/gst-rtsp-server/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: hmaarrfk. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 12, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gst-rtsp-server/meta.yaml) and found some lint.

Here's what I've got...

For recipes/gst-rtsp-server/meta.yaml:

  • ❌ There are too few lines. There should be one empty line at the end of the file.
  • ❌ If python is a host requirement, it should be a run requirement.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19304116738. Examine the logs at this URL for more detail.

@tjwilli58 tjwilli58 marked this pull request as draft November 12, 2025 15:46
@tjwilli58
Copy link
Contributor Author

@hmaarrfk,
Can you tell me what I'm doing wrong with this meta.yaml file? Thanks..

I also can't seem to figure out how to build locally:

PS D:\GitClones\staged-recipes> mamba activate conda-forge-test
(conda-forge-test) (conda-forge-test) PS D:\GitClones\staged-recipes> python .\build-locally.py
valid configs are {'linux64', 'win64', 'linux_aarch64', 'linux64_cuda126', 'osx_arm64', 'osx64'}
config not selected, please choose from the following:

1. linux64
2. linux64_cuda126
3. linux_aarch64
4. osx64
5. osx_arm64
6. win64

> 6
selected win64
Provisioning build tools
Build tools already installed at D:\GitClones\staged-recipes\miniforge3.
Configuring conda
Activating "D:\GitClones\staged-recipes\miniforge3"
'mamba' is not recognized as an internal or external command,
operable program or batch file.
Setting up configuration
'setup_conda_rc' is not recognized as an internal or external command,
operable program or batch file.
Traceback (most recent call last):
  File "D:\GitClones\staged-recipes\build-locally.py", line 133, in <module>
    main()
  File "D:\GitClones\staged-recipes\build-locally.py", line 129, in main
    run_win_build(ns)
  File "D:\GitClones\staged-recipes\build-locally.py", line 61, in run_win_build
    subprocess.check_call(["cmd", "/D", "/Q", "/C", f"CALL {script}"])
  File "D:\envs\conda-forge-test\Lib\subprocess.py", line 413, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['cmd', '/D', '/Q', '/C', 'CALL .scripts/run_win_build.bat']' returned non-zero exit status 9009.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gst-rtsp-server/meta.yaml) and found it was in an excellent condition.

@tjwilli58
Copy link
Contributor Author

@hmaarrfk, @yishai1999,
Can I get you to review this PR?
Thanks.

@tjwilli58 tjwilli58 marked this pull request as ready for review November 12, 2025 16:46
@tjwilli58 tjwilli58 marked this pull request as draft November 12, 2025 16:48
@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@tjwilli58
Copy link
Contributor Author

Credit where it's due:
Based on PR conda-forge/gstreamer-feedstock#170

This builds up on the work by @solonovamax in PR conda-forge/gstreamer-feedstock#159 and resolves conda-forge/gstreamer-feedstock#149.

In addition to his prior work, I only removed some remnant code that caused the build on macOS to fail.

@tjwilli58
Copy link
Contributor Author

Where do I put
install_rtsp_server.bat, install_rtsp_server.sh?
I didn't copy them anywhere from @FlyingSamson's PR.
The same folder as the meta.yaml file, or do I create a .scripts/ folder in recipes/gst-rtsp-server/?

@yishai1999
Copy link

Where do I put install_rtsp_server.bat, install_rtsp_server.sh? I didn't copy them anywhere from @FlyingSamson's PR. The same folder as the meta.yaml file, or do I create a .scripts/ folder in recipes/gst-rtsp-server/?

Same folder but change the names to build.sh and bld.bat. These are the default names for the build script.

@tjwilli58 tjwilli58 marked this pull request as ready for review November 12, 2025 18:55
@tjwilli58
Copy link
Contributor Author

Tests failed for Windows. Not sure why.

@hmaarrfk
Copy link
Contributor

Honestly. Not many of us daily drive windows.

I suggest you install Ubuntu and never look back.

but I often use

conda build …

directly.

@tjwilli58
Copy link
Contributor Author

We use windows at work, so ....
I do have a VM with ubuntu on my home laptop.
I could just not support windows for this feedstock, but there may be others that would use it. I don't use gst-rtsp-server myself.

@tjwilli58 tjwilli58 marked this pull request as draft November 12, 2025 23:09
@hmaarrfk
Copy link
Contributor

The conda build

command I gave should work.

I don’t use build locally on windows.

@hmaarrfk
Copy link
Contributor

I don’t use build-locally.py on windows

tjwilli58 and others added 5 commits November 12, 2025 19:27
Co-authored-by: Mark Harfouche <[email protected]>
Co-authored-by: Mark Harfouche <[email protected]>
add bld.bat, build.sh
add COPYING license file
 pin   - setuptools <81 in build

Update meta.yaml
tjwilli58 and others added 5 commits November 13, 2025 17:33
Co-authored-by: Mark Harfouche <[email protected]>
Co-authored-by: Mark Harfouche <[email protected]>
Co-authored-by: Mark Harfouche <[email protected]>
Co-authored-by: Mark Harfouche <[email protected]>
Co-authored-by: Mark Harfouche <[email protected]>
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gst-rtsp-server/meta.yaml) and found some lint.

Here's what I've got...

For recipes/gst-rtsp-server/meta.yaml:

  • ❌ If python is a host requirement, it should be a run requirement.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19347973871. Examine the logs at this URL for more detail.

@hmaarrfk
Copy link
Contributor

❌ If python is a host requirement, it should be a run requirement.

we can likely ignore this. lets see if this builds.

@tjwilli58
Copy link
Contributor Author

  • ❌ If python is a host requirement, it should be a run requirement.

I may have added that earlier because of this.
Do we even need

   - python 3.10  # [build_platform != target_platform]

in host: then?

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gst-rtsp-server/meta.yaml) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor

ok i mostly copied over yoru strategy from gstreamer repo this looks good now.

@hmaarrfk hmaarrfk enabled auto-merge (rebase) November 13, 2025 23:11
@hmaarrfk hmaarrfk disabled auto-merge November 13, 2025 23:11
@hmaarrfk hmaarrfk enabled auto-merge (squash) November 13, 2025 23:11
@hmaarrfk hmaarrfk merged commit 87a3407 into conda-forge:main Nov 13, 2025
9 checks passed
@tjwilli58
Copy link
Contributor Author

So I delete my branch and wait for it to become a feedstock?

@tjwilli58 tjwilli58 deleted the gst-rtsp-server branch November 13, 2025 23:35
@hmaarrfk
Copy link
Contributor

Yes

@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/gst-rtsp-server/meta.yaml:
    • lints:
      • Feedstock with the same name exists in conda-forge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants