-
-
Notifications
You must be signed in to change notification settings - Fork 36
Add rtsp server package #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/17389998299. Examine the logs at this URL for more detail. |
|
It currently fails with this: I've got absolutely no clue why |
Signed-off-by: solonovamax <[email protected]>
Signed-off-by: solonovamax <[email protected]>
See the output:
You need to add the new packages as allowed output for the feedstock. |
I'm not sure what exactly I need to do to "add the new package as allowed output for the feedstock", other than sending a request to the admin-requests repo, however I assume this should be done by the current package maintainers rather than me, no? |
|
No, anyone can do that, then you can mention the mantainers in the admin-requrests PR to get an approval. |
|
Thank you @solonovamax, for extending the recipe for the rtsp server. I'd like to use that one, too. I'm working on OSX and it's failing because this code in install_rtsp_server.sh to deactivate the X11 plugins on OSX seems to try to disable meson options that don't exist. Can it be that this is some artefact left from copying the recipe from the base-plugins install script? When I comment out these five lines everything works on my end. |
yeah, this is from when I copied it from another script so it can be removed. however, I no longer use pixi/conda due to other issues with it & instead now use nix-ros-overlay, so if you'd like to adopt this PR then feel free to do that |
|
Closing in favour of #170 |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)resolves #149
Currently, the build for this fails. I'm not sure why, so I'm submitting this PR to hopefully get some feedback on what can be done to fix this.
I've also updated the doc source urls because the repo they're pointing to was last updated 4 years ago