Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typography + Job Posting page margins #94

Closed
wants to merge 6 commits into from
Closed

Typography + Job Posting page margins #94

wants to merge 6 commits into from

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Jul 27, 2023 •
edited
Loading

Closes #37
Closes #24

What this PR does

CSS

Headlines

  • Create classes for .h1-.h5, along with regular style declarations for h1-h5 elements.
  • Use calc(##rem / 16) style for font sizes

Font families

  • Declare overrides for certain Bootstrap CSS Variables: bs-font-sans-serif, bs-font-monospace
  • Correct spelling of a class - It's sans-serif not san-serif. Sans means "without" in French. So it's "without serifs".

Links/Buttons

Layouts

  • Adds the ability to declare classes on the <body> element from a layout
  • Adds the posting class to the <body> element on job post pages

Posting page

  • Correct the margin-top and margin-bottom of the main element on the page, for both Desktop and Mobile.
  • Add the correct margin/padding bottom to the <h1> on the page.
  • Declare the <h2>s on the page to actually use styles from .h3, so it matches the designs.
image image image

@netlify
Copy link

netlify bot commented Jul 27, 2023 •
edited
Loading

✅ Deploy Preview for compilerla ready!

Name Link
🔨 Latest commit 1dc29d3
🔍 Latest deploy log https://app.netlify.com/sites/compilerla/deploys/64c2d1f3fdee7a00083715ee
😎 Deploy Preview https://deploy-preview-94--compilerla.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@machikoyasuda machikoyasuda force-pushed the feat/styles-type-vars branch from 794b98f to ac1ad92 Compare July 27, 2023 20:01
@machikoyasuda machikoyasuda changed the title WIP - Typography Typography + Job Posting page margins Jul 27, 2023
@machikoyasuda machikoyasuda self-assigned this Jul 27, 2023
@machikoyasuda machikoyasuda marked this pull request as ready for review July 27, 2023 20:38
@machikoyasuda machikoyasuda added the dev A task for a dev to work on label Jul 27, 2023
This was referenced Jul 27, 2023
Closed
Merged
@machikoyasuda machikoyasuda deleted the feat/styles-type-vars branch September 26, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela-tran angela-tran Awaiting requested review from angela-tran

Assignees

@machikoyasuda machikoyasuda

Labels
dev A task for a dev to work on
Projects
Compiler Internal
Status: Done
Milestone
Careers & Job Page (phase 1)
Development

Successfully merging this pull request may close these issues.

Update fonts and colors Update styling on Job postings
1 participant
@machikoyasuda