Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Typography, Home and Footer #99

Merged
merged 10 commits into from
Jul 28, 2023
Merged

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Jul 27, 2023

Closes #65
Closes #96
Closes #37
Closes #24

What this PR does

  • Homepage
  • Footer
  • Typography

CSS

Headlines

  • Create classes for .h1-.h5, along with regular style declarations for h1-h5 elements.
  • Use calc(##rem / 16) style for font sizes

Font families

  • Declare overrides for certain Bootstrap CSS Variables: bs-font-sans-serif, bs-font-monospace
  • Correct spelling of a class - It's sans-serif not san-serif. Sans means "without" in French. So it's "without serifs".

Links/Buttons

Layouts

  • Adds the ability to declare classes on the <body> element from a layout
  • Adds the posting class to the <body> element on job post pages

Posting page

  • Correct the margin-top and margin-bottom of the main element on the page, for both Desktop and Mobile.
  • Add the correct margin/padding bottom to the <h1> on the page.
  • Declare the <h2>s on the page to actually use styles from .h3, so it matches the designs.
image image image

@machikoyasuda machikoyasuda changed the base branch from feat/styles-type-vars to main July 28, 2023 00:06
@machikoyasuda machikoyasuda changed the title WIP - Home and Footer WIP - Typography, Home and Footer Jul 28, 2023
@machikoyasuda
Copy link
Member Author

So far
image

@machikoyasuda machikoyasuda changed the base branch from main to feat/37-colors-only July 28, 2023 04:48
@machikoyasuda machikoyasuda marked this pull request as ready for review July 28, 2023 04:49
@machikoyasuda machikoyasuda merged commit a675bd4 into feat/37-colors-only Jul 28, 2023
@machikoyasuda machikoyasuda deleted the feat/footer branch July 28, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant