Home Page redesign #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compilerla ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
machikoyasuda
commented
Jul 27, 2023
Comment on lines
+4
to
+10
| --brand-primary-green: #88B440; | ||
| --brand-primary-cyan: #51B1C7; | ||
| --brand-primary-black: #1C1C1C; | ||
| --brand-primary-gray: #ECEDED; | ||
| --brand-primary-white: #FFFFFF; | ||
| --brand-scales-gray-4: #545454; | ||
| --text-black: #1C1C1C; |
There was a problem hiding this comment.
machikoyasuda
commented
Jul 27, 2023
machikoyasuda
changed the title
machikoyasuda
changed the title
|
I decided it was easier to review this all in 1 PR, rather than scattered across 4-5 PRs :) |
thekaveman
requested changes
Jul 28, 2023
There was a problem hiding this comment.
I decided it was easier to review this all in 1 PR, rather than scattered across 4-5 PRs :)
I disagree. This PR is massive and focuses on way more than the Home page / colors.
#82 is our priority for right now. I'm not sure why #49 was folded in here as well, that one was not prioritized for dev work on the Project board.
Please focus PRs on one issue at a time.
machikoyasuda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #65
What this PR does
Home Page
Layouts
classeson the<body>element from alayoutpostingclass to the<body>element on job post pagesJob Postings
mainelement on the page, for both Desktop and Mobile.<h1>on the page.<h2>s on the page to actually use styles from.h3, so it matches the designs.Jobs
CSS refactors
Adds CSS Variables for colors
Adds overrides Bootstrap's CSS Variables https://getbootstrap.com/docs/5.2/components/buttons/#variables for
btn,btn-primary,btn-outline-primaryStart the Style Guide
Headlines
Create classes for
.h1-.h5, along with regular style declarations forh1-h5elements.Use
calc(##rem / 16)style for font sizesFont families
bs-font-sans-serif,bs-font-monospacesans-serifnotsan-serif. Sans means "without" in French. So it's "without serifs".Colors
bodycolors,border-lightThings that actually changed colors from this PR, aside from variables:
#262626to#1c1c1c#01B4CBto#51B1C7Buttons
btn btn-primarybtn btn-primary disabledbtn btn-outline-primarybtn btn-outline-primary disabledbtn btn-primaryin focus