Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 13, 2026

fixes #49772

PR description:

Title says it all.

PR validation:

scram b runtests_createDBObjects runs fine

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 13, 2026

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor Author

mmusich commented Jan 13, 2026

urgent

  • fixes unit test failures in IBs

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • CondTools/SiPixel (db)

@Alejandro1400, @JanChyczynski, @arunhep, @atpathak, @cmsbuild, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @VinInn, @dkotlins, @ferencek, @mmusich, @mroguljic, @rsreds, @tsusa, @yuanchao this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jan 13, 2026

@cmsbuild, please test

process.load(recoGeometry_cff)
process.load(geometry_cff)

# trick to get the T33 GT instead
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mmusich for having provided the fix.
Is this trick really needed, after you have changed T33 with T35 in CondTools/SiPixel/test/createTestDBObjects.sh?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perrotta

yes because the GT key phase2_realistic_T35 does not exist, but I am planning to add it in #49790 (draft for now)
I would propose to merge this to get IBs running and then we can revisit it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perrotta

FYI, this is now undone at 896e606.

I will un-draft the PR once it passes integration tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perrotta

FYI, this is now undone at 896e606.

I will un-draft the PR once it passes integration tests.

Thank you!

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e1b38/50559/summary.html
COMMIT: 78d55dc
CMSSW: CMSSW_16_1_X_2026-01-12-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49789/50559/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

----- Begin Fatal Exception 13-Jan-2026 10:07:25 CET-----------------------
An exception of category 'OutOfBound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 4 stream: 0
   [1] Running path 'HLTriggerFinalPath'
   [2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
   [3] Prefetching for module L1HPSPFTauProducer/'l1tHPSPFTauProducer'
   [4] Prefetching for module L1TPFCandMultiMerger/'l1tLayer1'
   [5] Prefetching for module L1TCorrelatorLayer1Producer/'l1tLayer1HGCal'
   [6] Calling method for module HGCalBackendLayer2Producer/'l1tHGCalBackEndLayer2Producer'
Exception Message:
TC X1 = 0.0713466 out of the seeding histogram bounds 0.076 - 0.58
----- End Fatal Exception -------------------------------------------------

@mmusich
Copy link
Contributor Author

mmusich commented Jan 13, 2026

ignore tests-rejected with ib-failure

@perrotta
Copy link
Contributor

+db

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1724617 into cms-sw:master Jan 13, 2026
9 of 10 checks passed
@mmusich mmusich deleted the mm_fix_condtools_sipixel_unit_test branch January 13, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit tests are failing withConfigFileReadError

4 participants