-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix unit test createTestDBObjects after integration of #49725
#49789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix unit test createTestDBObjects after integration of #49725
#49789
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49789/47422 |
|
urgent
|
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@Alejandro1400, @JanChyczynski, @arunhep, @atpathak, @cmsbuild, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
| process.load(recoGeometry_cff) | ||
| process.load(geometry_cff) | ||
|
|
||
| # trick to get the T33 GT instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mmusich for having provided the fix.
Is this trick really needed, after you have changed T33 with T35 in CondTools/SiPixel/test/createTestDBObjects.sh?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
-1 Failed Tests: RelVals Failed RelVals |
|
ignore tests-rejected with ib-failure |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
fixes #49772
PR description:
Title says it all.
PR validation:
scram b runtests_createDBObjectsruns fineIf this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A