Phase2-hgx365C Try to avoid the complation issue as reported by Akrit Behera for HGCalTypes in UBSCAN platform #49811

bsunanda · 2026-01-14T08:00:31Z

PR description:

Try to avoid the complation issue as reported by Akrit Behera for HGCalTypes in UBSCAN platform

PR validation:

Move some of the sequences from the header to the "cc" part

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

…alTypes in UBSCAN platform

cmsbuild · 2026-01-14T08:00:58Z

cms-bot internal usage

cmsbuild · 2026-01-14T08:03:23Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49811/47457

There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/HGCalCommonData/interface/HGCalTypes.h modified in PR(s): Use string_view to fix constexpr std::string comp error in UBSAN_X IBs #49792
- File Geometry/HGCalCommonData/src/HGCalTypes.cc modified in PR(s): Use string_view to fix constexpr std::string comp error in UBSAN_X IBs #49792

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49811/47457/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49811/47457/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2026-01-14T08:09:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49811/47458

There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/HGCalCommonData/interface/HGCalTypes.h modified in PR(s): Use string_view to fix constexpr std::string comp error in UBSAN_X IBs #49792
- File Geometry/HGCalCommonData/src/HGCalTypes.cc modified in PR(s): Use string_view to fix constexpr std::string comp error in UBSAN_X IBs #49792

cmsbuild · 2026-01-14T08:10:23Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData (geometry)

@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth can you please review it and eventually sign? Thanks.
@fabiocos, @martinamalberti this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2026-01-14T08:11:11Z

@cmsbuild Please test

smuzaffar · 2026-01-14T09:17:57Z

please test using full cmssw for CMSSW_16_1_UBSAN_X

lets check if this fixes the ubsan build errors.

cmsbuild · 2026-01-14T09:45:11Z

-1

Failed Tests: RelVals
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d40746/50597/summary.html
COMMIT: 6cfcd42
CMSSW: CMSSW_16_1_X_2026-01-13-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49811/50597/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

34634.999

----- Begin Fatal Exception 14-Jan-2026 10:02:22 CET-----------------------
An exception of category 'OutOfBound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 4 stream: 0
   [1] Running path 'HLTriggerFinalPath'
   [2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
   [3] Prefetching for module L1HPSPFTauProducer/'l1tHPSPFTauProducer'
   [4] Prefetching for module L1TPFCandMultiMerger/'l1tLayer1'
   [5] Prefetching for module L1TCorrelatorLayer1Producer/'l1tLayer1HGCal'
   [6] Calling method for module HGCalBackendLayer2Producer/'l1tHGCalBackEndLayer2Producer'
Exception Message:
TC X1 = 0.0713466 out of the seeding histogram bounds 0.076 - 0.58
----- End Fatal Exception -------------------------------------------------

cmsbuild · 2026-01-14T14:15:27Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d40746/50600/summary.html
COMMIT: 6cfcd42
CMSSW: CMSSW_16_1_UBSAN_X_2026-01-12-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49811/50600/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d40746/50600/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d40746/50600/git-merge-result

Failed Build

I found compilation error when building:

>> Compiling  src/Geometry/HGCalCommonData/src/HGCalWaferMask.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/gcc/13.4.0-6908cfdf803923e783448096ca4f0923/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DCMS_UNDEFINED_SANITIZER -DTBB_USE_GLIBCXX_VERSION=130400 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DGNU_GCC -DG4V9 -DGNU_GCC -DG4V9 -DDD4HEP_USE_GEANT4_UNITS=1 -DCMSSW_GIT_HASH='CMSSW_16_1_UBSAN_X_2026-01-12-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_16_1_UBSAN_X_2026-01-12-2300' -Isrc -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/dd4hep/v01-31-0x-8ab5d7f72a3cba6ad98d36bb3079f158/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/geant4/11.2.2-094dbb1158516ecfa47b0e5435e73c6a/include/Geant4 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/geant4/11.2.2-094dbb1158516ecfa47b0e5435e73c6a/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/pcre/8.43-6d98fda3bfd074ebb583e2d6a2c75d25/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/boost/1.80.0-b819d3899535842b3b08dcd6a725af1a/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/bz2lib/1.0.6-d113e1c6278c07eeaff5f84db9548446/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/clhep/2.4.7.1-caf57578c24c3884afdedd94a88b58d7/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/expat/2.4.8-90d4121d63d495f95df72519ccbb6e9c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/gsl/2.6-9011a41928244b609ca4c22c439b3fef/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/libuuid/2.34-5ba7a8abfc0c5fecdc448cca360c25ff/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/lcg/root/6.36.07-bd71f88d9cd20e5042c0ac03a7e23595/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/tbb/v2022.3.0-88eb7be4ee320d604a798a914aea6359/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/vecgeom/v1.2.11-a447d0f7bbf17b0a834452d93097bc3c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/vecgeom/v1.2.11-a447d0f7bbf17b0a834452d93097bc3c/include/VecGeom -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/xerces-c/3.1.3-ab719034dc2061fa61b09353203a0c2d/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/xz/5.6.4-b9c4ffbc390ed320a5d57fd552e29a05/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/zlib/1.2.13-589f6bb51bbeba38a7adf5a10ea8a093/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-95c02b8a883b2934decb8bb53ff9b486/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-95c02b8a883b2934decb8bb53ff9b486/include/eigen3 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/md5/1.0.0-26057075013e190e56dad37d35219376/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/OpenBLAS/0.3.27-da4a3c2bb8ae43f3913a4a44acdb1b50/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/tinyxml2/6.2.0-67924ead96ecb4e69aad321b767979a5/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -fno-omit-frame-pointer -fsanitize=undefined -fsanitize=builtin -fsanitize=pointer-overflow -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -ftls-model=global-dynamic -pthread -DBOOST_DISABLE_ASSERTS -g -fPIC -MMD -MF tmp/el8_amd64_gcc13/src/Geometry/HGCalCommonData/src/GeometryHGCalCommonData/HGCalWaferMask.cc.d src/Geometry/HGCalCommonData/src/HGCalWaferMask.cc -o tmp/el8_amd64_gcc13/src/Geometry/HGCalCommonData/src/GeometryHGCalCommonData/HGCalWaferMask.cc.o
>> Compiling  src/Geometry/HGCalCommonData/src/HGCalWaferType.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/gcc/13.4.0-6908cfdf803923e783448096ca4f0923/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DCMS_UNDEFINED_SANITIZER -DTBB_USE_GLIBCXX_VERSION=130400 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DGNU_GCC -DG4V9 -DGNU_GCC -DG4V9 -DDD4HEP_USE_GEANT4_UNITS=1 -DCMSSW_GIT_HASH='CMSSW_16_1_UBSAN_X_2026-01-12-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_16_1_UBSAN_X_2026-01-12-2300' -Isrc -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/dd4hep/v01-31-0x-8ab5d7f72a3cba6ad98d36bb3079f158/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/geant4/11.2.2-094dbb1158516ecfa47b0e5435e73c6a/include/Geant4 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/geant4/11.2.2-094dbb1158516ecfa47b0e5435e73c6a/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/pcre/8.43-6d98fda3bfd074ebb583e2d6a2c75d25/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/boost/1.80.0-b819d3899535842b3b08dcd6a725af1a/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/bz2lib/1.0.6-d113e1c6278c07eeaff5f84db9548446/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/clhep/2.4.7.1-caf57578c24c3884afdedd94a88b58d7/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/expat/2.4.8-90d4121d63d495f95df72519ccbb6e9c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/gsl/2.6-9011a41928244b609ca4c22c439b3fef/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/libuuid/2.34-5ba7a8abfc0c5fecdc448cca360c25ff/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/lcg/root/6.36.07-bd71f88d9cd20e5042c0ac03a7e23595/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/tbb/v2022.3.0-88eb7be4ee320d604a798a914aea6359/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/vecgeom/v1.2.11-a447d0f7bbf17b0a834452d93097bc3c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/vecgeom/v1.2.11-a447d0f7bbf17b0a834452d93097bc3c/include/VecGeom -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/xerces-c/3.1.3-ab719034dc2061fa61b09353203a0c2d/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/xz/5.6.4-b9c4ffbc390ed320a5d57fd552e29a05/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/zlib/1.2.13-589f6bb51bbeba38a7adf5a10ea8a093/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-95c02b8a883b2934decb8bb53ff9b486/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-95c02b8a883b2934decb8bb53ff9b486/include/eigen3 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/md5/1.0.0-26057075013e190e56dad37d35219376/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/OpenBLAS/0.3.27-da4a3c2bb8ae43f3913a4a44acdb1b50/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02924/el8_amd64_gcc13/external/tinyxml2/6.2.0-67924ead96ecb4e69aad321b767979a5/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -fno-omit-frame-pointer -fsanitize=undefined -fsanitize=builtin -fsanitize=pointer-overflow -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -ftls-model=global-dynamic -pthread -DBOOST_DISABLE_ASSERTS -g -fPIC -MMD -MF tmp/el8_amd64_gcc13/src/Geometry/HGCalCommonData/src/GeometryHGCalCommonData/HGCalWaferType.cc.d src/Geometry/HGCalCommonData/src/HGCalWaferType.cc -o tmp/el8_amd64_gcc13/src/Geometry/HGCalCommonData/src/GeometryHGCalCommonData/HGCalWaferType.cc.o
src/Geometry/HGCalCommonData/src/HGCalTypes.cc: In static member function 'static std::string HGCalTypes::layerTypeX(int32_t)':
src/Geometry/HGCalCommonData/src/HGCalTypes.cc:55:85: error: '(((const std::string*)(& layerTypes)) != 0)' is not a constant expression
   55 |       "Center", "CenterB", "CenterYp", "CenterYm", "CenterR", "CenterXp", "CenterXm"};
      |                                                                                     ^
src/Geometry/HGCalCommonData/src/HGCalTypes.cc: In static member function 'static std::string HGCalTypes::waferType(int32_t)':
src/Geometry/HGCalCommonData/src/HGCalTypes.cc:60:82: error: '(((const std::string*)(& waferType)) != 0)' is not a constant expression
   60 |   static constexpr std::string waferType[4] = {"HD120", "LD200", "LD300", "HD200"};

makortel · 2026-01-14T14:20:13Z

This PR conflicts with #49792, no?

makortel · 2026-01-14T14:21:39Z

Geometry/HGCalCommonData/src/HGCalTypes.cc

+  static constexpr std::string layerTypes[7] = {
+      "Center", "CenterB", "CenterYp", "CenterYm", "CenterR", "CenterXp", "CenterXm"};


std::string can not be used as constexpr like this even if it compiles. The constexpr-ness of std::string means that it can be used in constexpr functions. constexpr std::string objects outside of constexpr functions are IIRC undefined behavior (or "program is ill-formed, no diagnostic required", or similar).

cmsbuild · 2026-01-15T07:06:41Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49811/47497

There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/HGCalCommonData/interface/HGCalTypes.h modified in PR(s): Use string_view to fix constexpr std::string comp error in UBSAN_X IBs #49792, [DO NOT MERGE ]Revert "Phase2-hgx364X Add the tools with some more diagnostic help to debug the issue of wrong DetID->Position->DetID assignment" #49831
- File Geometry/HGCalCommonData/src/HGCalTypes.cc modified in PR(s): Use string_view to fix constexpr std::string comp error in UBSAN_X IBs #49792, [DO NOT MERGE ]Revert "Phase2-hgx364X Add the tools with some more diagnostic help to debug the issue of wrong DetID->Position->DetID assignment" #49831

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49811/47497/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49811/47497/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2026-01-15T07:10:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49811/47498

There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/HGCalCommonData/interface/HGCalTypes.h modified in PR(s): Use string_view to fix constexpr std::string comp error in UBSAN_X IBs #49792, [DO NOT MERGE ]Revert "Phase2-hgx364X Add the tools with some more diagnostic help to debug the issue of wrong DetID->Position->DetID assignment" #49831
- File Geometry/HGCalCommonData/src/HGCalTypes.cc modified in PR(s): Use string_view to fix constexpr std::string comp error in UBSAN_X IBs #49792, [DO NOT MERGE ]Revert "Phase2-hgx364X Add the tools with some more diagnostic help to debug the issue of wrong DetID->Position->DetID assignment" #49831

cmsbuild · 2026-01-15T07:11:15Z

Pull request #49811 was updated. @Dr15Jones, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth can you please check and sign again.

bsunanda · 2026-01-15T08:32:40Z

@cmsbuild Please test

cmsbuild · 2026-01-15T10:27:47Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d40746/50647/summary.html
COMMIT: 32651a9
CMSSW: CMSSW_16_1_X_2026-01-14-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49811/50647/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 52
DQMHistoTests: Total histograms compared: 4025536
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4025510
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
Checked 222 log files, 193 edm output root files, 52 DQM output files
TriggerResults: no differences found

bsunanda · 2026-01-15T11:07:55Z

+geometry

cmsbuild · 2026-01-15T11:08:18Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2026-01-15T19:19:54Z

+1

Try to avoid the complation issue as reported by Akrit Behera for HGC…

5443ca6

…alTypes in UBSCAN platform

cmsbuild added this to the CMSSW_16_1_X milestone Jan 14, 2026

cmsbuild added geometry-pending pending-signatures tests-pending orp-pending code-checks-pending labels Jan 14, 2026

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jan 14, 2026

Code check

6cfcd42

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jan 14, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 14, 2026

cmsbuild added tests-started and removed tests-pending labels Jan 14, 2026

cmsbuild added tests-rejected and removed tests-started labels Jan 14, 2026

makortel reviewed Jan 14, 2026

View reviewed changes

cmsbuild mentioned this pull request Jan 14, 2026

[DO NOT MERGE ]Revert "Phase2-hgx364X Add the tools with some more diagnostic help to debug the issue of wrong DetID->Position->DetID assignment" #49831

Draft

Change constexpr to const for std::string

b1af5b2

cmsbuild added tests-pending code-checks-pending labels Jan 15, 2026

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jan 15, 2026

Code check

32651a9

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jan 15, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 15, 2026

cmsbuild added tests-started and removed tests-pending labels Jan 15, 2026

cmsbuild added tests-approved and removed tests-started labels Jan 15, 2026

cmsbuild added geometry-approved fully-signed and removed geometry-pending pending-signatures labels Jan 15, 2026

cmsbuild added orp-approved and removed orp-pending labels Jan 15, 2026

cmsbuild merged commit 28ed086 into cms-sw:master Jan 15, 2026
10 checks passed

This was referenced Jan 16, 2026

Avoid test name clashes #49844

Merged

[ROOT639] Updated root to tip of branch master cms-sw/cmsdist#10274

Merged

		static constexpr std::string layerTypes[7] = {
		"Center", "CenterB", "CenterYp", "CenterYm", "CenterR", "CenterXp", "CenterXm"};

Phase2-hgx365C Try to avoid the complation issue as reported by Akrit Behera for HGCalTypes in UBSCAN platform #49811

Phase2-hgx365C Try to avoid the complation issue as reported by Akrit Behera for HGCalTypes in UBSCAN platform #49811

Uh oh!

Conversation

bsunanda commented Jan 14, 2026

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Uh oh!

cmsbuild commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jan 14, 2026

Uh oh!

cmsbuild commented Jan 14, 2026

Uh oh!

cmsbuild commented Jan 14, 2026

Uh oh!

bsunanda commented Jan 14, 2026

Uh oh!

smuzaffar commented Jan 14, 2026

Uh oh!

cmsbuild commented Jan 14, 2026

Failed RelVals

Uh oh!

cmsbuild commented Jan 14, 2026

Failed Build

Uh oh!

makortel commented Jan 14, 2026

Uh oh!

makortel Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Jan 15, 2026

Uh oh!

cmsbuild commented Jan 15, 2026

Uh oh!

cmsbuild commented Jan 15, 2026

Uh oh!

bsunanda commented Jan 15, 2026

Uh oh!

cmsbuild commented Jan 15, 2026

Comparison Summary

Uh oh!

bsunanda commented Jan 15, 2026

Uh oh!

cmsbuild commented Jan 15, 2026

Uh oh!

mandrenguyen commented Jan 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cmsbuild commented Jan 14, 2026 •

edited

Loading