[16_0_X] Add time info to Run3ScoutingHBHERecHit #49718

patinkaew · 2026-01-05T14:12:05Z

Backport of #49715 to 16_0_X for 2026 data-taking.

…roducer accordingly

cmsbuild · 2026-01-05T14:12:27Z

A new Pull Request was created by @patinkaew for CMSSW_16_0_X.

It involves the following packages:

DataFormats/Scouting (core)
HLTrigger/special (hlt)

@Dr15Jones, @Martin-Grunewald, @cmsbuild, @makortel, @mmusich, @smuzaffar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Backported from Add time info to Run3ScoutingHBHERecHit #49715

cmsbuild · 2026-01-05T14:12:29Z

cms-bot internal usage

Martin-Grunewald · 2026-01-05T14:22:54Z

Does this require a backport of #49702 ?

mmusich · 2026-01-06T07:50:51Z

backport of #49715

mmusich · 2026-01-06T07:50:59Z

type hlt-integration

mmusich · 2026-01-06T07:53:57Z

Does this require a backport of #49702 ?

ultimately yes.

mmusich · 2026-01-06T07:54:03Z

@cmsbuild, please test

cmsbuild · 2026-01-06T10:12:22Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9b52b/50441/summary.html
COMMIT: c8746be
CMSSW: CMSSW_16_0_X_2026-01-05-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49718/50441/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 12 differences found in the comparisons
Reco comparison had 4 failed jobs
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4280553
DQMHistoTests: Total failures: 356
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4280177
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 198 edm output root files, 53 DQM output files
TriggerResults: found differences in 1 / 51 workflows

mmusich · 2026-01-06T10:35:32Z

I guess #49715 (comment) applies also here.

makortel · 2026-01-06T14:35:42Z

I guess #49715 (comment) applies also here.

Yes.

cmsbuild · 2026-01-07T12:59:42Z

Pull request #49718 was updated. @Dr15Jones, @Martin-Grunewald, @cmsbuild, @makortel, @mmusich, @smuzaffar can you please check and sign again.

mmusich · 2026-01-07T13:03:02Z

@cmsbuild, please test

mmusich · 2026-01-08T09:25:36Z

test parameters:

addpkg = DQM/Integration

mmusich · 2026-01-08T09:25:42Z

@cmsbuild, please test

cmsbuild · 2026-01-08T11:51:38Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9b52b/50474/summary.html
COMMIT: 0b9f472
CMSSW: CMSSW_16_0_X_2026-01-07-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49718/50474/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMOnlineClient-scouting_dqm_sourceclient had ERRORS

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
Reco comparison had 4 failed jobs
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4280553
DQMHistoTests: Total failures: 92
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4280441
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 198 edm output root files, 53 DQM output files
TriggerResults: no differences found

mmusich · 2026-01-12T08:29:54Z

test parameters:

addpkg = DQM/Integration
pull_request = update run to be used for the scouting_dqm_sourceclient unit test [16.0.X] #49767, [16.0.X] Update tag for DQM-Integration to V00-14-00 cmsdist#10272

mmusich · 2026-01-12T08:30:00Z

@cmsbuild, please test

cmsbuild · 2026-01-12T10:40:40Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9b52b/50519/summary.html
COMMIT: 0b9f472
CMSSW: CMSSW_16_0_X_2026-01-11-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49718/50519/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 16 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 7 differences found in the comparisons
Reco comparison had 4 failed jobs
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4280553
DQMHistoTests: Total failures: 50
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4280483
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 198 edm output root files, 53 DQM output files
TriggerResults: no differences found

cmsbuild · 2026-01-13T08:50:45Z

REMINDER @sextonkennedy, @mandrenguyen, @ftenchini: This PR was tested with #49767, please check if they should be merged together

mmusich · 2026-01-13T09:41:39Z

@cms-sw/core-l2 since #49767 and cms-sw/cmsdist#10272 already got merged (and they depend on this) can we have this PR merged ?

makortel · 2026-01-13T14:48:08Z

+core

since #49767 and cms-sw/cmsdist#10272 already got merged (and they depend on this) can we have this PR merged ?

Fine for me, although the master PR #49702 is still open and has not been backported (i.e. this is a deviation from the plan in #49718 (comment)).

cmsbuild · 2026-01-13T14:48:33Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_16_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2026-01-14T05:49:59Z

+1

add time info to Run3ScoutingHBHERecHit and update HLTScoutingRecHitP…

c8746be

…roducer accordingly

cmsbuild added this to the CMSSW_16_0_X milestone Jan 5, 2026

cmsbuild added hlt-pending core-pending pending-signatures tests-pending orp-pending changes-dataformats labels Jan 5, 2026

cmsbuild added backport hlt-integration labels Jan 6, 2026

cmsbuild added tests-started and removed tests-pending labels Jan 6, 2026

cmsbuild added tests-approved and removed tests-started labels Jan 6, 2026

update default version of Run3ScoutingHBHERecHit to 4

0b9f472

cmsbuild added tests-pending and removed tests-approved labels Jan 7, 2026

cmsbuild removed the tests-pending label Jan 7, 2026

cmsbuild added tests-started and removed tests-approved labels Jan 8, 2026

cmsbuild added tests-rejected and removed tests-started labels Jan 8, 2026

This was referenced Jan 8, 2026

update dqm online scouting unit test #49746

Merged

update run to be used for the scouting_dqm_sourceclient unit test [16.0.X] #49767

Merged

cmsbuild added requires-external tests-started and removed tests-rejected labels Jan 12, 2026

cmsbuild added tests-approved and removed tests-started labels Jan 12, 2026

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Jan 13, 2026

cmsbuild added orp-approved and removed orp-pending labels Jan 14, 2026

cmsbuild merged commit a9ad811 into cms-sw:CMSSW_16_0_X Jan 14, 2026
9 checks passed

mmusich mentioned this pull request Jan 14, 2026

Introduce DQM for Run3ScoutingHBHERecHit time [16.0.X] #49812

Merged

[16_0_X] Add time info to Run3ScoutingHBHERecHit #49718

[16_0_X] Add time info to Run3ScoutingHBHERecHit #49718

Uh oh!

Conversation

patinkaew commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Martin-Grunewald commented Jan 5, 2026

Uh oh!

mmusich commented Jan 6, 2026

Uh oh!

mmusich commented Jan 6, 2026

Uh oh!

mmusich commented Jan 6, 2026

Uh oh!

mmusich commented Jan 6, 2026

Uh oh!

cmsbuild commented Jan 6, 2026

Comparison Summary

Uh oh!

mmusich commented Jan 6, 2026

Uh oh!

makortel commented Jan 6, 2026

Uh oh!

cmsbuild commented Jan 7, 2026

Uh oh!

mmusich commented Jan 7, 2026

Uh oh!

mmusich commented Jan 8, 2026

Uh oh!

mmusich commented Jan 8, 2026

Uh oh!

cmsbuild commented Jan 8, 2026

Failed Unit Tests

Comparison Summary

Uh oh!

mmusich commented Jan 12, 2026

Uh oh!

mmusich commented Jan 12, 2026

Uh oh!

cmsbuild commented Jan 12, 2026

Comparison Summary

Uh oh!

cmsbuild commented Jan 13, 2026

Uh oh!

mmusich commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

makortel commented Jan 13, 2026

Uh oh!

cmsbuild commented Jan 13, 2026

Uh oh!

mandrenguyen commented Jan 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

patinkaew commented Jan 5, 2026 •

edited

Loading

cmsbuild commented Jan 5, 2026 •

edited

Loading

cmsbuild commented Jan 5, 2026 •

edited

Loading

mmusich commented Jan 13, 2026 •

edited

Loading