Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 8, 2026

PR description:

Title says it all, necessary after the merge of #49715.
See #49715 (comment) for a rationale.
To be tested together with the companion cms-data PR cms-data/DQM-Integration#16

PR validation:

scram b runtests_TestDQMOnlineClient-scouting_dqm_sourceclient runs correctly in conjunction of the update of the unit test input files (see cms-data/DQM-Integration#16)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backport to CMSSW_16_0_X (necessary for #49718)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2026

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Jan 8, 2026

test parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2026

@mmusich
Copy link
Contributor Author

mmusich commented Jan 8, 2026

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2026

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQM/Integration (dqm)

@ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@batinkov, @francescobrivio, @threus this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2026

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddbb5c/50478/summary.html
COMMIT: af6c6ea
CMSSW: CMSSW_16_1_X_2026-01-07-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49746/50478/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 5 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4295913
  • DQMHistoTests: Total failures: 70
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4295823
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Jan 9, 2026

king ping @cms-sw/dqm-l2 to review this.

@gabrielmscampos
Copy link
Member

+dqm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/DQM-Integration#16

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c5cf5f8 into cms-sw:master Jan 12, 2026
11 checks passed
@mmusich mmusich deleted the mm_update_DQMOnlineScouting_unitTest branch January 12, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants