Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 14, 2026

backport of #49769

PR description:

This PR is based upon the update of the Run3ScoutingHBHERecHit scouting data format introduced at #49718.
The purpose is to add monitoring of the HBHE scouting rechit time in the dedicated online / offline scouting DQM

PR validation:

cmssw compiles, run successfully runTheMatrix.py -l 16834.0 -t 4 -j 8.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #49769 for 2026 data-taking operations.

@mmusich
Copy link
Contributor Author

mmusich commented Jan 14, 2026

test parameters:

  • addpkg = DQM/Integration
  • relval_opts = -w data_highstats --nEvents 100
  • workflow = 2025.016005

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 14, 2026

A new Pull Request was created by @mmusich for CMSSW_16_0_X.

It involves the following packages:

  • DQM/HLTEvF (dqm, hlt)
  • HLTriggerOffline/Scouting (dqm)

@Martin-Grunewald, @cmsbuild, @ctarricone, @gabrielmscampos, @mmusich, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@missirol, @mtosi this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 14, 2026

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Jan 14, 2026

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d7e578/50598/summary.html
COMMIT: 9204a5e
CMSSW: CMSSW_16_0_X_2026-01-13-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49812/50598/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d7e578/50598/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d7e578/50598/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 90 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 126 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4238646
  • DQMHistoTests: Total failures: 13026
  • DQMHistoTests: Total nulls: 33
  • DQMHistoTests: Total successes: 4225567
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -385661.0809999999 KiB( 53 files compared)
  • DQMHistoSizes: changed ( 2025.016005,... ): 2094.036 KiB HLT/ScoutingOffline
  • DQMHistoSizes: changed ( 2025.016005,... ): 3.955 KiB HLT/TAU
  • DQMHistoSizes: changed ( 2025.016005,... ): 2.376 KiB HLT/Filters
  • DQMHistoSizes: changed ( 16834.0,... ): -43437.139 KiB HLT/JME
  • DQMHistoSizes: changed ( 16834.0,... ): -23609.781 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 16834.0,... ): -21904.327 KiB HLT/Tracking
  • DQMHistoSizes: changed ( 16834.0,... ): -14140.359 KiB HLT/EGM
  • DQMHistoSizes: changed ( 16834.0,... ): -13814.032 KiB HLT/BTV
  • DQMHistoSizes: changed ( 16834.0,... ): -10390.469 KiB HLT/SiStrip
  • DQMHistoSizes: changed ( 16834.0,... ): -10361.636 KiB HLT/EXO
  • DQMHistoSizes: changed ( 16834.0 ): ...
  • Checked 231 log files, 202 edm output root files, 54 DQM output files
  • TriggerResults: found differences in 5 / 52 workflows

@mmusich
Copy link
Contributor Author

mmusich commented Jan 14, 2026

+hlt

@nothingface0
Copy link
Contributor

nothingface0 commented Jan 15, 2026

DQMHistoSizes: Histogram memory added: -385661.0809999999 KiB( 53 files compared)

@mmusich How could this be explained, since the PR should be adding memory to the histograms, not removing? It's also a huge amount, is it even correct?

Unless it's due to any of the 4 PRs that cmsbot automatically added? It's probably #49766, right?

@mmusich
Copy link
Contributor Author

mmusich commented Jan 15, 2026

Unless it's due to any of the 4 PRs that cmsbot automatically added? It's probably #49766, right?

that's correct. The change is not coming from the PR itself.

@nothingface0
Copy link
Contributor

+dqm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_16_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f1f53d2 into cms-sw:CMSSW_16_0_X Jan 16, 2026
9 checks passed
@mmusich mmusich deleted the mm_dev_scoutingMonitoringHBHERechitTime_16_0_X branch January 16, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants