Add time info to Run3ScoutingHBHERecHit

[patinkaew]

PR description:

This PR complements #49702 by adding time to Run3ScoutingHBHERecHit format so updated HCAL TDC time is saved.

PR validation:

Passed scram b runtests use-ibeos.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is not a backport, but backport to 16_0_X will follow for 2026 data-taking.

FYI @silviodonato @wang-hui

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49715/47297

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DataFormats/Scouting/test/TestReadRun3Scouting.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
  • File DataFormats/Scouting/test/TestWriteRun3Scouting.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

[cmsbuild]

A new Pull Request was created by @patinkaew for master.

It involves the following packages:

• DataFormats/Scouting (core)
• HLTrigger/special (hlt)

@Dr15Jones, @Martin-Grunewald, @cmsbuild, @makortel, @mmusich, @smuzaffar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

test parameters:

• pull_request = Add HCAL TDC time to MAHI ALPAKA recHits #49702

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 44KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18d899/50421/summary.html
COMMIT: c8746be
CMSSW: CMSSW_16_1_X_2026-01-03-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49715/50421/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 4 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 12 differences found in the comparisons
• Reco comparison had 4 failed jobs
• DQMHistoTests: Total files compared: 53
• DQMHistoTests: Total histograms compared: 4280553
• DQMHistoTests: Total failures: 184
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4280349
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
• Checked 227 log files, 198 edm output root files, 53 DQM output files
• TriggerResults: no differences found

[mmusich]

type hlt-integration

[mmusich]

+hlt

[makortel]

I think in the read part of the test the default expected HBHERecHit class version

cmssw/DataFormats/Scouting/test/test_readRun3Scouting_cfg.py

Line 13 in c8746be

parser.add_argument("--hbheRecHitVersion", type=int, help="HBHERecHit data format version (default: 3)", default=3)

should be updated to 4 so that the new functionality gets tested in

cmssw/DataFormats/Scouting/test/TestRun3ScoutingFormats.sh

Lines 7 to 9 in c8746be

	cmsRun ${LOCAL_TEST_DIR}/create_Run3Scouting_test_file_cfg.py || die 'Failure using create_Run3Scouting_test_file_cfg.py' $?
	cmsRun ${LOCAL_TEST_DIR}/test_readRun3Scouting_cfg.py || die "Failure using test_readRun3Scouting_cfg.py" $?

(then a new test file would be needed after the next 16_1_X prerelease, but we should open an issue about that to remind us)

[mmusich]

@patinkaew please apply the suggestion at #49715 (comment)

[makortel]

Thanks @mmusich. Just as a cross check I want to see the impact of this PR alone.

[makortel]

The code changes themselves look fine.

[patinkaew]

Hi @makortel, here is the issue: #49738 to update unit test with a new test file after 16_1_0_pre1 is built.

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18d899/50466/summary.html
COMMIT: 1560b0a
CMSSW: CMSSW_16_1_X_2026-01-07-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49715/50466/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• Reco comparison had 4 failed jobs
• DQMHistoTests: Total files compared: 53
• DQMHistoTests: Total histograms compared: 4280553
• DQMHistoTests: Total failures: 115
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4280418
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
• Checked 227 log files, 198 edm output root files, 53 DQM output files
• TriggerResults: no differences found

[makortel]

Comparison differences are related to #47071

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1

[mmusich]

for the record, this PR causes a failure in one of the DQM online clients, see log.
The reason is a change in the layout of the input streamer file.
A new file including the new scouting rechits data-format is needed at https://github.com/cms-data/DQM-Integration.
There are instructions on how to create it in the README file. @patinkaew FYI

[mmusich]

A new file including the new scouting rechits data-format is needed at https://github.com/cms-data/DQM-Integration.

I followed up at cms-data/DQM-Integration#16 + #49746

[patinkaew]

Hi @mmusich, sorry and thank you for taking care of this!

[makortel]

A new file including the new scouting rechits data-format is needed at https://github.com/cms-data/DQM-Integration.

By the way, since the starting point is a ROOT file, the conversion from ROOT to streamer could be done on the fly by the test, in which case the test input files would not have to be updated for class version changes.

[mmusich]

By the way, since the starting point is a ROOT file, the conversion from ROOT to streamer could be done on the fly by the test, in which case the test input files would not have to be updated for class version changes.

I'd rather not do that, because there is also an interplay with the HLT menu to be used to convert back from ROOT to streamer, and that might have to be adjusted on a release by release basis.

[mmusich]

the Run3ScoutingHBHERecHit time is not yet plotted by DQM, but I plan to add plots for them shortly after this PR is merged.

This is followed up at #49769