-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Update high purity ID and simplify HLT LST configurations #49382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update high purity ID and simplify HLT LST configurations #49382
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49382/46807
|
|
A new Pull Request was created by @VourMa for master. It involves the following packages:
@Martin-Grunewald, @cmsbuild, @ctarricone, @davidlange6, @fabiocos, @ftenchini, @gabrielmscampos, @jfernan2, @mandrenguyen, @mmusich, @nothingface0, @rseidita, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
test parameters:
|
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 80KB to repository HLT P2 Timing: chart Comparison SummarySummary:
|
|
@VourMa thanks for the simplification of the configuration. |
Sure, I will arrange a presentation in the TRK POG meeting next week, and we can discuss there. |
@mmusich I have requested the slot for the presentation and I am waiting the confirmation by the TRK conveners. I will post the link here and in the description when this is done. In the meantime, this is becoming a blocking piece for other developments that we have. In the interest of time, would you like to elaborate on your concerns? |
|
@cmsbuild please test |
|
+1 Size: This PR adds an extra 16KB to repository HLT P2 Timing: chart Comparison SummarySummary:
|
|
A presentation about this PR will be given in: |
|
+hlt
|
|
@cms-sw/reconstruction-l2, @cms-sw/dqm-l2 and @cms-sw/orp-l2: it would be great if this could be included in pre3 already, to allow for testing by other POGs. |
|
+1 |
|
+dqm |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
I have a proposal at #49517. |

This PR updates the high purity ID with two passthrough options:
a) Passthrough for tracks without pixel tracker hits. The only requirement for these tracks is that they have at least 4 hits (that covers T5s with a potential loss of a layer during fitting). The latter requirement is configurable.
b) Passthrough for all tracks. No requirement is applied on the tracks. This is exploited in the single iteration configurations running LST seeding, as these configurations have a very low fake+duplicate. Running the high purity module unifies the configuration and enables the correct usage in downstream objects, in case they require tracks with high purity ID.
The above updates enable a large simplification of the HLT tracking configurations, which is done also in this PR. Below, the relevant procModifier combinations have been validated. The current configuration is in blue and the configuration proposed in this PR is in red:
trackingLST, falling under option a) abovetrackingLST,seedingLST, falling under option a) abovesingleIterPatatrack,phase2CAExtension,trackingLST, falling under option a) abovesingleIterPatatrack,phase2CAExtension,trackingLST,seedingLST, falling under option b) abovephase2CAExtension,singleIterPatatrack,trackingLST,seedingLST,trackingMkFitCommon,hltTrackingMkFitInitialStep, falling under option b) aboveComments on the physics perfomance:
The corresponding presentation can be found in:
https://indico.cern.ch/event/1615436/#2-on-cmssw-pr-49382-update-hig