Skip to content

Conversation

@mmasciov
Copy link
Contributor

PR description:

As per title, this PR is meant to fix phase-2 HLT workflow with mkFit fit, reintroducing HP selection to relevant sequence, following PRs #49382, #49383 and #49339.

URGENT: ideally to go to 16_0_0_pre3, too.

PR validation:

It fixes workflow offset 0.7572 (https://github.com/trackreco/cmssw/blob/master/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py#L2048), where the corresponding (procModifiers modified) tracking sequence is otherwise incomplete.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2025

cms-bot internal usage

@mmasciov
Copy link
Contributor Author

FYI: @VourMa, @bdanzi, @leonardogiannini

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmasciov for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Nov 26, 2025

test parameters:

  • workflows = ph2_hlt

@mmusich
Copy link
Contributor

mmusich commented Nov 26, 2025

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Nov 26, 2025

urgent

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b7cb1a/49709/summary.html
COMMIT: 9eb1c8a
CMSSW: CMSSW_16_0_X_2025-11-26-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49508/49709/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 8 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 71
  • DQMHistoTests: Total histograms compared: 4769830
  • DQMHistoTests: Total failures: 3189
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4766621
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 70 files compared)
  • Checked 287 log files, 243 edm output root files, 71 DQM output files
  • TriggerResults: found differences in 1 / 69 workflows

@mmusich
Copy link
Contributor

mmusich commented Nov 26, 2025

DQMHistoTests: Total failures: 3189
TriggerResults: found differences in 1 / 69 workflows

changes are expected, given the premises.

@mmusich
Copy link
Contributor

mmusich commented Nov 26, 2025

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor

mmusich commented Nov 26, 2025

type bug-fix

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f85f32a into cms-sw:master Nov 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants