Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 27, 2025

PR description:

Along the lines of what discussed at #49382 (comment) I have implemented the monitoring of pixel-less HLT tracks for phase-2 validation purposes.

PR validation:

I've run runTheMatrix.py -l 34434.755 -t 4 -j 8 --nEvents 100 and been able to see the contribution of T5s as

Screenshot from 2025-11-27 15-07-55

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 27, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Nov 27, 2025

type ngt

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • CommonTools/RecoAlgos (reconstruction)
  • CommonTools/UtilAlgos (reconstruction)
  • Validation/RecoTrack (dqm)

@cmsbuild, @ctarricone, @gabrielmscampos, @jfernan2, @mandrenguyen, @nothingface0, @rseidita, @srimanob can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @abbiendi, @ahinzmann, @dgulhan, @elusian, @felicepantaleo, @gkasieczka, @hatakeyamak, @jdolen, @jhgoh, @missirol, @mmasciov, @mmusich, @mtosi, @rappoccio, @rovere, @wmtford this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 27, 2025

test parameters:

  • workflow = ph2_hlt

@mmusich
Copy link
Contributor Author

mmusich commented Nov 27, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: HeaderConsistency
Size: This PR adds an extra 48KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b23cb8/49720/summary.html
COMMIT: d1c1742
CMSSW: CMSSW_16_0_X_2025-11-27-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49517/49720/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 12 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 73
  • DQMHistoTests: Total histograms compared: 5003203
  • DQMHistoTests: Total failures: 89
  • DQMHistoTests: Total nulls: 149
  • DQMHistoTests: Total successes: 5002945
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 36843.68999999999 KiB( 72 files compared)
  • DQMHistoSizes: changed ( 16834.0,... ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 16834.0,... ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 34434.0,... ): 1754.458 KiB HLT/Tracking
  • Checked 295 log files, 253 edm output root files, 73 DQM output files
  • TriggerResults: found differences in 27 / 71 workflows

Copy link
Contributor

@slava77 slava77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought: would it be practical to have a "withPixels" monitoring so that the results are more clearly complementary?
It's probably still possible to decouple changes in monitoring of the mix of all tracks vs pixel-less, but it could be more clear

@mmusich
Copy link
Contributor Author

mmusich commented Nov 28, 2025

Just a thought: would it be practical to have a "withPixels" monitoring so that the results are more clearly complementary?

Thanks for the comments. I was by and large thinking the same, but unsure if someone else would find the "withPixels" useful too. I added it in the last push.

@cmsbuild
Copy link
Contributor

Pull request #49517 was updated. @cmsbuild, @ctarricone, @gabrielmscampos, @jfernan2, @mandrenguyen, @nothingface0, @rseidita, @srimanob can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 28, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 48KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b23cb8/49731/summary.html
COMMIT: 0d798b1
CMSSW: CMSSW_16_0_X_2025-11-28-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49517/49731/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 8 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 73
  • DQMHistoTests: Total histograms compared: 5003203
  • DQMHistoTests: Total failures: 33
  • DQMHistoTests: Total nulls: 150
  • DQMHistoTests: Total successes: 5003000
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 73687.38 KiB( 72 files compared)
  • DQMHistoSizes: changed ( 34434.7501,... ): 3508.916 KiB HLT/Tracking
  • DQMHistoSizes: changed ( 16834.0,... ): 0.008 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 16834.0,... ): 0.008 KiB MessageLogger/Warnings
  • Checked 295 log files, 253 edm output root files, 73 DQM output files
  • TriggerResults: found differences in 27 / 71 workflows

@slava77
Copy link
Contributor

slava77 commented Nov 28, 2025

Thanks for the comments. I was by and large thinking the same, but unsure if someone else would find the "withPixels" useful too. I added it in the last push.

thank you.
I'm guessing the the memory use cost is quite acceptable (the bot says DQMHistoSizes: Histogram memory added: 73687.38 KiB)

@mmusich
Copy link
Contributor Author

mmusich commented Dec 1, 2025

ping @cms-sw/reconstruction-l2 @cms-sw/dqm-l2

@jfernan2
Copy link
Contributor

jfernan2 commented Dec 1, 2025

+1

@gabrielmscampos
Copy link
Member

+dqm

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants