-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[NGT] add "pixel-less" and "withPixels" track validation monitoring for HLT #49517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cms-bot internal usage |
|
type ngt |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49517/47001 |
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@cmsbuild, @ctarricone, @gabrielmscampos, @jfernan2, @mandrenguyen, @nothingface0, @rseidita, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
test parameters:
|
|
@cmsbuild, please test |
|
-1 Failed Tests: HeaderConsistency DAS Queries: The DAS query tests failed, see the summary page for details. Comparison SummarySummary:
|
slava77
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a thought: would it be practical to have a "withPixels" monitoring so that the results are more clearly complementary?
It's probably still possible to decouple changes in monitoring of the mix of all tracks vs pixel-less, but it could be more clear
d1c1742 to
365e675
Compare
Thanks for the comments. I was by and large thinking the same, but unsure if someone else would find the "withPixels" useful too. I added it in the last push. |
|
Pull request #49517 was updated. @cmsbuild, @ctarricone, @gabrielmscampos, @jfernan2, @mandrenguyen, @nothingface0, @rseidita, @srimanob can you please check and sign again. |
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 48KB to repository DAS Queries: The DAS query tests failed, see the summary page for details. Comparison SummarySummary:
|
thank you. |
|
ping @cms-sw/reconstruction-l2 @cms-sw/dqm-l2 |
|
+1 |
|
+dqm |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Along the lines of what discussed at #49382 (comment) I have implemented the monitoring of pixel-less HLT tracks for phase-2 validation purposes.
PR validation:
I've run
runTheMatrix.py -l 34434.755 -t 4 -j 8 --nEvents 100and been able to see the contribution of T5s asIf this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A