[NGT] Template LayerClusters associators to support both CaloCluster and PFCluster collections #48995

elenavernazza · 2025-09-25T15:40:39Z

PR description:

This PR was co-developed by: @bfonta

This PR introduces a templated implementation of the two associators used for TICL validation:

LCToSCAssociator between LayerClusters (LC) and SimClusters (SC)
LCToCPAssociator between LayerClusters (LC) and CaloParticles (CP)
Until now, these associators supported only CaloCluster collection, which is the nominal type used for LayerClusters.
In this PR, the support is extended to PFCluster collections by templating the associator classes and the inherited types.

The changes have been implemented without affecting existing classes functionalities.
Additional protections against invalid edm::Handles have been integrated to improve code robustness.

A follow-up PR will include a DQM module for the validation of PFClusters making use of the new templated associators.

PR validation:

This PR has been validated by running Phase-2 HLT workflows using:

runTheMatrix.py -l ph2_hlt -t 0 --ibeos -i all

No failures have been observed.
All protections work as expected when processing data.

cmsbuild · 2025-09-25T15:41:08Z

cms-bot internal usage

cmsbuild · 2025-09-25T15:42:35Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48995/46174

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoHGCal/TICL/plugins/SimTrackstersProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319, Add vector of tracks to TICL tracksters and candidates and add other validation plots #48862
- File RecoLocalCalo/HGCalRecProducers/plugins/RecHitMapProducer.cc modified in PR(s): Bugfixes to TICL-barrel #48565, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToCPAssociatorByEnergyScoreImpl.cc modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToCPAssociatorByEnergyScoreProducer.cc modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToCPAssociatorByEnergyScoreProducer.h modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToCPAssociatorEDProducer.cc modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToSCAssociatorByEnergyScoreImpl.cc modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToSCAssociatorByEnergyScoreProducer.cc modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToSCAssociatorByEnergyScoreProducer.h modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToSCAssociatorEDProducer.cc modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimDataFormats/Associations/interface/LayerClusterToSimTracksterAssociatorBaseImpl.h modified in PR(s): Add directories for TICL-EGM code development #48319
- File SimDataFormats/Associations/src/classes_def.xml modified in PR(s): move dictionaries next to typedefs for TrackingParticle associations #37507
- File Validation/HGCalValidation/interface/BarrelVHistoProducerAlgo.h modified in PR(s): Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857
- File Validation/HGCalValidation/interface/BarrelValidator.h modified in PR(s): Bugfixes to TICL-barrel #48565, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857
- File Validation/HGCalValidation/interface/HGCalValidator.h modified in PR(s): Add directories for TICL-EGM code development #48319, Bugfixes to TICL-barrel #48565, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857, Add vector of tracks to TICL tracksters and candidates and add other validation plots #48862
- File Validation/HGCalValidation/interface/HGVHistoProducerAlgo.h modified in PR(s): Add directories for TICL-EGM code development #48319, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857
- File Validation/HGCalValidation/plugins/BarrelValidator.cc modified in PR(s): Bugfixes to TICL-barrel #48565, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857
- File Validation/HGCalValidation/plugins/HGCalValidator.cc modified in PR(s): Bugfixes to TICL-barrel #48565, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857, Add vector of tracks to TICL tracksters and candidates and add other validation plots #48862
- File Validation/HGCalValidation/src/BarrelVHistoProducerAlgo.cc modified in PR(s): Bugfixes to TICL-barrel #48565, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857
- File Validation/HGCalValidation/src/HGVHistoProducerAlgo.cc modified in PR(s): Bugfixes to TICL-barrel #48565, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48995/46174/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48995/46174/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2025-09-25T15:51:33Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48995/46175

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoHGCal/TICL/plugins/SimTrackstersProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319, Add vector of tracks to TICL tracksters and candidates and add other validation plots #48862
- File RecoLocalCalo/HGCalRecProducers/plugins/RecHitMapProducer.cc modified in PR(s): Bugfixes to TICL-barrel #48565, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToCPAssociatorByEnergyScoreImpl.cc modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToCPAssociatorByEnergyScoreProducer.cc modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToCPAssociatorByEnergyScoreProducer.h modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToCPAssociatorEDProducer.cc modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToSCAssociatorByEnergyScoreImpl.cc modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToSCAssociatorByEnergyScoreProducer.cc modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToSCAssociatorByEnergyScoreProducer.h modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToSCAssociatorEDProducer.cc modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimDataFormats/Associations/interface/LayerClusterToSimTracksterAssociatorBaseImpl.h modified in PR(s): Add directories for TICL-EGM code development #48319
- File SimDataFormats/Associations/src/classes_def.xml modified in PR(s): move dictionaries next to typedefs for TrackingParticle associations #37507
- File Validation/HGCalValidation/interface/BarrelVHistoProducerAlgo.h modified in PR(s): Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857
- File Validation/HGCalValidation/interface/BarrelValidator.h modified in PR(s): Bugfixes to TICL-barrel #48565, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857
- File Validation/HGCalValidation/interface/HGCalValidator.h modified in PR(s): Add directories for TICL-EGM code development #48319, Bugfixes to TICL-barrel #48565, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857, Add vector of tracks to TICL tracksters and candidates and add other validation plots #48862
- File Validation/HGCalValidation/interface/HGVHistoProducerAlgo.h modified in PR(s): Add directories for TICL-EGM code development #48319, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857
- File Validation/HGCalValidation/plugins/BarrelValidator.cc modified in PR(s): Bugfixes to TICL-barrel #48565, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857
- File Validation/HGCalValidation/plugins/HGCalValidator.cc modified in PR(s): Bugfixes to TICL-barrel #48565, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857, Add vector of tracks to TICL tracksters and candidates and add other validation plots #48862
- File Validation/HGCalValidation/src/BarrelVHistoProducerAlgo.cc modified in PR(s): Bugfixes to TICL-barrel #48565, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857
- File Validation/HGCalValidation/src/HGVHistoProducerAlgo.cc modified in PR(s): Bugfixes to TICL-barrel #48565, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857

cmsbuild · 2025-09-25T15:52:00Z

A new Pull Request was created by @elenavernazza for master.

It involves the following packages:

RecoHGCal/TICL (reconstruction, upgrade)
RecoLocalCalo/HGCalRecProducers (reconstruction, upgrade)
SimCalorimetry/HGCalAssociatorProducers (simulation, upgrade)
SimDataFormats/Associations (simulation)
Validation/HGCalValidation (dqm)

@Moanwar, @civanch, @cmsbuild, @ctarricone, @gabrielmscampos, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @nothingface0, @rseidita, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@apsallid, @bsunanda, @cseez, @denizsun, @edjtscott, @fabiocos, @felicepantaleo, @forthommel, @hatakeyamak, @lecriste, @lgray, @martinamalberti, @missirol, @mmusich, @pfs, @rovere, @salimcerci, @sameasy, @sethzenz, @sobhatta, @vandreev11, @youyingli this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2025-09-25T15:52:59Z

type ngt

mmusich · 2025-09-25T15:53:29Z

test parameters:

workflow = ph2_hlt

mmusich · 2025-09-25T15:53:35Z

@cmsbuild, please test

cmsbuild · 2025-09-25T17:45:38Z

-1

Failed Tests: RelVals
Size: This PR adds an extra 412KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dcd816/48279/summary.html
COMMIT: 4892348
CMSSW: CMSSW_16_0_X_2025-09-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48995/48279/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

29834.999A fatal system signal has occurred: segmentation violation
2023.0020001DAS Error

cmsbuild · 2025-10-08T18:31:02Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48995/46353

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoHGCal/TICL/plugins/SimTrackstersProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File RecoLocalCalo/HGCalRecProducers/plugins/RecHitMapProducer.cc modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToCPAssociatorByEnergyScoreImpl.cc modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToCPAssociatorByEnergyScoreProducer.cc modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToCPAssociatorByEnergyScoreProducer.h modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToCPAssociatorEDProducer.cc modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToSCAssociatorByEnergyScoreProducer.cc modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToSCAssociatorByEnergyScoreProducer.h modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimCalorimetry/HGCalAssociatorProducers/plugins/LCToSCAssociatorEDProducer.cc modified in PR(s): Bugfixes to TICL-barrel #48565
- File SimDataFormats/Associations/interface/LayerClusterToSimTracksterAssociatorBaseImpl.h modified in PR(s): Add directories for TICL-EGM code development #48319
- File SimDataFormats/Associations/src/classes_def.xml modified in PR(s): move dictionaries next to typedefs for TrackingParticle associations #37507
- File Validation/HGCalValidation/interface/BarrelValidator.h modified in PR(s): Bugfixes to TICL-barrel #48565
- File Validation/HGCalValidation/interface/HGCalValidator.h modified in PR(s): Add directories for TICL-EGM code development #48319, Bugfixes to TICL-barrel #48565
- File Validation/HGCalValidation/interface/HGVHistoProducerAlgo.h modified in PR(s): Add directories for TICL-EGM code development #48319
- File Validation/HGCalValidation/plugins/BarrelValidator.cc modified in PR(s): Bugfixes to TICL-barrel #48565
- File Validation/HGCalValidation/plugins/HGCalValidator.cc modified in PR(s): Bugfixes to TICL-barrel #48565
- File Validation/HGCalValidation/src/BarrelVHistoProducerAlgo.cc modified in PR(s): Bugfixes to TICL-barrel #48565
- File Validation/HGCalValidation/src/HGVHistoProducerAlgo.cc modified in PR(s): Bugfixes to TICL-barrel #48565

cmsbuild · 2025-10-08T18:31:26Z

Pull request #48995 was updated. @Moanwar, @civanch, @cmsbuild, @kpedro88, @mdhildreth, @srimanob, @subirsarkar can you please check and sign again.

mmusich · 2025-10-08T18:31:38Z

some conflicts popped up that need to be resolved.

The conflict was caused by #49054, should be fixed now.

mmusich · 2025-10-08T18:31:45Z

@cmsbuild, please test

cmsbuild · 2025-10-08T20:41:12Z

+1

Size: This PR adds an extra 220KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dcd816/48557/summary.html
COMMIT: 913eebb
CMSSW: CMSSW_16_0_X_2025-10-08-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48995/48557/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dcd816/48557/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dcd816/48557/git-merge-result

Comparison Summary

Summary:

You potentially added 35 lines to the logs
Reco comparison results: 20 differences found in the comparisons
DQMHistoTests: Total files compared: 64
DQMHistoTests: Total histograms compared: 4293814
DQMHistoTests: Total failures: 520
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4293274
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.04099999999999999 KiB( 63 files compared)
DQMHistoSizes: changed ( 139.001,... ): -0.001 KiB HLT/Filters
DQMHistoSizes: changed ( 16834.0,... ): 0.013 KiB HLT/Filters
Checked 263 log files, 223 edm output root files, 64 DQM output files
TriggerResults: found differences in 1 / 62 workflows

mmusich · 2025-10-09T05:08:52Z

@cms-sw/upgrade-l2 @cms-sw/simulation-l2 can you please sign again? The last push was just a rebase.

Moanwar · 2025-10-09T05:13:34Z

+Upgrade

kpedro88 · 2025-10-09T11:16:10Z

+simulation

cmsbuild · 2025-10-09T11:16:38Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-10-09T20:56:52Z

+1

cmsbuild added this to the CMSSW_16_0_X milestone Sep 25, 2025

cmsbuild added reconstruction-pending simulation-pending dqm-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending changes-dataformats labels Sep 25, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels Sep 25, 2025

elenavernazza force-pushed the TemplateLCToSCAssociators branch from 5f4b485 to 4892348 Compare September 25, 2025 15:48

cmsbuild added code-checks-pending and removed code-checks-rejected labels Sep 25, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 25, 2025

cmsbuild added the ngt label Sep 25, 2025

cmsbuild added tests-started and removed tests-pending labels Sep 25, 2025

mmusich mentioned this pull request Sep 25, 2025

Add Validation and DQM to Phase2 HLT WF #39362

Open

cmsbuild removed the tests-started label Sep 25, 2025

cmsbuild added pending-signatures tests-pending upgrade-pending code-checks-pending labels Oct 8, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 8, 2025

cmsbuild added tests-started and removed tests-pending labels Oct 8, 2025

cmsbuild added tests-approved and removed tests-started labels Oct 8, 2025

cmsbuild added upgrade-approved and removed upgrade-pending labels Oct 9, 2025

cmsbuild added simulation-approved fully-signed and removed simulation-pending pending-signatures labels Oct 9, 2025

cmsbuild added orp-approved and removed orp-pending labels Oct 9, 2025

cmsbuild merged commit 8ec7a4b into cms-sw:master Oct 9, 2025
11 checks passed

mmusich deleted the TemplateLCToSCAssociators branch October 9, 2025 21:09

[NGT] Template LayerClusters associators to support both CaloCluster and PFCluster collections #48995

[NGT] Template LayerClusters associators to support both CaloCluster and PFCluster collections #48995

Uh oh!

Conversation

elenavernazza commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Sep 25, 2025

Uh oh!

cmsbuild commented Sep 25, 2025

Uh oh!

cmsbuild commented Sep 25, 2025

Uh oh!

mmusich commented Sep 25, 2025

Uh oh!

mmusich commented Sep 25, 2025

Uh oh!

mmusich commented Sep 25, 2025

Uh oh!

cmsbuild commented Sep 25, 2025

RelVals

Uh oh!

cmsbuild commented Oct 8, 2025

Uh oh!

cmsbuild commented Oct 8, 2025

Uh oh!

mmusich commented Oct 8, 2025

Uh oh!

mmusich commented Oct 8, 2025

Uh oh!

cmsbuild commented Oct 8, 2025

Comparison Summary

Uh oh!

mmusich commented Oct 9, 2025

Uh oh!

Moanwar commented Oct 9, 2025

Uh oh!

kpedro88 commented Oct 9, 2025

Uh oh!

cmsbuild commented Oct 9, 2025

Uh oh!

mandrenguyen commented Oct 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

elenavernazza commented Sep 25, 2025 •

edited

Loading

cmsbuild commented Sep 25, 2025 •

edited

Loading