-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[DAQ] SFB mode detection of run end flag (15_0_X backport) #49101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR contains too many commits (803 >= 240) and will not be processed. |
|
A new Pull Request was created by @smorovic for CMSSW_15_0_X. It involves the following packages:
@cmsbuild, @emeschi, @smorovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
cms-bot internal usage |
|
backport of #49099 |
|
@cmsbuild please test |
|
+1 Size: This PR adds an extra 76KB to repository Comparison SummarySummary:
|
|
+daq |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
Hi @cms-sw/orp-l2, DAQ would like to request another patch release that incorporates this PR. It is needed to be able to run DAQ in the SFB mode which we tentatively plan to do soon after the end of current MD (or as soon as the patch release can be prepared). The patch was only tested and verified in DAQ systems earlier today, so that is the reason for the short notice of the request. |
Sometimes we miss GitHub notifications. It's in general better to send a mail. I've seen the message though, so not necessary. A patch can be available by some point tomorrow. By the end of the European work-day max. |
Great, thank you. |
|
+1 |
|
@smorovic This PR has been included in CMSSW_15_0_15_patch3 for which a replay has just been launched. However, the LHC plans to deliver collisions tonight. Tier-0 asks "With patch2 in production, we can wait to deploy patch3 on Monday without delaying reco right?" |
|
Hi @mandrenguyen For "patch3", tentative plan is to switch HLT tomorrow, after Hilton tests with the possibility of running SFB in production if a new fill happens during the working hours. In addition to this PR, patch3 also includes: DAQ PR does not contain any changes that need deployment to Tier0 and I suspect that also #49081 is unrelated. @mmusich is that correct? |
That's correct.
right, but HLT needs to test it first , before deploying it online (and that will happen only tomorrow or afterwards). |
PR description:
Adding detection of run-end flag set by SFB RU in case of run blocked, out of sync and subsequent end of run which closes files without complete fragment content.
Instead of throwing exception in CMSSW, the process ends run and hltd will take care of closing the lumisection with processed events.
It reused FRD file header V2 used already in L1 Scouting. Data type filed is reused, as L1 Scouting used only values 0-32. Here, value of 0xffff is used for the flag.
PR validation:
Tested with SFB in DAQ3VAL system.
A tect script is also added to the source.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #49099 to 15_0_X
Reason for backport: improvement for SFB DAQ mode which is being tested in online HLT.