Skip to content

Conversation

@smorovic
Copy link
Contributor

@smorovic smorovic commented Oct 8, 2025

PR description:

Adding detection of run-end flag set by SFB RU in case of run blocked, out of sync and subsequent end of run which closes files without complete fragment content.
Instead of throwing exception in CMSSW, the process ends run and hltd will take care of closing the lumisection with processed events.
It reused FRD file header V2 used already in L1 Scouting. Data type filed is reused, as L1 Scouting used only values 0-32. Here, value of 0xffff is used for the flag.

PR validation:

Tested with SFB in DAQ3VAL system.
A tect script is also added to the source.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #49099 to 15_0_X
Reason for backport: improvement for SFB DAQ mode which is being tested in online HLT.

@cmsbuild cmsbuild added this to the CMSSW_16_0_X milestone Oct 8, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2025

This PR contains too many commits (803 >= 240) and will not be processed.
Please ensure you have selected the correct target branch and consider squashing unnecessary commits.
The processing of this PR will resume once the commit count drops below the limit.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2025

A new Pull Request was created by @smorovic for CMSSW_15_0_X.

It involves the following packages:

  • EventFilter/Utilities (daq)

@cmsbuild, @emeschi, @smorovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fwyzard, @missirol this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2025

cms-bot internal usage

@smorovic
Copy link
Contributor Author

smorovic commented Oct 8, 2025

backport of #49099

@smorovic
Copy link
Contributor Author

smorovic commented Oct 8, 2025

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2025

+1

Size: This PR adds an extra 76KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-917e65/48541/summary.html
COMMIT: 6e14daa
CMSSW: CMSSW_15_0_X_2025-10-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49101/48541/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4031982
  • DQMHistoTests: Total failures: 23
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4031939
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@smorovic
Copy link
Contributor Author

smorovic commented Oct 8, 2025

+daq

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2025

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@smorovic
Copy link
Contributor Author

smorovic commented Oct 8, 2025

Hi @cms-sw/orp-l2,
I am not sure if this is the right way to ask (if not, please point me to a proper way to make a release request):

DAQ would like to request another patch release that incorporates this PR. It is needed to be able to run DAQ in the SFB mode which we tentatively plan to do soon after the end of current MD (or as soon as the patch release can be prepared).

The patch was only tested and verified in DAQ systems earlier today, so that is the reason for the short notice of the request.
We will also reiterate the request in the Daily Run Meeting tomorrow to keep RC and other parties aware.

@mandrenguyen
Copy link
Contributor

Hi @cms-sw/orp-l2, I am not sure if this is the right way to ask (if not, please point me to a proper way to make a release request):

DAQ would like to request another patch release that incorporates this PR. It is needed to be able to run DAQ in the SFB mode which we tentatively plan to do soon after the end of current MD (or as soon as the patch release can be prepared).

The patch was only tested and verified in DAQ systems earlier today, so that is the reason for the short notice of the request. We will also reiterate the request in the Daily Run Meeting tomorrow to keep RC and other parties aware.

Sometimes we miss GitHub notifications. It's in general better to send a mail. I've seen the message though, so not necessary. A patch can be available by some point tomorrow. By the end of the European work-day max.

@smorovic
Copy link
Contributor Author

smorovic commented Oct 8, 2025

Hi @cms-sw/orp-l2, I am not sure if this is the right way to ask (if not, please point me to a proper way to make a release request):
DAQ would like to request another patch release that incorporates this PR. It is needed to be able to run DAQ in the SFB mode which we tentatively plan to do soon after the end of current MD (or as soon as the patch release can be prepared).
The patch was only tested and verified in DAQ systems earlier today, so that is the reason for the short notice of the request. We will also reiterate the request in the Daily Run Meeting tomorrow to keep RC and other parties aware.

Sometimes we miss GitHub notifications. It's in general better to send a mail. I've seen the message though, so not necessary. A patch can be available by some point tomorrow. By the end of the European work-day max.

Great, thank you.
I will keep in mind to send a mail next time.

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9ed1310 into cms-sw:CMSSW_15_0_X Oct 9, 2025
8 checks passed
@mandrenguyen
Copy link
Contributor

@smorovic This PR has been included in CMSSW_15_0_15_patch3 for which a replay has just been launched. However, the LHC plans to deliver collisions tonight. Tier-0 asks "With patch2 in production, we can wait to deploy patch3 on Monday without delaying reco right?"

@smorovic
Copy link
Contributor Author

smorovic commented Oct 9, 2025

Hi @mandrenguyen
production HLT is right now running CMSSW_15_0_15_patch1. patch2 installation for HLT was not requested and I didn't see announcements that they plan to run with patch2 tonight. I would guess that patch2 was not relevant for HLT.

For "patch3", tentative plan is to switch HLT tomorrow, after Hilton tests with the possibility of running SFB in production if a new fill happens during the working hours.

In addition to this PR, patch3 also includes:
#49081

DAQ PR does not contain any changes that need deployment to Tier0 and I suspect that also #49081 is unrelated. @mmusich is that correct?
So in that case patch3 does not need to be deployed to Tier0 along with HLT.

@mmusich
Copy link
Contributor

mmusich commented Oct 9, 2025

DAQ PR does not contain any changes that need deployment to Tier0 and I suspect that also #49081 is unrelated. @mmusich is that correct?

That's correct.

So in that case patch3 does not need to be deployed to Tier0 along with HLT.

right, but HLT needs to test it first , before deploying it online (and that will happen only tomorrow or afterwards).
My take is that we stay with patch1 at HLT and Tier0 (or maybe Tier0 moves to patch2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants