Skip to content

Conversation

@akritkbehera
Copy link
Contributor

No description provided.

+#include RooAbsArg.h
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2025

cms-bot internal usage

@akritkbehera akritkbehera changed the title Added #include RooAbsPdf.h and RooAbsArg.h in PhysicsTools/TagAndProbe/src/TagProbeFitter.cc Added RooAbsPdf.h and RooAbsArg.h in PhysicsTools/TagAndProbe/src/TagProbeFitter.cc Oct 6, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2025

A new Pull Request was created by @akritkbehera for master.

It involves the following packages:

  • PhysicsTools/TagAndProbe (analysis)

@cmsbuild, @tvami can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@akritkbehera
Copy link
Contributor Author

akritkbehera commented Oct 6, 2025

please test for CMSSW_16_0_ROOT6_X

@tvami
Copy link
Contributor

tvami commented Oct 6, 2025

@akritkbehera do you have the PR that added this in the master branch? We should denote what this is the backport of

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-590ada/48502/summary.html
COMMIT: b3323ec
CMSSW: CMSSW_16_0_ROOT6_X_2025-10-05-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49074/48502/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@iarspider
Copy link
Contributor

@tvami this is not a backport. This change is required to update root in the ROOT6_X IBs: cms-sw/cmsdist#10110 (comment)

@tvami
Copy link
Contributor

tvami commented Oct 7, 2025

thanks @iarspider but I'm still confused ROOT6_X branch is meant for 10_6_X release cycle?

@iarspider
Copy link
Contributor

@tvami CMSSW_16_0_ROOT6_X uses master branch, if that's what you are asking. And this PR is for master branch.

@tvami
Copy link
Contributor

tvami commented Oct 7, 2025

+1

  • test pass
  • some description in the PR description would be nice, but I guess we discussed it in the body of the PR

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@ftenchini
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants