Added AoSWrapper and transposition function #49072
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
cms-bot internal usage |
Contributor
|
type ngt |
Contributor
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49072/46300
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
Contributor
|
enable gpu |
leobeltra
force-pushed
the
AoS_transpose
branch
from
ec591c1 to
7c43142
Compare
Contributor
Contributor
|
A new Pull Request was created by @leobeltra for master. It involves the following packages:
@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Contributor
|
allow @leobeltra test rights |
Author
|
please test |
makortel
reviewed
Oct 6, 2025
Comment on lines
+1765
to
+2004
| /* AoS as subclass of the SoA. The main purpose should be to perform the heterogeneous tranposition */ \ | ||
| /* from SoA to AoS. This class is a suitable template parameter for the PortableCollections. */ \ | ||
| struct AoSWrapper { \ |
Contributor
There was a problem hiding this comment.
I understand "subclass" the same as "derived class". But here AoSWrapper does not derive from the SoA layout. Is it a nested class then?
Author
There was a problem hiding this comment.
Yes, it is a nested class. I will fix the comment, thank you.
Contributor
|
+1 Size: This PR adds an extra 60KB to repository Comparison SummarySummary:
AMD_MI300X Comparison SummarySummary:
AMD_W7900 Comparison SummarySummary:
NVIDIA_H100 Comparison SummarySummary:
NVIDIA_L40S Comparison SummarySummary:
NVIDIA_T4 Comparison SummarySummary:
|
leobeltra
force-pushed
the
AoS_transpose
branch
from
7494e96 to
3143c21
Compare
Contributor
This was referenced Nov 25, 2025
This was referenced Dec 4, 2025
Contributor
|
Milestone for this pull request has been moved to CMSSW_16_1_X. Please open a backport if it should also go in to CMSSW_16_0_X. |
This was referenced Jan 5, 2026
This was referenced Jan 19, 2026
This was referenced Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR introduces
AoSWrapperas a subclass of the SoA layout. It provides the same utilities as SoA, i.e.,View,ConstView, andMetadata, in a more minimal form, makingAoSWrappera suitable object forPortableCollections to wrap. Thetranspose()function enables heterogeneous conversion between SoA and AoS in both directions and runs via a kernel with a fixed thread count, prioritizing ease of use.PR validation:
Two test cases have been added, one testing the correctness of the new AoS Layout (
AoSUnitTests.cc) and one testing the heterogeneous transposition between AoS/SoA and SoA/AoS (test_catch2_portableAoS.dev.cc).In collaboration with @Electricks94.
FYI: @felicepantaleo