Propagate templates for SoABlocks #49578

Electricks94 · 2025-12-09T11:34:52Z

This PR propagates the templates of the SoABlocks and its View to the sub-layouts and their views. In Particular the template parameter ALIGNMENT_ENFORCEMENT was not propagated to the sub-layouts. Also the SoABlocks only had a View and a ConstView, without templates. This means for the sub-layouts only the default View and ConstView was usably. With this PR the SoABlocks is extended with the ConstViewTemplateFreeParams, ConstViewTemplate, ViewTemplateFreeParams and ViewTemplate.

@felicepantaleo fyi

cmsbuild · 2025-12-09T11:35:15Z

cms-bot internal usage

cmsbuild · 2025-12-09T11:36:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49578/47106

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/SoATemplate/README.md modified in PR(s): Added AoSWrapper and transposition function #49072, Document constexpr limitation for SoA custom methods #49203, [Draft] Allow users to set a valid data range for the SoA View #49204
- File DataFormats/SoATemplate/interface/SoACommon.h modified in PR(s): Various fixes for heterogeneous utilities #47605, Added AoSWrapper and transposition function #49072
- File DataFormats/SoATemplate/interface/SoALayout.h modified in PR(s): Various fixes for heterogeneous utilities #47605, Added AoSWrapper and transposition function #49072, [Draft] Allow users to set a valid data range for the SoA View #49204

cmsbuild · 2025-12-09T11:36:50Z

A new Pull Request was created by @Electricks94 for master.

It involves the following packages:

DataFormats/SoATemplate (heterogeneous)

@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks.
@missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

fwyzard · 2025-12-10T01:38:37Z

DataFormats/SoATemplate/README.md

-
-It is also possible to generate methods inside `View` and `ConstView` using the `SOA_VIEW_METHODS` and 
-`SOA_CONST_VIEW_METHODS` in the same way as described in [Customized methods](#customized-methods).
+`SoABlocks` also supports `View` and `ConstView` classes. In addition to those fully parametrized templates, two others levels of parametrization are provided: `ViewTemplate`, `ViewViewTemplateFreeParams` and respectively `ConstViewTemplate`, `ConstViewTemplateFreeParams`, mirroring the structure of the underlying structs. The blocks are built via composition and access to individual layouts and views is provided by name.


is ViewViewTemplateFreeParams a typo ?

Yes this is a typo. I fixed it

Thanks 👍🏻

fwyzard · 2025-12-10T01:39:40Z

please test

cmsbuild · 2025-12-10T04:04:03Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ee81a/49869/summary.html
COMMIT: c7cd26b
CMSSW: CMSSW_16_0_X_2025-12-09-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49578/49869/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 14 differences found in the comparisons
Reco comparison had 4 failed jobs
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4273241
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4273209
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 198 edm output root files, 53 DQM output files
TriggerResults: no differences found

fwyzard · 2025-12-10T05:09:32Z

Other than maybe fixing a typo in the documentation, the changes look OK.

cmsbuild · 2025-12-10T08:42:21Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49578/47120

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/SoATemplate/README.md modified in PR(s): Added AoSWrapper and transposition function #49072, Document constexpr limitation for SoA custom methods #49203, [Draft] Allow users to set a valid data range for the SoA View #49204
- File DataFormats/SoATemplate/interface/SoACommon.h modified in PR(s): Various fixes for heterogeneous utilities #47605, Added AoSWrapper and transposition function #49072
- File DataFormats/SoATemplate/interface/SoALayout.h modified in PR(s): Various fixes for heterogeneous utilities #47605, Added AoSWrapper and transposition function #49072, [Draft] Allow users to set a valid data range for the SoA View #49204

cmsbuild · 2025-12-10T08:42:42Z

Pull request #49578 was updated. @cmsbuild, @fwyzard, @makortel can you please check and sign again.

fwyzard · 2025-12-10T08:50:51Z

please test

fwyzard · 2025-12-10T08:50:57Z

+heterogeneous

cmsbuild · 2025-12-10T08:51:16Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2025-12-10T15:39:00Z

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ee81a/49875/summary.html
COMMIT: a4047ad
CMSSW: CMSSW_16_0_X_2025-12-09-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49578/49875/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 13 differences found in the comparisons
Reco comparison had 4 failed jobs
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4273241
DQMHistoTests: Total failures: 36
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4273185
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 198 edm output root files, 53 DQM output files
TriggerResults: no differences found

ftenchini · 2025-12-10T15:56:00Z

+1

fwyzard · 2025-12-10T17:14:04Z

type ngt

cmsbuild added this to the CMSSW_16_0_X milestone Dec 9, 2025

cmsbuild added pending-signatures tests-pending orp-pending code-checks-pending heterogeneous-pending labels Dec 9, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 9, 2025

fwyzard reviewed Dec 10, 2025

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Dec 10, 2025

cmsbuild added tests-approved and removed tests-started labels Dec 10, 2025

Propagate templates for SoA Blocks

a4047ad

Electricks94 force-pushed the ViewTemplates branch from c7cd26b to a4047ad Compare December 10, 2025 08:40

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Dec 10, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 10, 2025

cmsbuild added fully-signed tests-started heterogeneous-approved and removed pending-signatures tests-pending heterogeneous-pending labels Dec 10, 2025

cmsbuild added tests-approved and removed tests-started labels Dec 10, 2025

cmsbuild added orp-approved and removed orp-pending labels Dec 10, 2025

cmsbuild merged commit d511db9 into cms-sw:master Dec 10, 2025
10 checks passed

cmsbuild added the ngt label Dec 10, 2025

cmsbuild mentioned this pull request Dec 10, 2025

16.1.X: build root in debug mode cms-sw/cmsdist#10212

Open

Propagate templates for SoABlocks #49578

Propagate templates for SoABlocks #49578

Uh oh!

Conversation

Electricks94 commented Dec 9, 2025

Uh oh!

cmsbuild commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Dec 9, 2025

Uh oh!

cmsbuild commented Dec 9, 2025

Uh oh!

fwyzard Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

Electricks94 Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

fwyzard Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

fwyzard commented Dec 10, 2025

Uh oh!

cmsbuild commented Dec 10, 2025

Comparison Summary

Uh oh!

fwyzard commented Dec 10, 2025

Uh oh!

cmsbuild commented Dec 10, 2025

Uh oh!

cmsbuild commented Dec 10, 2025

Uh oh!

fwyzard commented Dec 10, 2025

Uh oh!

fwyzard commented Dec 10, 2025

Uh oh!

cmsbuild commented Dec 10, 2025

Uh oh!

cmsbuild commented Dec 10, 2025

Comparison Summary

Uh oh!

ftenchini commented Dec 10, 2025

Uh oh!

Uh oh!

fwyzard commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cmsbuild commented Dec 9, 2025 •

edited

Loading