-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Set rntupleStreamerMode attribute for all remaining PortableHost* data products
#49899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49899/47629
|
|
A new Pull Request was created by @makortel for master. It involves the following packages:
@Moanwar, @civanch, @cmsbuild, @fwyzard, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
test parameters:
|
|
@cmsbuild, please test |
|
@makortel I let you sign this for |
|
+1 Size: This PR adds an extra 36KB to repository Comparison SummarySummary:
|
|
Workflow 77.0 succeeded in the RNTuple tests |
|
+heterogeneous |
|
+1 |
|
+simulation |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Workflow 77.0 was failing in RNTuple RelVal tests in a way similar to #49090 .
This PR adds the
rntupleStreamerMode="true"attribute inclasses_def.xmlfor all remainingPortableHostCollectionandPortableHostProductdata products (so that they can be stored in RNTuple files without discovering them one at a time). the documentation inDataFormats/Portableis also updatedResolves cms-sw/framework-team#1799
PR validation:
Workflow 77.0 succeeds with
runTheMatrix.py --use-rntuple.