Skip to content

Conversation

@makortel
Copy link
Contributor

@makortel makortel commented Jan 22, 2026

PR description:

Workflow 77.0 was failing in RNTuple RelVal tests in a way similar to #49090 .

This PR adds the rntupleStreamerMode="true" attribute in classes_def.xml for all remaining PortableHostCollection and PortableHostProduct data products (so that they can be stored in RNTuple files without discovering them one at a time). the documentation in DataFormats/Portable is also updated

Resolves cms-sw/framework-team#1799

PR validation:

Workflow 77.0 succeeds with runTheMatrix.py --use-rntuple.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 22, 2026

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49899/47629

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • DataFormats/BeamSpot (reconstruction)
  • DataFormats/EcalDigi (simulation)
  • DataFormats/EcalRecHit (reconstruction)
  • DataFormats/HGCalReco (reconstruction)
  • DataFormats/HcalDigi (simulation)
  • DataFormats/HcalRecHit (reconstruction)
  • DataFormats/ParticleFlowReco (reconstruction)
  • DataFormats/Portable (heterogeneous)
  • DataFormats/PortableTestObjects (heterogeneous)
  • DataFormats/SiPixelClusterSoA (heterogeneous, reconstruction)
  • DataFormats/SiPixelDigiSoA (heterogeneous, reconstruction)
  • DataFormats/SiStripClusterSoA (heterogeneous, reconstruction)
  • DataFormats/SiStripDigiSoA (heterogeneous, reconstruction)

@Moanwar, @civanch, @cmsbuild, @fwyzard, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @srimanob can you please review it and eventually sign? Thanks.
@ReyerBand, @VinInn, @abdoulline, @alesaggio, @argiro, @bsunanda, @dkotlins, @echabert, @ferencek, @hatakeyamak, @jlidrych, @lgray, @mariadalfonso, @missirol, @mmusich, @mroguljic, @rchatter, @robervalwalsh, @rovere, @thomreis, @threus, @tsusa, @wang0jin this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

test parameters:

  • enable_tests = rntuple
  • workflows_rntuple = 77.0

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@fwyzard
Copy link
Contributor

fwyzard commented Jan 22, 2026

@makortel I let you sign this for heterogeneous :)

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc8255/50816/summary.html
COMMIT: 586e5b8
CMSSW: CMSSW_16_1_X_2026-01-22-1100/el8_amd64_gcc13
Additional Tests: RNTUPLE
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49899/50816/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4258941
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4258915
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
  • Checked 230 log files, 203 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor Author

Workflow 77.0 succeeded in the RNTuple tests

@makortel
Copy link
Contributor Author

+heterogeneous

@Moanwar
Copy link
Contributor

Moanwar commented Jan 22, 2026

+1

@kpedro88
Copy link
Contributor

+simulation

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c8ee274 into cms-sw:master Jan 23, 2026
12 checks passed
@makortel makortel deleted the portableCollectionRNTuple branch January 23, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make more PortableCollections to use rntupleStreamerMode to fix failure in 77.0

6 participants