-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Reconstruction: remove RecoTracker dependency on MTD #49000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49000/46187 |
|
A new Pull Request was created by @fabiocos for master. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
please abort |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49000/46195
|
|
Pull request #49000 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again. |
|
please test |
|
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
In the investigation about the possibility to integrate MTD into the regular CKF, #33272 by @parbol added MTD geometry to the Tracker navigation. This anyway was never followed by further integration, as it turned to be much more complex, and requiring a complete integration of MTD geometry into the Tracker one to make the goal really possible.
The drawback of this first step was the creation of a dependency of RecoTracker, TrackingTools and many other packages through them on the MTD DetIds and geometry, causing any update of them to trigger a recompilation of large part of CMSSW.
This PR removes effectively this unused dependency.
PR validation:
Code compiles and builds, test wf. 26634.0 runs smoothly.