Skip to content

Conversation

@fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Sep 26, 2025

PR description:

In the investigation about the possibility to integrate MTD into the regular CKF, #33272 by @parbol added MTD geometry to the Tracker navigation. This anyway was never followed by further integration, as it turned to be much more complex, and requiring a complete integration of MTD geometry into the Tracker one to make the goal really possible.

The drawback of this first step was the creation of a dependency of RecoTracker, TrackingTools and many other packages through them on the MTD DetIds and geometry, causing any update of them to trigger a recompilation of large part of CMSSW.

This PR removes effectively this unused dependency.

PR validation:

Code compiles and builds, test wf. 26634.0 runs smoothly.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 26, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos for master.

It involves the following packages:

  • RecoTracker/GeometryESProducer (reconstruction)
  • RecoTracker/Record (reconstruction)
  • RecoTracker/TkDetLayers (reconstruction)
  • RecoTracker/TkNavigation (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @elusian, @felicepantaleo, @gpetruc, @mmasciov, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test

@fabiocos
Copy link
Contributor Author

please abort

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49000/46195

@cmsbuild
Copy link
Contributor

Pull request #49000 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again.

@fabiocos
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f5ec4/48301/summary.html
COMMIT: cd14369
CMSSW: CMSSW_16_0_X_2025-09-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49000/48301/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4142809
  • DQMHistoTests: Total failures: 33
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4142756
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 226 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 17320aa into cms-sw:master Sep 30, 2025
10 checks passed
@fabiocos fabiocos deleted the fc-rev33272 branch October 29, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants