Add vector of tracks to TICL tracksters and candidates and add other validation plots #48862

AuroraPerego · 2025-09-08T13:45:18Z

PR description:

This PR introduces the possibility of having multiple tracks within the same TICLCandidate, which allows us to save the entire decay chain of tracks left by a particle and its daughters entering HGCAL (instead of the current situation where we serve only the first one).
This change has already been applied to the simTICLCandidates and simTracksters and considered in the validation, where the track linked to the reconstructed candidate is checked against all the tracks left in the tracker associated with the simulated particle and its daughters.
Later, this will be used in the reconstruction as well, making it "many(-tracks)-to-many(-tracksters)",

In addition, I added a few plots to the TICLCandidate validation:

number of efficient and fake candidates, a useful metric to look at together with the rate to get an idea of the multiplicity
number of simulated charged candidates with no reco track associated (tracker inefficiency), with no good track associated (the associated track(s) did not pass the cuts used in the linking algorithm)
number of simulated candidates with no trackster associated (we did not reconstruct the energy blob in HGCAL)

The TICLDumper has been updated to save the vector of tracks.

PR validation:

run wf of single pion with 0PU and 200PU and looked at the validation plots, available here (0 PU) and here (200PU).
test it with wfs 29688.207, 29888.207, 29634.203, 29834.203

FYI @waredjeb @felicepantaleo

cmsbuild · 2025-09-08T13:45:47Z

cms-bot internal usage

cmsbuild · 2025-09-08T13:48:06Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48862/46025

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/HGCalReco/interface/TICLCandidate.h modified in PR(s): Add directories for TICL-EGM code development #48319
- File DataFormats/HGCalReco/interface/Trackster.h modified in PR(s): Add directories for TICL-EGM code development #48319, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857
- File DataFormats/HGCalReco/src/classes_def.xml modified in PR(s): Add directories for TICL-EGM code development #48319
- File RecoHGCal/TICL/plugins/LinkingAlgoByDirectionGeometric.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File RecoHGCal/TICL/plugins/SimTrackstersProducer.cc modified in PR(s): Further fixes for HGCal validation at HLT #48221, Add directories for TICL-EGM code development #48319
- File RecoHGCal/TICL/plugins/TICLCandidateProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319, TICLv5 Adjust Linking step #48851, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857
- File RecoHGCal/TICL/plugins/TICLDumper.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File RecoHGCal/TICL/plugins/TrackstersMergeProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File Validation/HGCalValidation/interface/HGCalValidator.h modified in PR(s): Add directories for TICL-EGM code development #48319, Bugfixes to TICL-barrel #48565, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857
- File Validation/HGCalValidation/interface/TICLCandidateValidator.h modified in PR(s): Add directories for TICL-EGM code development #48319
- File Validation/HGCalValidation/plugins/HGCalValidator.cc modified in PR(s): Further fixes for HGCal validation at HLT #48221, Bugfixes to TICL-barrel #48565, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857
- File Validation/HGCalValidation/python/PostProcessorHGCAL_cfi.py modified in PR(s): Bugfixes to TICL-barrel #48565
- File Validation/HGCalValidation/python/hgcalPlots.py modified in PR(s): Bugfixes to TICL-barrel #48565
- File Validation/HGCalValidation/src/TICLCandidateValidator.cc modified in PR(s): Add directories for TICL-EGM code development #48319

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48862/46025/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48862/46025/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

- change the dataformats to allow this - change the simulation to link multiple tracks - change the validation to consider all the tracks

Moanwar · 2025-09-08T14:04:27Z

@cmsbuild please test

cmsbuild · 2025-09-08T14:05:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48862/46026

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/HGCalReco/interface/TICLCandidate.h modified in PR(s): Add directories for TICL-EGM code development #48319
- File DataFormats/HGCalReco/interface/Trackster.h modified in PR(s): Add directories for TICL-EGM code development #48319, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857
- File DataFormats/HGCalReco/src/classes_def.xml modified in PR(s): Add directories for TICL-EGM code development #48319
- File RecoHGCal/TICL/plugins/LinkingAlgoByDirectionGeometric.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File RecoHGCal/TICL/plugins/SimTrackstersProducer.cc modified in PR(s): Further fixes for HGCal validation at HLT #48221, Add directories for TICL-EGM code development #48319
- File RecoHGCal/TICL/plugins/TICLCandidateProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319, TICLv5 Adjust Linking step #48851, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857
- File RecoHGCal/TICL/plugins/TICLDumper.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File RecoHGCal/TICL/plugins/TrackstersMergeProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File Validation/HGCalValidation/interface/HGCalValidator.h modified in PR(s): Add directories for TICL-EGM code development #48319, Bugfixes to TICL-barrel #48565, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857
- File Validation/HGCalValidation/interface/TICLCandidateValidator.h modified in PR(s): Add directories for TICL-EGM code development #48319
- File Validation/HGCalValidation/plugins/HGCalValidator.cc modified in PR(s): Further fixes for HGCal validation at HLT #48221, Bugfixes to TICL-barrel #48565, Move MultiVectorManager to DataFormats/Common and address discussion from #48826 and rename it to MultiSpan #48857
- File Validation/HGCalValidation/python/PostProcessorHGCAL_cfi.py modified in PR(s): Bugfixes to TICL-barrel #48565
- File Validation/HGCalValidation/python/hgcalPlots.py modified in PR(s): Bugfixes to TICL-barrel #48565
- File Validation/HGCalValidation/src/TICLCandidateValidator.cc modified in PR(s): Add directories for TICL-EGM code development #48319

cmsbuild · 2025-09-08T14:05:48Z

A new Pull Request was created by @AuroraPerego for master.

It involves the following packages:

DataFormats/HGCalReco (reconstruction, upgrade)
RecoHGCal/TICL (reconstruction, upgrade)
Validation/HGCalValidation (dqm)

@Moanwar, @antoniovagnerini, @ctarricone, @jfernan2, @mandrenguyen, @rseidita, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@apsallid, @bsunanda, @cseez, @denizsun, @felicepantaleo, @forthommel, @hatakeyamak, @lecriste, @lgray, @missirol, @mmusich, @pfs, @rovere, @salimcerci, @sameasy, @sethzenz, @sobhatta, @vandreev11, @youyingli this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

gabrielmscampos · 2025-09-30T08:42:15Z

@AuroraPerego could you resolve the conflicts before proceeding?

From the DQM side, the code looks fine. Failures in the tests are either spurious or caused by DAS errors.

Moanwar · 2025-09-30T08:48:14Z

@cmsbuild please test

cmsbuild · 2025-09-30T08:49:40Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48862/46236

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/HGCalReco/interface/TICLCandidate.h modified in PR(s): Add directories for TICL-EGM code development #48319
- File DataFormats/HGCalReco/interface/Trackster.h modified in PR(s): Add directories for TICL-EGM code development #48319
- File DataFormats/HGCalReco/src/classes_def.xml modified in PR(s): Add directories for TICL-EGM code development #48319
- File RecoHGCal/TICL/plugins/LinkingAlgoByDirectionGeometric.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File RecoHGCal/TICL/plugins/SimTrackstersProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319, [NGT] Template LayerClusters associators to support both CaloCluster and PFCluster collections #48995
- File RecoHGCal/TICL/plugins/TICLCandidateProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File RecoHGCal/TICL/plugins/TICLDumper.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File RecoHGCal/TICL/plugins/TrackstersMergeProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File Validation/HGCalValidation/interface/HGCalValidator.h modified in PR(s): Add directories for TICL-EGM code development #48319, Bugfixes to TICL-barrel #48565, [NGT] Template LayerClusters associators to support both CaloCluster and PFCluster collections #48995
- File Validation/HGCalValidation/interface/TICLCandidateValidator.h modified in PR(s): Add directories for TICL-EGM code development #48319
- File Validation/HGCalValidation/plugins/HGCalValidator.cc modified in PR(s): Bugfixes to TICL-barrel #48565, [NGT] Template LayerClusters associators to support both CaloCluster and PFCluster collections #48995
- File Validation/HGCalValidation/python/PostProcessorHGCAL_cfi.py modified in PR(s): Bugfixes to TICL-barrel #48565
- File Validation/HGCalValidation/python/hgcalPlots.py modified in PR(s): Bugfixes to TICL-barrel #48565
- File Validation/HGCalValidation/src/TICLCandidateValidator.cc modified in PR(s): Add directories for TICL-EGM code development #48319

cmsbuild · 2025-09-30T08:50:02Z

Pull request #48862 was updated. @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please check and sign again.

cmsbuild · 2025-09-30T12:50:02Z

+1

Size: This PR adds an extra 44KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe5a0b/48365/summary.html
COMMIT: 7cd5fc0
CMSSW: CMSSW_16_0_X_2025-09-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48862/48365/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe5a0b/48365/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe5a0b/48365/git-merge-result

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 16 differences found in the comparisons
DQMHistoTests: Total files compared: 55
DQMHistoTests: Total histograms compared: 4470252
DQMHistoTests: Total failures: 328
DQMHistoTests: Total nulls: 1117
DQMHistoTests: Total successes: 4468787
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 419.9150000000001 KiB( 54 files compared)
DQMHistoSizes: changed ( 29634.0,... ): 22.367 KiB HLT/HGCAL
DQMHistoSizes: changed ( 29634.0,... ): 21.805 KiB HGCAL/HGCalValidator
Checked 236 log files, 204 edm output root files, 55 DQM output files
TriggerResults: no differences found

gabrielmscampos · 2025-09-30T13:05:12Z

+dqm

cmsbuild · 2025-09-30T13:05:40Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-09-30T18:10:30Z

+1

cmsbuild added this to the CMSSW_15_1_X milestone Sep 8, 2025

cmsbuild added reconstruction-pending dqm-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending changes-dataformats labels Sep 8, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels Sep 8, 2025

AuroraPerego added 7 commits September 8, 2025 15:55

add cuts on tracks not used for the linking

d20d4c2

ignore charged sim candidates with no reco track

92cfa02

use vector of tracks in TICL tracksters and candidates

7257ba1

- change the dataformats to allow this - change the simulation to link multiple tracks - change the validation to consider all the tracks

small change in mtd time computation

9113856

add multiplicity plots and fix ranges

617fdcd

add plot to monitor candidate with no track / tracskter

ab28ccf

save vector of tracks in TICLDumper

862c400

AuroraPerego force-pushed the trackCandValidation_15_1_0_pre5 branch from dde6849 to 862c400 Compare September 8, 2025 14:02

cmsbuild added code-checks-pending and removed code-checks-rejected labels Sep 8, 2025

cmsbuild added tests-started and removed tests-pending labels Sep 8, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 8, 2025

cmsbuild added tests-approved and removed tests-started labels Sep 26, 2025

This was referenced Sep 26, 2025

Updated SoA View accessors from raw pointers to span #48377

Merged

Bugfixes to TICL-barrel #48565

Merged

Merge branch 'master' into trackCandValidation_15_1_0_pre5

7cd5fc0

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Sep 30, 2025

cmsbuild added tests-started and removed tests-pending labels Sep 30, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 30, 2025

cmsbuild added tests-approved and removed tests-started labels Sep 30, 2025

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Sep 30, 2025

cmsbuild added orp-approved and removed orp-pending labels Sep 30, 2025

cmsbuild merged commit c0df755 into cms-sw:master Sep 30, 2025
11 checks passed

Add vector of tracks to TICL tracksters and candidates and add other validation plots #48862

Add vector of tracks to TICL tracksters and candidates and add other validation plots #48862

Uh oh!

Conversation

AuroraPerego commented Sep 8, 2025

PR description:

PR validation:

Uh oh!

cmsbuild commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Sep 8, 2025

Uh oh!

Moanwar commented Sep 8, 2025

Uh oh!

cmsbuild commented Sep 8, 2025

Uh oh!

cmsbuild commented Sep 8, 2025

Uh oh!

gabrielmscampos commented Sep 30, 2025

Uh oh!

Moanwar commented Sep 30, 2025

Uh oh!

cmsbuild commented Sep 30, 2025

Uh oh!

cmsbuild commented Sep 30, 2025

Uh oh!

cmsbuild commented Sep 30, 2025

Comparison Summary

Uh oh!

gabrielmscampos commented Sep 30, 2025

Uh oh!

cmsbuild commented Sep 30, 2025

Uh oh!

mandrenguyen commented Sep 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

cmsbuild commented Sep 8, 2025 •

edited

Loading