Root llvm20 #227
Closed
Root llvm20 #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When unloading a ClassTemplateDecl, no redeclarations were handled Additional redecls may still be part of the chain leading to duplicates and broken redecl chains that cause assertion failures like: "Passed first decl twice, invalid redecl chain!" Fixes assertion failures post llvm commit: llvm/llvm-project@17d8ed7 for the test `roottest-root-meta-cmsUnload-make`
On MacOS, sh re-executes as another shell. This tripped the logic in thisroot that's trying to find out which shell is running. Fixes root-project#19965 Co-authored-by: Stephan Hageboeck <[email protected]>
Nothing should access libCling directly, and tests in core/base/ don't seem to use dl* functions directly anymore, so libdl isn't needed either.
... as it was already done on Windows: It uses some symbols and this allows to remove some bad linker options.
They should not be propagated to targets that link against libCling (which also nobody should do).
ld: warning: -bind_at_load is deprecated on macOS From $ man ld: Sets a bit in the mach header of the resulting binary which tells dyld to bind all symbols when the binary is loaded, rather than lazily. This contradicts the flags RTLD_LAZY|RTLD_LOCAL passed to dlopen when loading libCling, and is different from the behavior on other platforms that don't have this flag, such as Linux. Also remove the warning suppression that was hiding this deprecation message. It was added as part of commit 5ad4ab9 ("[cmake] Silence macOS linker warnings on -undefined dynamic_lookup:"), which we don't use anymore for libCling since the previous commit.
change visibility from public to private in RRVecField for members that should have been private all along.
Author
|
test parameters:
|
Author
|
please test for CMSSW_16_0_ROOT6_X |
5 tasks
|
A new Pull Request was created by @smuzaffar for branch cms/master/6a799db8c0. @akritkbehera, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
As ROOT requires C++17 for a long time now, cppyy also requires it and we can remove the checks for C++17 or lower standards from the code.
This mimics what is done in the newer C++ standards for multiple standard library classes, and also tells cppyy how to implement `__contains__` in the Python proxy.
This is to make all overloads for looking up elements available via the `contains()` pythonization.
The newer C++ standards already implement a `contains()` method for multiple STL classes. We can just forward to these in the `__contains__` method for the Python proxy. Forwarding to `contains()` on the C++ side means also that it will become easier to implement classes that Pythonize nicely automatically. Just as happened already before with `size()` (that got used to automatically implement `__len__`), one just needs to implement `contains()` on the C++ side now to implicitly get the `__contains__` pythonization.
|
-1 Failed Tests: Build The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: BuildI found compilation error when building: >> Compiling src/DataFormats/PortableTestObjects/src/classes.cc /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DCMSSW_GIT_HASH='CMSSW_16_0_ROOT6_X_2025-09-29-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_16_0_ROOT6_X_2025-09-29-2300' -Isrc -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/alpaka/1.3.0-1bebf2b0d3930143ff8d2eb61285273b/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/pcre/8.43-2d141998cfe5424b8f7aff48035cc2da/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/boost/1.80.0-9fb12b48c6a745f4b2f453dacee53cef/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.37.1-fb496933e354507d7791184b34636be4/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tbb/v2022.0.0-0fa9c7b61a60a427cb7121233c828101/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/zlib/1.2.13-d217cdbdd8d586e845e05946de2796be/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-5d91c922e771c0dc4f6bc00f61f3e2c5/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-5d91c922e771c0dc4f6bc00f61f3e2c5/include/eigen3 -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-e35fd1db5eb3abc8ac0452e8ee427196/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tinyxml2/6.2.0-a0ad3950415fa3138d99b7da42eb4c9f/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/DataFormats/PortableTestObjects/src/DataFormatsPortableTestObjects/classes.cc.d src/DataFormats/PortableTestObjects/src/classes.cc -o tmp/el8_amd64_gcc12/src/DataFormats/PortableTestObjects/src/DataFormatsPortableTestObjects/classes.cc.o >> Building LCG reflex dict from header file src/DataFormats/PortableTestObjects/src/classes.h /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.37.1-fb496933e354507d7791184b34636be4/bin/rootcling -reflex -f tmp/el8_amd64_gcc12/src/DataFormats/PortableTestObjects/src/DataFormatsPortableTestObjects/lcgdict/DataFormatsPortableTestObjects_xr.cc -inlineInputHeader -failOnWarnings -rmf tmp/el8_amd64_gcc12/src/DataFormats/PortableTestObjects/src/DataFormatsPortableTestObjects/lcgdict/DataFormatsPortableTestObjects_xr.rootmap -rml libDataFormatsPortableTestObjects.so -m DataFormatsCommon_xr_rdict.pcm -m DataFormatsProvenance_xr_rdict.pcm -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DCMS_DICT_IMPL -D_REENTRANT -DGNUSOURCE -D__STRICT_ANSI__ -DCMS_MICRO_ARCH="x86-64-v3" -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DCMSSW_GIT_HASH="CMSSW_16_0_ROOT6_X_2025-09-29-2300" -DPROJECT_NAME="CMSSW" -DPROJECT_VERSION="CMSSW_16_0_ROOT6_X_2025-09-29-2300" -Isrc -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/alpaka/1.3.0-1bebf2b0d3930143ff8d2eb61285273b/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/pcre/8.43-2d141998cfe5424b8f7aff48035cc2da/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/boost/1.80.0-9fb12b48c6a745f4b2f453dacee53cef/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.37.1-fb496933e354507d7791184b34636be4/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tbb/v2022.0.0-0fa9c7b61a60a427cb7121233c828101/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/zlib/1.2.13-d217cdbdd8d586e845e05946de2796be/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-5d91c922e771c0dc4f6bc00f61f3e2c5/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-5d91c922e771c0dc4f6bc00f61f3e2c5/include/eigen3 -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-e35fd1db5eb3abc8ac0452e8ee427196/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tinyxml2/6.2.0-a0ad3950415fa3138d99b7da42eb4c9f/include -DCMSSW_REFLEX_DICT src/DataFormats/PortableTestObjects/src/classes.h src/DataFormats/PortableTestObjects/src/classes_def.xml FATAL: A class with normalized name edm::Wrapper,portabletest::TestSoALayout2<128,false> > > was already selected. This means that two different instances of clang::RecordDecl had the same name, which is not possible. This can be a hint of a serious problem in the class selection. In addition, the generated dictionary would not even compile. gmake: *** [tmp/el8_amd64_gcc12/src/DataFormats/PortableTestObjects/src/DataFormatsPortableTestObjects/lcgdict/DataFormatsPortableTestObjects_xr.cc] Error 1 >> Compiling LCG dictionary: tmp/el8_amd64_gcc12/src/DataFormats/PortableTestObjects/src/DataFormatsPortableTestObjects/lcgdict/DataFormatsPortableTestObjects_xr.cc /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -MMD -MF tmp/el8_amd64_gcc12/src/DataFormats/PortableTestObjects/src/DataFormatsPortableTestObjects/lcgdict/DataFormatsPortableTestObjects_xr.cc.d -I. -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DCMSSW_GIT_HASH='CMSSW_16_0_ROOT6_X_2025-09-29-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_16_0_ROOT6_X_2025-09-29-2300' -Isrc -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/alpaka/1.3.0-1bebf2b0d3930143ff8d2eb61285273b/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/pcre/8.43-2d141998cfe5424b8f7aff48035cc2da/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/boost/1.80.0-9fb12b48c6a745f4b2f453dacee53cef/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/lcg/root/6.37.1-fb496933e354507d7791184b34636be4/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tbb/v2022.0.0-0fa9c7b61a60a427cb7121233c828101/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/zlib/1.2.13-d217cdbdd8d586e845e05946de2796be/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-5d91c922e771c0dc4f6bc00f61f3e2c5/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-5d91c922e771c0dc4f6bc00f61f3e2c5/include/eigen3 -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/fmt/10.2.1-e35fd1db5eb3abc8ac0452e8ee427196/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/tinyxml2/6.2.0-a0ad3950415fa3138d99b7da42eb4c9f/include -DCMSSW_REFLEX_DICT -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DBOOST_DISABLE_ASSERTS -Os -Wno-unused-variable -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC tmp/el8_amd64_gcc12/src/DataFormats/PortableTestObjects/src/DataFormatsPortableTestObjects/lcgdict/DataFormatsPortableTestObjects_xr.cc -o tmp/el8_amd64_gcc12/src/DataFormats/PortableTestObjects/src/DataFormatsPortableTestObjects/lcgdict/DataFormatsPortableTestObjects_xr.cc.o cc1plus: fatal error: tmp/el8_amd64_gcc12/src/DataFormats/PortableTestObjects/src/DataFormatsPortableTestObjects/lcgdict/DataFormatsPortableTestObjects_xr.cc: No such file or directory compilation terminated. gmake: *** [tmp/el8_amd64_gcc12/src/DataFormats/PortableTestObjects/src/DataFormatsPortableTestObjects/lcgdict/DataFormatsPortableTestObjects_xr.cc.o] Error 1 |
This fixes a missing link in the RooFit tutorials page: https://root.cern/doc/master/group__tutorial__roofit__main.html
Add an upstream commit that was missed in the previous tag
After inlining and hiding symbols, some of them are not referenced anymore and can be collected by the linker, reducing the library size from 120 MB to 105 MB in a Release configuration with GCC.
This is optional during installation, but we always want it because of the large gains, reducing the size of the library further from 105 MB to 88 MB.
TemplateArgument can return a QualType that may contain unqualified parts. Before (incorrect): __gnu_cxx::__common_pool_policy<__pool, true> After (correct): __gnu_cxx::__common_pool_policy<__gnu_cxx::__pool, true>
LLVM 20 produce `RecoveryExpr` for dependent errors where LLVM 18 returned `ExprError`. In our type/name lookup path, this can leave a <recovery-expr> node and later codeGen asks the AST to constant-evaluate that initializer and we hit this assertion: `VarDecl::evaluateValueImpl: !Init->isValueDependent()`.
Avoid cases like: avoid `class__attribute__` with LLVM20 Fixes the failure on alma9: `gtest-tree-dataframe-dataframe-snapshot-emptyoutput`
Skip dumping TopLevelStmt if they are invalid. The change llvm/llvm-project@4b70d17bcf caused an invalid `TopLevelStatement` to be added to the AST, which can trigger assertions when dumping.
Also temporarily failing disable `testHashRecursiveRemove` test on Windows
template_arguments() has the types, but getTemplateArgs() has the pack argument, so their counts may be different. Add test for failing CMS build with LLVM 20. Co-authored-by: Devajith Valaparambil Sreeramaswamy <[email protected]>
|
Pull request #227 was updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.