Skip to content

Conversation

@Dr15Jones
Copy link
Contributor

@Dr15Jones Dr15Jones commented Sep 25, 2025

PR description:

This checks a fix made in an early pull request.

PR validation:

I put a temporary printout in EventProcessor::readFile to show the condition was met.

resolves cms-sw/framework-team#1572

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 25, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • IOPool/Tests (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc14d4/48282/summary.html
COMMIT: 9192bae
CMSSW: CMSSW_16_0_X_2025-09-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48996/48282/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc14d4/48282/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc14d4/48282/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 86 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3911484
  • DQMHistoTests: Total failures: 136099
  • DQMHistoTests: Total nulls: 12
  • DQMHistoTests: Total successes: 3775353
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.098 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 2024.0010001 ): -0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2024.0040001 ): -0.090 KiB JetMET/SUSYDQM
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 1 / 49 workflows

process = cms.Process("TEST")

process.maxEvents.input = 3
# Source using imported EmptySource
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment doesn't seem very informative

Suggested change
# Source using imported EmptySource

This checks a fix made in an early pull request.
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #48996 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc14d4/48350/summary.html
COMMIT: 47c4f87
CMSSW: CMSSW_16_0_X_2025-09-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48996/48350/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3922620
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3922590
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

Comparison differences are related to #47071

@makortel
Copy link
Contributor

+core

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b6dfeeb into cms-sw:master Sep 30, 2025
10 checks passed
@Dr15Jones Dr15Jones deleted the differentProductRegistries branch October 6, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a unit test mimicking the assertion failure condition

4 participants