-
Notifications
You must be signed in to change notification settings - Fork 4.6k
add support for multiple input FEDs in HLTL1NumberFilter
#48957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for multiple input FEDs in HLTL1NumberFilter
#48957
Conversation
|
cms-bot internal usage |
fe3bcb1 to
7c71d62
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48957/46124
|
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
|
|
FWIW, I checked with the following command: hltGetConfiguration /dev/CMSSW_15_0_0/GRun \
--globaltag 150X_dataRun3_HLT_v1 \
--data \
--unprescale \
--output minimal \
--max-events 100 \
--eras Run3_2025 --l1-emulator uGT --l1 L1Menu_Collisions2025_v1_3_0_xml \
--input /store/data/Run2025D/EphemeralHLTPhysics0/RAW/v1/000/394/959/00000/02ab3d20-66ba-4372-8f06-5d09e0848408.root \
> hltData.py
cmsRun hltData.py >& hltData.login plain release |
|
type hlt-integration |
|
+hlt |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Disabling customisation for cms-sw#48957
Disabling customisation for cms-sw#48957
Disabling customisation for cms-sw#48957
Disabling customisation for cms-sw#48957
Disabling customisation for cms-sw#48957
Disabling customisation for cms-sw#48957
Disabling customisation for cms-sw#48957
Disabling customisation for cms-sw#48957
PR description:
Title says it all: the DAQ group is preparing the global system for running with the secondary TCDS system, where FED 1050 would be present as TCDS FED instead of 1024, see more details at CMSHLT-3643.
Considering HLT, they went through the modules consuming FED 1024 and they found that the module
HLTL1NumberFilterdoes not support multiple FED input values, thus it can work with both FED IDs in global HLT.The goal of this PR is to support multiple TCDS FEDs in input.
PR validation:
TSG integration tests:
addOnTests.pyworks.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, it will be backported to (at least) CMSSW_15_1_X for online tests.
Cc: @smorovic