Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 19, 2025

PR description:

Title says it all: the DAQ group is preparing the global system for running with the secondary TCDS system, where FED 1050 would be present as TCDS FED instead of 1024, see more details at CMSHLT-3643.
Considering HLT, they went through the modules consuming FED 1024 and they found that the module HLTL1NumberFilter does not support multiple FED input values, thus it can work with both FED IDs in global HLT.
The goal of this PR is to support multiple TCDS FEDs in input.

PR validation:

TSG integration tests: addOnTests.py works.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, it will be backported to (at least) CMSSW_15_1_X for online tests.

Cc: @smorovic

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 19, 2025

cms-bot internal usage

@mmusich mmusich force-pushed the dev_support_secondaryTCDS branch from fe3bcb1 to 7c71d62 Compare September 19, 2025 10:22
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48957/46124

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)
  • HLTrigger/special (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Sep 19, 2025

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-414a79/48226/summary.html
COMMIT: 7c71d62
CMSSW: CMSSW_16_0_X_2025-09-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48957/48226/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3978581
  • DQMHistoTests: Total failures: 26
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3978535
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 210 log files, 180 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Sep 19, 2025

FWIW, I checked with the following command:

hltGetConfiguration /dev/CMSSW_15_0_0/GRun \
   --globaltag 150X_dataRun3_HLT_v1 \
   --data \
   --unprescale \
   --output minimal \
   --max-events 100 \
   --eras Run3_2025 --l1-emulator uGT --l1 L1Menu_Collisions2025_v1_3_0_xml \
   --input /store/data/Run2025D/EphemeralHLTPhysics0/RAW/v1/000/394/959/00000/02ab3d20-66ba-4372-8f06-5d09e0848408.root \
   > hltData.py

cmsRun hltData.py >& hltData.log

in plain release CMSSW_16_0_X_2025-09-18-2300 and with this PR and I get the same counts for the modules in question:

TrigReport       1285       1285         12       1273          0 hltL1EventNumberL1Fat
TrigReport       2570       1285          0       1285          0 hltL1EventNumberNZS

@mmusich
Copy link
Contributor Author

mmusich commented Sep 22, 2025

type hlt-integration

@mmusich
Copy link
Contributor Author

mmusich commented Sep 22, 2025

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@ftenchini
Copy link

+1

@cmsbuild cmsbuild merged commit 51437cd into cms-sw:master Sep 22, 2025
10 checks passed
@mmusich mmusich deleted the dev_support_secondaryTCDS branch September 22, 2025 08:27
mmusich pushed a commit to cms-tsg-storm/cmssw that referenced this pull request Oct 7, 2025
mmusich pushed a commit to cms-tsg-storm/cmssw that referenced this pull request Oct 7, 2025
mmusich pushed a commit to cms-tsg-storm/cmssw that referenced this pull request Oct 7, 2025
bfonta pushed a commit to bfonta/cmssw that referenced this pull request Oct 9, 2025
Electricks94 pushed a commit to Electricks94/cmssw that referenced this pull request Oct 20, 2025
Electricks94 pushed a commit to Electricks94/cmssw that referenced this pull request Oct 21, 2025
michael-pitt pushed a commit to michael-pitt/cmssw that referenced this pull request Nov 15, 2025
ghyls pushed a commit to ghyls/cmssw that referenced this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants