[ROOT636] Root update v6 36 00 patches 20250922 #10087

akritkbehera · 2025-09-22T04:40:25Z

No description provided.

cmsbuild · 2025-09-22T04:40:49Z

A new Pull Request was created by @akritkbehera for branch IB/CMSSW_16_0_X/root636.

@akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2025-09-22T04:40:49Z

cms-bot internal usage

akritkbehera · 2025-09-22T04:41:06Z

Please test

cmsbuild · 2025-09-22T09:01:26Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fdf427/48230/summary.html
COMMIT: dcec6c7
CMSSW: CMSSW_16_0_ROOT636_X_2025-09-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10087/48230/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test testFWCoreFWLite had ERRORS

Comparison Summary

Summary:

You potentially added 205 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3139217
DQMHistoTests: Total failures: 339
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3138858
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 170 log files, 140 edm output root files, 39 DQM output files
TriggerResults: found differences in 1 / 37 workflows

akritkbehera · 2025-09-22T13:10:04Z

test parameters:

full_cmssw = true

akritkbehera · 2025-09-22T13:10:46Z

Please test

iarspider · 2025-09-22T13:58:46Z

---> test testFWCoreFWLite had ERRORS

The crash happens on line 231:

https://github.com/cms-sw/cmssw/blob/51437cded9d8764898fc426c9bc65d64d5bd769b/FWCore/FWLite/test/ref_t.cppunit.cpp#L231

cmsbuild · 2025-09-22T16:26:52Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fdf427/48237/summary.html
COMMIT: dcec6c7
CMSSW: CMSSW_16_0_ROOT636_X_2025-09-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10087/48237/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fdf427/48237/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fdf427/48237/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test testFWCoreFWLite had ERRORS

Comparison Summary

Summary:

You potentially added 63 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3139217
DQMHistoTests: Total failures: 285
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3138912
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 170 log files, 140 edm output root files, 39 DQM output files
TriggerResults: no differences found

iarspider · 2025-09-22T16:31:20Z

assign core

cmsbuild · 2025-09-22T16:31:43Z

New categories assigned: core

@Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

makortel · 2025-09-22T17:45:25Z

Looking at the diff cms-sw/root@cms/v6-36-00-patches/55016315be...cms/v6-36-00-patches/fc959539ca root-project/root#19915 / root-project/root#19873 looks like possibly related. Although then I'd wonder why the ROOT master update #10086 didn't show similar failure.

FYI @pcanal

makortel · 2025-09-22T18:54:42Z

@cmsbuild, please test

Let's see if the failure reproduces

cmsbuild · 2025-09-22T22:10:41Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fdf427/48243/summary.html
COMMIT: dcec6c7
CMSSW: CMSSW_16_0_ROOT636_X_2025-09-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10087/48243/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fdf427/48243/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fdf427/48243/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test testFWCoreFWLite had ERRORS

Comparison Summary

Summary:

You potentially added 62 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3139217
DQMHistoTests: Total failures: 301
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3138896
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 170 log files, 140 edm output root files, 39 DQM output files
TriggerResults: no differences found

pcanal · 2025-09-22T22:26:30Z

@makortel What is the actual error/failure? @vepadulano Do you see a link to the TChain PRs?

iarspider · 2025-09-23T07:04:06Z

@pcanal segmentation violation caused by TChain::SetBranchAddress() not updating pointer to TBranch (3rd argument), see https://github.com/cms-sw/cmssw/blob/51437cded9d8764898fc426c9bc65d64d5bd769b/FWCore/FWLite/test/ref_t.cppunit.cpp#L216-L231

  TChain eventChain(edm::poolNames::eventTreeName().c_str());
  eventChain.Add("good.root");
  eventChain.Add("good_delta5.root");


  edm::Wrapper<edmtest::OtherThingCollection>* pOthers = nullptr;
  TBranch* othersBranch = nullptr;
  eventChain.SetBranchAddress("edmtestOtherThings_OtherThing_testUserTag_TEST.", &pOthers, &othersBranch);


  edm::Wrapper<edmtest::ThingCollection>* pThings = nullptr;
  TBranch* thingsBranch = nullptr;
  eventChain.SetBranchAddress("edmtestThings_Thing__TEST.", &pThings, &thingsBranch);


  int nev = eventChain.GetEntries();
  for (int ev = 0; ev < nev; ++ev) {
    std::cout << "event #" << ev << std::endl;
    othersBranch->SetAddress(&pOthers); // othersBranch is nullptr here

Updated root to tip of branch v6-36-00-patches

dcec6c7

cmsbuild added tests-pending externals-pending pending-signatures orp-pending labels Sep 22, 2025

cmsbuild added tests-started and removed tests-pending labels Sep 22, 2025

cmsbuild added tests-rejected and removed tests-started labels Sep 22, 2025

cmsbuild added tests-started and removed tests-rejected labels Sep 22, 2025

cmsbuild added tests-rejected and removed tests-started labels Sep 22, 2025

cmsbuild added the core-pending label Sep 22, 2025

cmsbuild added tests-started and removed tests-rejected labels Sep 22, 2025

cmsbuild removed the tests-started label Sep 22, 2025

cmsbuild added the tests-rejected label Sep 22, 2025

akritkbehera closed this Oct 5, 2025

[ROOT636] Root update v6 36 00 patches 20250922 #10087

[ROOT636] Root update v6 36 00 patches 20250922 #10087

Uh oh!

Conversation

akritkbehera commented Sep 22, 2025

Uh oh!

cmsbuild commented Sep 22, 2025

Uh oh!

cmsbuild commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akritkbehera commented Sep 22, 2025

Uh oh!

cmsbuild commented Sep 22, 2025

Unit Tests

Comparison Summary

Uh oh!

akritkbehera commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akritkbehera commented Sep 22, 2025

Uh oh!

iarspider commented Sep 22, 2025

Uh oh!

cmsbuild commented Sep 22, 2025

Unit Tests

Comparison Summary

Uh oh!

iarspider commented Sep 22, 2025

Uh oh!

cmsbuild commented Sep 22, 2025

Uh oh!

makortel commented Sep 22, 2025

Uh oh!

makortel commented Sep 22, 2025

Uh oh!

cmsbuild commented Sep 22, 2025

Unit Tests

Comparison Summary

Uh oh!

pcanal commented Sep 22, 2025

Uh oh!

iarspider commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cmsbuild commented Sep 22, 2025 •

edited

Loading

akritkbehera commented Sep 22, 2025 •

edited

Loading

iarspider commented Sep 23, 2025 •

edited

Loading