New HLT Scouting DQM Online Client #48398
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48398/45297 |
| process.dqmcommon = cms.Sequence(process.dqmEnv | ||
| * process.dqmSaver)#*process.dqmSaverPB) | ||
|
|
||
| process.p = cms.Path(process.dqmcommon * process.scoutingCollectionMonitor) |
There was a problem hiding this comment.
@silviodonato @elfontan shall we run more than this module in the DQM sequence?
E.g. also HLTriggerOffline/Scouting/python/ScoutingMuonTriggerAnalyzer_cfi.py seems to be possible to run directly on the DQMOnlineScouting stream. Any other module?
Thanks in advance.
There was a problem hiding this comment.
@mmusich I tried to add the other scouting DQM modules to @jprendi's code and running on scouting data.
- EGM DQM doesn't work because it relies on
slimmedElectrons - JME DQM can works if you provide a
L1GtTriggerMenurecord (note this is the Run-1 GT !). It is used in this part of code. I hope that is accidentally still working properly because likely the L1 technical trigger haven't changed trigger number since Run-1.
In addition these two JetMETDQMDCSFilter sends a lot of warnings because bothscalersRawToDigiandonlineMetaDataDigisare missing (see lines).
Anyway, I managed to get not-empty plots - MUO DQM works without complains.
Summary:
process.GlobalTag.toGet.append(
cms.PSet(
record = cms.string("L1GtTriggerMenuRcd"),
tag = cms.string('L1GtTriggerMenu_CRAFT09_hlt'),
)
)
process.load("DQMOffline/HLTScouting/HLTScoutingDqmOffline_cff")
process.hltScoutingDqmOffline = cms.Sequence(process.hltScoutingMuonDqmOffline+process.hltScoutingCollectionMonitor +process.hltScoutingJetDqmOffline+process.hltScoutingCollectionMonitor)
process.p = cms.Path(process.dqmcommon * process.scoutingCollectionMonitor * process.hltScoutingDqmOffline)
works.
From the scouting point of view, it is better to include both JME e MUO.
Begin processing the 301st record. Run 393448, Event 3730472772, LumiSection 1606 on stream 0 at 25-Jun-2025 16:50:01.397 CEST
%MSG-e JetMETDQMDCSFilter: JetAnalyzer:jetDQMAnalyzerAk4ScoutingCleaned 25-Jun-2025 16:50:01 CEST Run: 393448 Event: 3730472772
Error! can't get the product, neither DCSRecord, nor scalersRawToDigi: accept in any case!
%MSG
%MSG-e JetMETDQMDCSFilter: JetAnalyzer:jetDQMAnalyzerAk4ScoutingCleaned 25-Jun-2025 16:50:01 CEST Run: 393448 Event: 3730472772
Error! can't get the product, neither DCSRecord, nor scalersRawToDigi: accept in any case!
%MSG
%MSG-e JetMETDQMDCSFilter: JetAnalyzer:jetDQMAnalyzerAk4ScoutingUncleaned 25-Jun-2025 16:50:01 CEST Run: 393448 Event: 3730472772
Error! can't get the product, neither DCSRecord, nor scalersRawToDigi: accept in any case!
%MSG
%MSG-e JetMETDQMDCSFilter: JetAnalyzer:jetDQMAnalyzerAk4ScoutingUncleaned 25-Jun-2025 16:50:01 CEST Run: 393448 Event: 3730472772
Error! can't get the product, neither DCSRecord, nor scalersRawToDigi: accept in any case!
%MSG
@cms-sw/dqm-l2 is it a problem if the online DQM gives the 4 warnings above per each event?
(Meanwhile I will prepare a possible commit to Jessica's PR to include the other online DQM modules)
There was a problem hiding this comment.
In addition these two JetMETDQMDCSFilter sends a lot of warnings because both scalersRawToDigi and onlineMetaDataDigis are missing (see lines).
I think we can get rid of that quite easily by saving the hltOnlineMetaDataDigis in the DQM stream.
We're still in time to change the event content if you open a ticket about it!
There was a problem hiding this comment.
@mmusich @jprendi you can find the commit to add the MUO e JME DQM in
silviodonato@c492bb0
I managed to run it with
cmsRun scouting_dqm_sourceclient-live_cfg.py unitTest=True dataset=/ScoutingPFRun3/Run2025C-v1/HLTSCOUT runNumber=392175 minLumi=500 maxLumi=500
@mmusich do you think it is ok to append the missing L1GtTriggerMenuRcd in this way?
There was a problem hiding this comment.
Right, I will make a JIRA to include the hltOnlineMetaDataDigis.
We will need also need to add hltOnlineMetaDataDigis as a fallback of onlineMetaDataDigis
There was a problem hiding this comment.
do you think it is ok to append the missing
L1GtTriggerMenuRcdin this way?
clearly it's a nasty patch.
I discovered that there are elsewhere pieces of DQM that rely on the Legacy GT, see for example #46715.
I think we should strive to fix that in the longer term (everywhere in cmssw).
Feel free to open an issue about this instance.
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48398/45319 |
|
Pull request #48398 was updated. |
|
please test |
|
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test TestDQMOnlineClient-scouting_dqm_sourceclient had ERRORS Comparison SummarySummary:
|
|
The problem is that it is tested in an Express file, while we need the scouting objects |
We noticed, we are working to create a streamer file to use for the tests. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48398/45344 |
|
Pull request #48398 was updated. @Martin-Grunewald, @antoniovagnerini, @cmsbuild, @ctarricone, @mmusich, @rseidita can you please check and sign again. |
|
please test |
|
+1 Size: This PR adds an extra 72KB to repository The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
|
+hlt
|
|
@cms-sw/dqm-l2 we will need this client for the upcoming pp data-taking after the small systems run. Can you have a look to this and the cms-data PR cms-data/DQM-Integration#11 ? |
|
+dqm |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
REMINDER @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela: This PR was tested with cms-data/DQM-Integration#11, please check if they should be merged together |
|
+1 |
6 participants
PR description:
Following the discussion at CMSHLT-3571 and last weeks HLT Scouting meeting , we are introducing a new HLT Scouting DQM online client to include the new
DQMOnlineScoutingstream. We are adding the client and adapting BuildFile.xml to include unit testing for the new client as well.PR validation:
This PR has been prepared starting from
CMSSW_15_1_X_2025-06-23-2300:Running
git cms-checkdeps -a -Ashows that there are no further dependencies. For validation, I ran:What is left to do is to validate the online DQM client by running it on a
DQMOnlineScoutingfile from the new stream !This is not backport but it will be backported to 15.0.X for 2025 data taking operations.