-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Improvements to ScoutingCollectionMonitor
#48646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to ScoutingCollectionMonitor
#48646
Conversation
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48646/45636
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
4c71882 to
98f29bd
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48646/45637
|
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@Martin-Grunewald, @antoniovagnerini, @cmsbuild, @ctarricone, @mmusich, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
test parameters:
|
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 36KB to repository Comparison SummarySummary:
|
|
+hlt |
|
Tested this PR with CMSSW_15_0_10_patch2 at our playback machines with the streamers of run 394663 Collision25 run, output looks corrected, also confirmed by Marco. |
|
+dqm |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This PR is a follow-up to #48398.
When inspecting the output of the DQM online scouting distributions for 2025 data-taking I noticed that the rate of objects to monitor is such that we are exhausting the number of entries per bin in single precision, see e.g. https://tinyurl.com/2bbsyrpx or https://tinyurl.com/23rw78su (certain bins getting capped at a fixed value).
The goal of this PR is to book the various distributions to be monitored as
TH1Dinstead ofTH1F(similarly in spirit to what was done for #45225, see also issue #45183).Additionally I provide commit d8dd826, in which the
onlyScoutingflag forScoutingCollectionMonitoris flipped to false. This is possible because we're actually saving thehltOnlineMetaDataDigistoDQMOnlineScoutingstream (see also CMSHLT-3585).PR validation:
scram b runtests_TestDQMOnlineClient-scouting_dqm_sourceclientruns fine and without warnings.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but it will be backported to CMSSW_15_0_X for data-taking operations.