Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 29, 2025

PR description:

This PR is a follow-up to #48398.
When inspecting the output of the DQM online scouting distributions for 2025 data-taking I noticed that the rate of objects to monitor is such that we are exhausting the number of entries per bin in single precision, see e.g. https://tinyurl.com/2bbsyrpx or https://tinyurl.com/23rw78su (certain bins getting capped at a fixed value).
The goal of this PR is to book the various distributions to be monitored as TH1D instead of TH1F (similarly in spirit to what was done for #45225, see also issue #45183).
Additionally I provide commit d8dd826, in which the onlyScouting flag for ScoutingCollectionMonitor is flipped to false. This is possible because we're actually saving the hltOnlineMetaDataDigis to DQMOnlineScouting stream (see also CMSHLT-3585).

PR validation:

scram b runtests_TestDQMOnlineClient-scouting_dqm_sourceclient runs fine and without warnings.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but it will be backported to CMSSW_15_0_X for data-taking operations.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 29, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48646/45636

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@mmusich mmusich force-pushed the mm_improve_ScoutingCollectionMonitor branch from 4c71882 to 98f29bd Compare July 29, 2025 08:48
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48646/45637

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQM/HLTEvF (hlt, dqm)
  • DQM/Integration (dqm)

@Martin-Grunewald, @antoniovagnerini, @cmsbuild, @ctarricone, @mmusich, @rseidita can you please review it and eventually sign? Thanks.
@batinkov, @francescobrivio, @missirol, @mtosi, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jul 29, 2025

test parameters:

  • workflow = 145.415

@mmusich
Copy link
Contributor Author

mmusich commented Jul 29, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b0d2c/47437/summary.html
COMMIT: 98f29bd
CMSSW: CMSSW_15_1_X_2025-07-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48646/47437/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 4171154
  • DQMHistoTests: Total failures: 19
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4171115
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 74.957 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 145.415 ): 74.957 KiB HLT/ScoutingOffline
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Jul 29, 2025

+hlt

@syuvivida
Copy link
Contributor

syuvivida commented Jul 31, 2025

Tested this PR with CMSSW_15_0_10_patch2 at our playback machines with the streamers of run 394663 Collision25 run, output looks corrected, also confirmed by Marco.

@antoniovagnerini
Copy link

+dqm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 043863c into cms-sw:master Jul 31, 2025
11 checks passed
@mmusich mmusich deleted the mm_improve_ScoutingCollectionMonitor branch July 31, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants