Skip to content

Conversation

@tihsu99
Copy link
Contributor

@tihsu99 tihsu99 commented Sep 9, 2025

PR description:

A patch is added to include scouting egamma DQM monitoring in the online stream. The update is highly related to previous PR #48398 i.e. here we introduce scouting egamma part into HLT Scouting DQM online client for the DQMOnlineScoutingstream. This progress has been mentioned in the scouting meeting at 28 Aug 2025.

This is the backport of the approved PR for CMSSW_15_1_X: cmssw#48850 Include scouting EGM in Online DQM stream

Description of the current change

  • Add options useOfflineObject in the config files under the original HLTriggerOffline/Scouting. In online stream, we could choose not to use any offline object by such options.

  • Add EGM part to online stream config file accordingly.

  • Note: The current file HLTriggerOffline/Scouting/python/HLTScoutingEGammaPostProcessing_cff.py, which corresponds to the DQM Harvester, uses offline objects to achieve more accurate Tag-and-Probe measurements. Therefore, this postprocessor is not included in the online DQM sequence. (Similarly, in previous PR, for scouting muons, the harvester defined in HLTriggerOffline/Scouting/python/ScoutingMuonMonitoring_Client_cff.py is not used in Online DQM.) This is mentioned here for completeness.

PR validation:

This PR is prepared under CMSSW_15_0_13_patch2

scram project CMSSW_15_0_13_patch2
cd CMSSW_15_0_13_patch2/src/
cmsenv
git cms-rebase-topic --old-base  CMSSW_15_1_X_2025-08-27-2300 tihsu99:ScoutingOnlineDQM
scram b && scram b code-checks && scram b code-format && scram b

and run with

 runTheMatrix.py -l 145.314

[c.c. @mmusich @rseidita @silviodonato @patinkaew ]

[config] reformat config to right dir

[config] reformat config to right dir

[code check]

[update] fix for comments

[update] fix for comments

[update] for squash comment
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2025

Pull request #48878 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor

mmusich commented Sep 9, 2025

backport of #48850

@mmusich
Copy link
Contributor

mmusich commented Sep 9, 2025

test parameters:

  • addpkg = DQM/Integration
  • workflow = 145.314

@mmusich
Copy link
Contributor

mmusich commented Sep 9, 2025

@cmsbuild, please test

@tihsu99 tihsu99 marked this pull request as ready for review September 9, 2025 15:51
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2025

A new Pull Request was created by @tihsu99 for CMSSW_15_0_X.

It involves the following packages:

  • DQM/HLTEvF (hlt, dqm)
  • DQM/Integration (dqm)
  • HLTriggerOffline/Scouting (dqm)

@Martin-Grunewald, @antoniovagnerini, @ctarricone, @mmusich, @rseidita can you please review it and eventually sign? Thanks.
@batinkov, @francescobrivio, @missirol, @mmusich, @mtosi, @threus this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2025

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37457a/48037/summary.html
COMMIT: a364422
CMSSW: CMSSW_15_0_X_2025-09-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48878/48037/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 4112096
  • DQMHistoTests: Total failures: 58
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4112018
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 222 log files, 193 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Sep 9, 2025

+hlt

@mandrenguyen
Copy link
Contributor

@cms-sw/dqm-l2 please have a look

@rseidita
Copy link
Contributor

+dqm

  • P5 tests OK

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rseidita
Copy link
Contributor

@mmusich @tihsu99 do you want us to deploy the PR in production before the release including it is built?

@mmusich
Copy link
Contributor

mmusich commented Sep 10, 2025

do you want us to deploy the PR in production before the release including it is built?

If you can do that, it would be nice. If you change release can you pick up also #48790 ? Thank you.

@ftenchini
Copy link

+1

@cmsbuild cmsbuild merged commit 4fe3f1d into cms-sw:CMSSW_15_0_X Sep 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants