Modify RPC isFront function to match criteria with will be modified RPC geometries for Run, Run 3 and Run 4 #47138
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47138/43365 |
|
A new Pull Request was created by @eigen1907 for master. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
eigen1907
changed the title
|
please test |
|
please abort |
|
please test |
|
The errors such as the WF 140.045 are expected already written in the PR description. |
|
Pull request #47138 was updated. @arunhep, @atpathak, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @jfernan2, @mandrenguyen, @perrotta can you please check and sign again. |
|
please test |
|
-1 Failed Tests: UnitTests RelVals-INPUT AddOn Unit TestsI found 4 errors in the following unit tests: ---> test TestDQMOnlineClient-hlt_dqm_sourceclient had ERRORS ---> test TestDQMOnlineClient-mutracking_dqm_sourceclient had ERRORS ---> test TestDQMOnlineClient-pixel_dqm_sourceclient had ERRORS and more ... RelVals-INPUT
AddOn TestsExpand to see more addon errors ...Comparison SummarySummary:
|
|
So, the tests allowed us to verify where there are issues with the Global Tags. Let remind here that up to now only 151X 2025 MC GTs were updated with the fixed RPC geometry, at least among the ones listed in Configuration/AlCa/python/autoCond.py According to the logs I was able to inspect, I see two kinds of issues to be addressed:
The first item should be investigated together with the Condition Preparation group (@arunhep @atpathak, and I can also help) About the second item: @mmusich @Martin-Grunewald is there any reason for not moving to |
See #48903 |
|
please test |
Just a note, the HLT recognizes no eras. If this is meant as a permanent change the HLT menus will need to be updated accordingly via CMSHLT ticket and regular integration procedures . |
|
-1 Failed Tests: UnitTests RelVals-INPUT AddOn Unit TestsI found 4 errors in the following unit tests: ---> test TestDQMOnlineClient-hlt_dqm_sourceclient had ERRORS ---> test TestDQMOnlineClient-mutracking_dqm_sourceclient had ERRORS ---> test TestDQMOnlineClient-sistrip_dqm_sourceclient had ERRORS and more ... RelVals-INPUT
AddOn TestsExpand to see more addon errors ...Comparison SummarySummary:
|
|
Milestone for this pull request has been moved to CMSSW_16_1_X. Please open a backport if it should also go in to CMSSW_16_0_X. |
8 participants
PR description:
This PR modifies the isFront function inside the RPC Endcap Geometry Builder.
It will be applied in synchronization with PR (#47134) by Sunanda Banerjee.
The isFront function classifies RPCs as front or back chambers by RPC Ids.
As the PR (#47134) modifies the z coordinates of RPCs inside RPC endcap stations (RE-4, RE-3, RE-2, RE+2, RE+3, RE+4),
The criteria for the isFront function needs to be changed as well.
Therefore, this PR modifies the criteria for the isFront function correctly as the z coordinate changes.
For history and more details, see the previous meeting materials.
(https://indico.cern.ch/event/1475698/contributions/6214667/attachments/2962024/5210467/RPCGeomReport_241106RPCDPG_JShin.pdf)
PR validation:
To avoid errors, this PR should be used with #47134 and the new scenario.
Otherwise (when applying this PR alone), the error below will be raised by the selfTest function in the Geometry Builder.
Error reproduction)
This change will also require a new payload for RPC Geometry when working with Global Tags.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special