update mds trigger thresholds with era change tracked #49373

AlexAlbert41 · 2025-11-11T23:01:04Z

PR description:

This pull request corresponds with the backport PR #49217. It is an improvement of the changes in PR #49216 , which changed the trigger thresholds without accounting for the change in Era. We only want the new thresholds to be applied for 2025 Era F and after, and this is accounted for in this PR.

This PR updates 2025 HMT shower thresholds for pp collisions to be implemented for Era 2025F.

Details were presented by @kakwok at the TSG Meeting on August 20. [1].

[1] https://indico.cern.ch/event/1571789/#35-exo-report-on-l1t-muon-show

PR validation:

Tuning of trigger thresholds for redistribution of rates within CSC station-rings for optimized physics performance.

cmsbuild · 2025-11-11T23:01:29Z

cms-bot internal usage

cmsbuild · 2025-11-11T23:02:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49373/46780

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Eras/python/Era_Run3_2025_cff.py modified in PR(s): Modify RPC isFront function to match criteria with will be modified RPC geometries for Run, Run 3 and Run 4 #47138

cmsbuild · 2025-11-11T23:02:45Z

A new Pull Request was created by @AlexAlbert41 for master.

It involves the following packages:

Configuration/Eras (operations)
L1Trigger/CSCTriggerPrimitives (l1)

@BenjaminRS, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @mandrenguyen, @quinnanm can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @eyigitba, @fabiocos, @giovanni-mocellin, @makortel, @missirol, @mmusich, @ptcox, @valuev this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

BenjaminRS · 2025-11-12T13:47:10Z

please test

cmsbuild · 2025-11-12T15:28:46Z

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ff712/49424/summary.html
COMMIT: 1ebfab1
CMSSW: CMSSW_16_0_X_2025-11-12-1200/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49373/49424/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 10 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 5 differences found in the comparisons
Reco comparison had 2 failed jobs
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3880468
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3880442
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 218 log files, 188 edm output root files, 51 DQM output files
TriggerResults: no differences found

caruta · 2025-11-13T15:58:03Z

Configuration/Eras/python/Era_Run3_2025_cff.py

 from Configuration.ProcessModifiers.siPixelDigiMorphing_cff import siPixelDigiMorphing

-Run3_2025 = cms.ModifierChain(Run3_2024, run3_GEM_2025, stage2L1Trigger_2025, run3_SiPixel_2025, run3_CSC_2025, run3_nanoAOD_2025, run3_scouting_2025, ecal_cctiming, siPixelGoodEdgeAlgo, siPixelDigiMorphing)
+Run3_2025 = cms.ModifierChain(Run3_2024, run3_GEM_2025, stage2L1Trigger_2025, run3_SiPixel_2025, run3_CSC_2025_AtoE, run3_nanoAOD_2025, run3_scouting_2025, ecal_cctiming, siPixelGoodEdgeAlgo, siPixelDigiMorphing)


Hi @AlexAlbert41, thanks for the PR!
I've got a small request: could you please update the Run3_2025 flag here to use the run3_CSC_2025_FtoG thresholds? For 2025 it doesn't really matter since the thresholds were changed in the middle of the run, but it would be good to use the last set of thresholds here to avoid any mistake in 2026 (when we'll keep using the FtoG thresholds). Thanks!

Hi @caruta, this should be fixed now with the new commit. Please let me know if there is anything else that I should do. Thanks!

Fixed with the second commit after this message, I originally forgot to change the import statement as well

cmsbuild · 2025-11-19T20:20:54Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49373/46885

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Eras/python/Era_Run3_2025_cff.py modified in PR(s): Modify RPC isFront function to match criteria with will be modified RPC geometries for Run, Run 3 and Run 4 #47138

cmsbuild · 2025-11-19T20:21:13Z

Pull request #49373 was updated. @BenjaminRS, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @mandrenguyen, @quinnanm can you please check and sign again.

cmsbuild · 2025-11-19T20:34:47Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49373/46886

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Eras/python/Era_Run3_2025_cff.py modified in PR(s): Modify RPC isFront function to match criteria with will be modified RPC geometries for Run, Run 3 and Run 4 #47138

cmsbuild · 2025-11-19T20:35:05Z

Pull request #49373 was updated. @BenjaminRS, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @mandrenguyen, @quinnanm can you please check and sign again.

quinnanm · 2025-11-19T20:51:27Z

please test

cmsbuild · 2025-11-19T22:14:22Z

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ff712/49566/summary.html
COMMIT: af6ea35
CMSSW: CMSSW_16_0_X_2025-11-19-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49373/49566/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 7 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 5 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3896448
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3896417
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 218 log files, 188 edm output root files, 51 DQM output files
TriggerResults: no differences found

BenjaminRS · 2025-11-21T20:10:25Z

+l1

cmsbuild · 2025-11-21T20:10:52Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-11-21T21:12:24Z

+1

update mds trigger thresholds with era change tracked

1ebfab1

cmsbuild added this to the CMSSW_16_0_X milestone Nov 11, 2025

cmsbuild added l1-pending operations-pending pending-signatures tests-pending orp-pending code-checks-pending labels Nov 11, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 11, 2025

cmsbuild added tests-started and removed tests-pending labels Nov 12, 2025

cmsbuild added operations-approved tests-approved and removed operations-pending tests-started labels Nov 12, 2025

caruta reviewed Nov 13, 2025

View reviewed changes

update Run3_2025 flag

fa7ace5

cmsbuild added operations-pending tests-pending code-checks-pending and removed operations-approved tests-approved code-checks-approved labels Nov 19, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 19, 2025

update Run3_2025 flag + import

af6ea35

cmsbuild added code-checks-pending and removed code-checks-approved labels Nov 19, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 19, 2025

cmsbuild added tests-started and removed tests-pending labels Nov 19, 2025

AlexAlbert41 mentioned this pull request Nov 19, 2025

update mds trigger thresholds with era change CMSSW_15_0_16 #49423

Merged

cmsbuild added operations-approved tests-approved and removed operations-pending tests-started labels Nov 19, 2025

cmsbuild added l1-approved fully-signed and removed l1-pending pending-signatures labels Nov 21, 2025

cmsbuild added orp-approved and removed orp-pending labels Nov 21, 2025

cmsbuild merged commit 65b35fc into cms-sw:master Nov 21, 2025
10 checks passed

update mds trigger thresholds with era change tracked #49373

update mds trigger thresholds with era change tracked #49373

Uh oh!

Conversation

AlexAlbert41 commented Nov 11, 2025

Uh oh!

cmsbuild commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Nov 11, 2025

Uh oh!

cmsbuild commented Nov 11, 2025

Uh oh!

BenjaminRS commented Nov 12, 2025

Uh oh!

cmsbuild commented Nov 12, 2025

Comparison Summary

Uh oh!

caruta Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

AlexAlbert41 Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

AlexAlbert41 Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Nov 19, 2025

Uh oh!

cmsbuild commented Nov 19, 2025

Uh oh!

cmsbuild commented Nov 19, 2025

Uh oh!

cmsbuild commented Nov 19, 2025

Uh oh!

quinnanm commented Nov 19, 2025

Uh oh!

cmsbuild commented Nov 19, 2025

Comparison Summary

Uh oh!

BenjaminRS commented Nov 21, 2025

Uh oh!

cmsbuild commented Nov 21, 2025

Uh oh!

mandrenguyen commented Nov 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cmsbuild commented Nov 11, 2025 •

edited

Loading