ROOT6 changes needed for RNTupleModel

[smuzaffar]

Latest ROOT change root-project/root#14454 has removed

• void RUpdater::AddField(const NameWithDescription_t &fieldNameDesc, T *fromWhere)
  As suggested [ntuple] various interface improvements root-project/root#14454 (comment) , this PR makes use of MakeField
• T *RUpdater::Get(std::string_view fieldName)
  This is now replaced with model.GetDefaultEntry().GetPtr<bool>(name). Extra check on ROOT_VERSION_CODE is added to allow same code to run for all ROOT 6.26 and above IB

Local compilation works for all ROOT626 to ROOT6 (root master based) IBs

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43834/38658

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43834/38658/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43834/38658/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43834/38659

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@hqucms, @cmsbuild, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @missirol, @AnnikaStein this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

enable nano

[smuzaffar]

please test

[makortel]

@dan131riley Please take a look

[dan131riley]

@dan131riley Please take a look

looks ok, new interfaces are definitely an improvement

[cmsbuild]

-1

Failed Tests: RelVals-NANO
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d34411/37165/summary.html
COMMIT: a5ab7b1
CMSSW: CMSSW_14_0_X_2024-02-01-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43834/37165/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-NANO

• 2500.512500.51_ScoutingNanomc13X/step1_ScoutingNanomc13X.log

Comparison Summary

Summary:

• You potentially removed 111 lines from the logs
• Reco comparison results: 49 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3248620
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3248586
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[smuzaffar]

@cms-sw/xpog-l2 can you please review this? this is needed for ROOT master based builds. Note that nano workflow 2500.51 failure is not related to this change. It is failing for other PRs too e.g. #43806

[smuzaffar]

@hqucms, @vlimant can you please review this?

[hqucms]

+xpog

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

REMINDER @sextonkennedy, @antoniovilela, @rappoccio: This PR was tested with cms-sw/cmsdist#8981, please check if they should be merged together

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X.

[smuzaffar]

@cms-sw/orp-l2 , can you please review and sign this? This is needed fro ROOT6 update cms-sw/cmsdist#8981

[smuzaffar]

@cms-sw/orp-l2 can we get this in for 14.1.X?

[rappoccio]

+1

[rappoccio]

merge