[do not merge] [runtime-cxxmodules] Rework our lazy template specialization deserialization mechanism #198

smuzaffar · 2024-02-02T09:20:51Z

cmsbuild · 2024-02-02T09:21:13Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch cms/master/aa513463b0.

@iarspider, @smuzaffar, @aandvalenzuela, @cmsbuild can you please review it and eventually sign? Thanks.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2024-02-02T09:21:14Z

cms-bot internal usage

smuzaffar · 2024-02-02T09:21:57Z

test parameters:

pull_request = ROOT6 changes needed for RNTupleModel cmssw#43834

smuzaffar · 2024-02-02T09:22:07Z

please test for CMSSW_14_0_ROOT6_X

cmsbuild · 2024-02-02T20:35:06Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65246c/37182/summary.html
COMMIT: 3387aa4
CMSSW: CMSSW_14_0_ROOT6_X_2024-01-31-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/198/37182/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test testG4Refitter had ERRORS

Comparison Summary

Summary:

You potentially added 25 lines to the logs
Reco comparison results: 952 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3248620
DQMHistoTests: Total failures: 7672
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3240926
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

cmsbuild · 2024-02-03T11:46:41Z

Pull request #198 was updated.

cmsbuild · 2024-02-03T14:06:17Z

Pull request #198 was updated.

…oject#14589) * Print a warning when the range given to SetRange is invalid. * Fix comment

It turns out that this is not required anymore, even for builds/platforms without runtime modules enabled.

* [NFC][ntuple] describe code architecture * [NFC][ntuple] improve architecture description Co-authored-by: Florine de Geus <git@fwdg.nl> * [NFC][ntuple] improve architecture description Co-authored-by: Florine de Geus <git@fwdg.nl> * [NFC][ntuple] improve architecture description Co-authored-by: Florine de Geus <git@fwdg.nl> * [NFC][ntuple] improve architecture description Co-authored-by: Florine de Geus <git@fwdg.nl> * [NFC][ntuple] improve architecture description Co-authored-by: Jonas Hahnfeld <hahnjo@hahnjo.de> * [NFC][ntuple] improve architecture description Co-authored-by: Jonas Hahnfeld <hahnjo@hahnjo.de> * [NFC][ntuple] improve architecture description Co-authored-by: Florine de Geus <git@fwdg.nl> * [NFC][ntuple] improve architecture description Co-authored-by: Florine de Geus <git@fwdg.nl> * [NFC][ntuple] improve architecture description Co-authored-by: Jonas Hahnfeld <hahnjo@hahnjo.de> * [NFC][ntuple] improve architecture description Co-authored-by: Florine de Geus <git@fwdg.nl> * [NFC][ntuple] improve architecture description Co-authored-by: Jonas Hahnfeld <hahnjo@hahnjo.de> * [NFC][ntuple] improve architecture description Co-authored-by: Florine de Geus <git@fwdg.nl> * [NFC][ntuple] improve architecture description Co-authored-by: Florine de Geus <git@fwdg.nl> * [NFC][ntuple] improve architecture description Co-authored-by: Florine de Geus <git@fwdg.nl> * [NFC][ntuple] improve architecture description Co-authored-by: Florine de Geus <git@fwdg.nl> * [NFC][ntuple] improve architecture description Co-authored-by: Florine de Geus <git@fwdg.nl> * [NFC][ntuple] improve architecture description * [NFC][ntuple] improve architecture description * [NFC][ntuple] improve architecture description * [NFC][ntuple] improve architecture description * [NFC][ntuple] improve architecture description * [NFC][ntuple] improve architecture description * [NFC][ntuple] improve architecture description Co-authored-by: Vincenzo Eduardo Padulano <v.e.padulano@gmail.com> * [NFC][ntuple] improve architecture description Co-authored-by: Vincenzo Eduardo Padulano <v.e.padulano@gmail.com> * [NFC][ntuple] improve architecture description Co-authored-by: Vincenzo Eduardo Padulano <v.e.padulano@gmail.com> * [NFC][ntuple] improve architecture description --------- Co-authored-by: Florine de Geus <git@fwdg.nl> Co-authored-by: Jonas Hahnfeld <hahnjo@hahnjo.de> Co-authored-by: Vincenzo Eduardo Padulano <v.e.padulano@gmail.com>

`RPageSource` now lives in the `Internal` namespace, so we can make the `UnsealPage` method public.

…t-project#14851)

Correctly scale axes labels and title sizes. One have to use main pad dimensions. Do not rescale vertical axis labels if space is too low. Correctly draw ratio plot lines after zooming Fix rounding problem with TLine positions

mtbb201_parallelHistoFill.C fails on Windows x86 and VS v17.9 with the following error: IncrementalExecutor::executeFunction: symbol '_Thrd_sleep_for@4' unresolved while linking [cling interface function]! Due to this line: std::this_thread::sleep_for(std::chrono::duration<double, std::nano>(500));

Co-authored-by: Vincenzo Eduardo Padulano <vincenzo.eduardo.padulano@cern.ch>

cmsbuild · 2024-02-29T18:51:22Z

This PR contains too many commits (385 >= 240) and will not be processed.
Please ensure you have selected the correct target branch and consider squashing unnecessary commits.
The processing of this PR will resume once the commit count drops below the limit.

cmsbuild · 2024-03-01T07:30:28Z

This PR contains too many commits (386 >= 240) and will not be processed.
Please ensure you have selected the correct target branch and consider squashing unnecessary commits.
The processing of this PR will resume once the commit count drops below the limit.

cmsbuild · 2024-03-05T07:50:50Z

This PR contains too many commits (388 >= 240) and will not be processed.
Please ensure you have selected the correct target branch and consider squashing unnecessary commits.
The processing of this PR will resume once the commit count drops below the limit.

cmsbuild · 2024-03-05T12:02:18Z

This PR contains too many commits (389 >= 240) and will not be processed.
Please ensure you have selected the correct target branch and consider squashing unnecessary commits.
The processing of this PR will resume once the commit count drops below the limit.

cmsbuild · 2024-03-05T12:21:18Z

This PR contains too many commits (389 >= 240) and will not be processed.
Please ensure you have selected the correct target branch and consider squashing unnecessary commits.
The processing of this PR will resume once the commit count drops below the limit.

…ion locally

cmsbuild · 2024-03-05T14:25:55Z

This PR contains too many commits (390 >= 240) and will not be processed.
Please ensure you have selected the correct target branch and consider squashing unnecessary commits.
The processing of this PR will resume once the commit count drops below the limit.

Since we need access the protect member in findSpecializationLocally

cmsbuild · 2024-03-05T19:55:11Z

This PR contains too many commits (391 >= 240) and will not be processed.
Please ensure you have selected the correct target branch and consider squashing unnecessary commits.
The processing of this PR will resume once the commit count drops below the limit.

cmsbuild added orp-pending pending-signatures externals-pending tests-pending labels Feb 2, 2024

cmsbuild added tests-started requires-external and removed tests-pending labels Feb 2, 2024

smuzaffar mentioned this pull request Feb 2, 2024

[do not merge] [runtime-cxxmodules] Rework our lazy template specialization deserialization mechanism root-project/root#14495

Closed

cmsbuild added tests-rejected tests-pending and removed tests-started tests-rejected labels Feb 2, 2024

vgvassilev force-pushed the llvm-pr76774 branch from 637378e to f714dda Compare February 3, 2024 14:05

iarspider mentioned this pull request Feb 8, 2024

Script to mass-update bot cache in all issues cms-sw/cms-bot#2165

Merged

kjvbrt and others added 9 commits February 15, 2024 13:38

One more 'Note:' -> '\note'

9f4cf3b

[math] Leave TRandom1 methods definition untouched

4436d3d

simplify clang-format options for compatibility with older versions

c5fd7be

Print a warning when the range given to SetRange is invalid. (root-pr…

c6ded32

…oject#14589) * Print a warning when the range given to SetRange is invalid. * Fix comment

[DF] Remove use of R__LOAD_LIBRARY in tutorial

80ef949

It turns out that this is not required anymore, even for builds/platforms without runtime modules enabled.

[eve7] Remove use of R__LOAD_LIBRARY in tutorial

561f097

It turns out that this is not required anymore, even for builds/platforms without runtime modules enabled.

[io] Remove use of R__LOAD_LIBRARY in tutorial

c5ee5fa

It turns out that this is not required anymore, even for builds/platforms without runtime modules enabled.

[math] Remove use of R__LOAD_LIBRARY in tutorial

e6e4845

It turns out that this is not required anymore, even for builds/platforms without runtime modules enabled.

[rcanvas] Remove use of R__LOAD_LIBRARY in tutorial

3fa99d2

It turns out that this is not required anymore, even for builds/platforms without runtime modules enabled.

dpiparo and others added 13 commits February 28, 2024 15:21

[skip ci][ci] Specify head_ref

e364c89

[ntuple] Make RPageSource::UnsealPage public

778179c

`RPageSource` now lives in the `Internal` namespace, so we can make the `UnsealPage` method public.

Allow user-defined safety to be drawn in TGeoManager::CheckPoint (roo…

fd4374b

…t-project#14851)

[jsroot] dev 28/02/2024 with TRatioPlot fixes

7571a60

Correctly scale axes labels and title sizes. One have to use main pad dimensions. Do not rescale vertical axis labels if space is too low. Correctly draw ratio plot lines after zooming Fix rounding problem with TLine positions

remove ROOT::Experimental::TFuture

31d82dd

[tmva] Use proper ClassDef macro in Result* classes

0f14586

Co-authored-by: Vincenzo Eduardo Padulano <vincenzo.eduardo.padulano@cern.ch>

[skip-ci] update tmva results docu

e8ef690

[tmva][NFC] Run clang-format on Result* headers

acd75d3

Revert root-project/llvm-project@ed6cf70

84a1879

PR76774

3e72f1d

[Serialization] Code cleanups and polish 83233

60631dc

vgvassilev force-pushed the llvm-pr76774 branch from f714dda to 60631dc Compare February 29, 2024 18:50

Adapt to llvm16

d9eee20

ChuanqiXu9 added 2 commits March 5, 2024 07:49

Update out of tree external sources

1c36e0e

Remove iterator before GetDecl

5b46e86

TraverseDecl might deserialize

92ee19a

vgvassilev force-pushed the llvm-pr76774 branch from 9e4125f to 92ee19a Compare March 5, 2024 12:20

Avoid loading external specializations if we can find the specializat…

37d5004

…ion locally

Add findSpecializationLocally as a member of RedeclarableTemplateDecl

552a7b4

Since we need access the protect member in findSpecializationLocally

smuzaffar closed this Mar 15, 2024

vgvassilev deleted the llvm-pr76774 branch October 24, 2025 14:57

[do not merge] [runtime-cxxmodules] Rework our lazy template specialization deserialization mechanism #198

[do not merge] [runtime-cxxmodules] Rework our lazy template specialization deserialization mechanism #198

Uh oh!

Conversation

smuzaffar commented Feb 2, 2024

Uh oh!

cmsbuild commented Feb 2, 2024

Uh oh!

cmsbuild commented Feb 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smuzaffar commented Feb 2, 2024

Uh oh!

smuzaffar commented Feb 2, 2024

Uh oh!

cmsbuild commented Feb 2, 2024

Unit Tests

Comparison Summary

Uh oh!

cmsbuild commented Feb 3, 2024

Uh oh!

cmsbuild commented Feb 3, 2024

Uh oh!

cmsbuild commented Feb 29, 2024

Uh oh!

cmsbuild commented Mar 1, 2024

Uh oh!

cmsbuild commented Mar 5, 2024

Uh oh!

cmsbuild commented Mar 5, 2024

Uh oh!

cmsbuild commented Mar 5, 2024

Uh oh!

cmsbuild commented Mar 5, 2024

Uh oh!

cmsbuild commented Mar 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

cmsbuild commented Feb 2, 2024 •

edited

Loading