Skip to content

[ROOT6] Updated root to tip of branch master #8981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smuzaffar merged 1 commit into from
Feb 7, 2024
Merged

[ROOT6] Updated root to tip of branch master #8981

smuzaffar merged 1 commit into from
Feb 7, 2024

Conversation

@aandvalenzuela
Copy link
Contributor

@aandvalenzuela aandvalenzuela commented Feb 1, 2024 •
edited
Loading

ROOT version is still 6.31.01.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2024

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch IB/CMSSW_14_0_X/rootmaster.

@smuzaffar, @aandvalenzuela, @cmsbuild, @iarspider can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2024 •
edited
Loading

cms-bot internal usage

@aandvalenzuela
Copy link
Contributor Author

aandvalenzuela commented Feb 1, 2024

please test

@aandvalenzuela aandvalenzuela mentioned this pull request Feb 1, 2024
Closed
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2024

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e9f00/37164/summary.html
COMMIT: 5b2462f
CMSSW: CMSSW_14_0_ROOT6_X_2024-01-31-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8981/37164/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_ROOT6_X_2024-01-31-2300/src/PhysicsTools/NanoAOD/plugins/rntuple/NanoAODRNTuples.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_ROOT6_X_2024-01-31-2300/src/PhysicsTools/NanoAOD/plugins/rntuple/SummaryTableOutputFields.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_ROOT6_X_2024-01-31-2300/src/PhysicsTools/NanoAOD/plugins/rntuple/TableOutputFields.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_ROOT6_X_2024-01-31-2300/src/PhysicsTools/NanoAOD/plugins/rntuple/TriggerOutputFields.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_ROOT6_X_2024-01-31-2300/src/PhysicsTools/NanoAOD/plugins/rntuple/TriggerOutputFields.cc: In member function 'void TriggerOutputFields::makeUniqueFieldName(ROOT::Experimental::RNTupleModel&, std::string&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_ROOT6_X_2024-01-31-2300/src/PhysicsTools/NanoAOD/plugins/rntuple/TriggerOutputFields.cc:126:38: error: 'class ROOT::Experimental::RNTupleModel' has no member named 'Get'
  126 |   const auto* existing_field = model.Get(name);
      |                                      ^~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_ROOT6_X_2024-01-31-2300/src/PhysicsTools/NanoAOD/plugins/rntuple/TriggerOutputFields.cc:126:42: error: expected primary-expression before 'bool'
  126 |   const auto* existing_field = model.Get(name);
      |                                          ^~~~

@smuzaffar
Copy link
Contributor

smuzaffar commented Feb 1, 2024

test parameters:

@smuzaffar
Copy link
Contributor

smuzaffar commented Feb 1, 2024

please test

@smuzaffar
Copy link
Contributor

smuzaffar commented Feb 1, 2024

please test for CMSSW_14_0_ROOT6_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2024

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e9f00/37172/summary.html
COMMIT: 5b2462f
CMSSW: CMSSW_14_0_X_2024-02-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8981/37172/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e9f00/37172/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e9f00/37172/git-merge-result

Build

I found compilation error when building:

>> Checking EDM Class Transients in libCUDADataFormatsHcalDigi.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libCUDADataFormatsBeamSpot.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libCUDADataFormatsCommon.so
gmake: *** [tmp/el8_amd64_gcc12/edm_checks/libAnalysisDataFormatsTrackInfo.so] Error 1
>> Checking EDM Class Transients in libCUDADataFormatsEcalDigi.so
>> Checking EDM Class Transients in libCUDADataFormatsPortableTestObjects.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libCUDADataFormatsEcalRecHitSoA.so
>> Checking EDM Class Version for src/CUDADataFormats/SiPixelCluster/src/classes_def.xml in libCUDADataFormatsSiPixelCluster.so

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2024

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e9f00/37174/summary.html
COMMIT: 5b2462f
CMSSW: CMSSW_14_0_ROOT6_X_2024-01-31-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8981/37174/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test testG4Refitter had ERRORS

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor

smuzaffar commented Feb 5, 2024

+externals

we need to wait for cms-sw/cmssw#43834 to go in first

@cmsbuild cmsbuild mentioned this pull request Feb 5, 2024
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2024

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_0_X/rootmaster IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#43834

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_14_0_X/rootmaster to IB/CMSSW_14_1_X/rootmaster February 6, 2024 10:21
@rappoccio
Copy link

rappoccio commented Feb 7, 2024

+1

@smuzaffar smuzaffar merged commit 99d53aa into cms-sw:IB/CMSSW_14_1_X/rootmaster Feb 7, 2024
@cmsbuild cmsbuild mentioned this pull request Feb 19, 2024
Closed
@cmsbuild cmsbuild mentioned this pull request Apr 23, 2024
Merged
This was referenced Aug 11, 2025
Merged
Open
@cmsbuild cmsbuild mentioned this pull request Oct 7, 2025
Merged
@cmsbuild cmsbuild mentioned this pull request Nov 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

externals-approved fully-signed orp-approved requires-external tests-rejected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aandvalenzuela @cmsbuild @smuzaffar @rappoccio