Fix deprecated-copy warnings in CondFormats/PhysicsToolsObjects and PhysicsTools/MVAComputer #43400

iarspider · 2023-11-27T14:23:55Z

PR description:

Fix deprecated-copy warnings (rule-of-three violation) in CondFormats/PhysicsToolsObjects and PhysicsTools/MVAComputer:

/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/PhysicsTools/MVAComputer/src/BitSet.cc: In function 'PhysicsTools::Calibration::BitSet PhysicsTools::Calibration::convert(const PhysicsTools::BitSet&)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/PhysicsTools/MVAComputer/src/BitSet.cc:47:12: warning: implicitly-declared 'PhysicsTools::Calibration::BitSet::BitSet(const PhysicsTools::Calibration::BitSet&)' is deprecated [-Wdeprecated-copy]
    47 |     return result;
      |            ^~~~~~
In file included from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/PhysicsTools/MVAComputer/interface/Calibration.h:4,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/PhysicsTools/MVAComputer/src/BitSet.cc:2:
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/CondFormats/PhysicsToolsObjects/interface/MVAComputer.h:32:15: note: because 'PhysicsTools::Calibration::BitSet' has user-provided 'PhysicsTools::Calibration::BitSet& PhysicsTools::Calibration::BitSet::operator=(const PhysicsTools::Calibration::BitSet&)'
   32 |       BitSet &operator=(const BitSet &other) {
      |               ^~~~~~~~
>> Compiling  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/PhysicsTools/MVAComputer/src/ProcLinear.cc
CMSSW_CPU_TYPE= /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_14_0_DEVEL_X_2023-11-26-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_14_0_DEVEL_X_2023-11-26-2300' -I/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/cms/coral/CORAL_2_3_21-821f5a7f8bb5dc2d52bc1a7792e2e524/include/LCG -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/pcre/8.43-37eb2e8b73bab83d6645ecfd5d73dcaa/include -isystem/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/boost/1.80.0-826a207b8543c52970cb1f72d50f068c/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/curl/7.79.0-959a9188e043d67b2825f64cfeb54266/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/lcg/root/6.26.11-1ef575234f3b954353280f3578660947/include -isystem/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/tbb/v2021.9.0-e755918dac6a30ec36eff63ac4f7ddec/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/xerces-c/3.1.3-c7b88eaa36d0408120f3c29826a04bf6/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/zlib/1.2.11-51072030b7f93c3ac6c4235f21e413cb/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/fmt/8.0.1-54e94b39f5cf29341bb9c4765764e1ca/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/tinyxml2/6.2.0-d17873b4d6a42a43226cf689f82ec1ef/include -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++17 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr  -fPIC  -MMD -MF tmp/el8_amd64_gcc12/src/PhysicsTools/MVAComputer/src/PhysicsToolsMVAComputer/ProcLinear.cc.d /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/PhysicsTools/MVAComputer/src/ProcLinear.cc -o tmp/el8_amd64_gcc12/src/PhysicsTools/MVAComputer/src/PhysicsToolsMVAComputer/ProcLinear.cc.o
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/PhysicsTools/MVAComputer/src/MVAComputer.cc: In member function 'void PhysicsTools::MVAComputer::setup(const PhysicsTools::Calibration::MVAComputer*)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/PhysicsTools/MVAComputer/src/MVAComputer.cc:104:52: warning: implicitly-declared 'PhysicsTools::Variable& PhysicsTools::Variable::operator=(const PhysicsTools::Variable&)' is deprecated [-Wdeprecated-copy]
   104 |       var.var = Variable(iter->name, config[i].mask);
      |                                                    ^
In file included from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/PhysicsTools/MVAComputer/interface/VarProcessor.h:19,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/PhysicsTools/MVAComputer/interface/MVAComputer.h:19,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/PhysicsTools/MVAComputer/src/MVAComputer.cc:21:
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/PhysicsTools/MVAComputer/interface/Variable.h:133:12: note: because 'PhysicsTools::Variable' has user-provided 'PhysicsTools::Variable::Variable(const PhysicsTools::Variable&)'
  133 |     inline Variable(const Variable &orig) : name(orig.name), flags(orig.flags) {}
      |            ^~~~~~~~
>> Compiling  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/PhysicsTools/MVAComputer/src/ProcMLP.cc
CMSSW_CPU_TYPE= /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_14_0_DEVEL_X_2023-11-26-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_14_0_DEVEL_X_2023-11-26-2300' -I/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/cms/coral/CORAL_2_3_21-821f5a7f8bb5dc2d52bc1a7792e2e524/include/LCG -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/pcre/8.43-37eb2e8b73bab83d6645ecfd5d73dcaa/include -isystem/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/boost/1.80.0-826a207b8543c52970cb1f72d50f068c/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/curl/7.79.0-959a9188e043d67b2825f64cfeb54266/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -isystem/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/lcg/root/6.26.11-1ef575234f3b954353280f3578660947/include -isystem/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/tbb/v2021.9.0-e755918dac6a30ec36eff63ac4f7ddec/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/xerces-c/3.1.3-c7b88eaa36d0408120f3c29826a04bf6/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/zlib/1.2.11-51072030b7f93c3ac6c4235f21e413cb/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/fmt/8.0.1-54e94b39f5cf29341bb9c4765764e1ca/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/tinyxml2/6.2.0-d17873b4d6a42a43226cf689f82ec1ef/include -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++17 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr  -fPIC  -MMD -MF tmp/el8_amd64_gcc12/src/PhysicsTools/MVAComputer/src/PhysicsToolsMVAComputer/ProcMLP.cc.d /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/PhysicsTools/MVAComputer/src/ProcMLP.cc -o tmp/el8_amd64_gcc12/src/PhysicsTools/MVAComputer/src/PhysicsToolsMVAComputer/ProcMLP.cc.o
>> Compiling  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/PhysicsTools/MVAComputer/src/ProcMatrix.cc
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/PhysicsTools/MVAComputer/interface/MVAComputer.h: In instantiation of 'static _OI std::__copy_move<_IsMove, _IsSimple, _Category>::__copy_m(_II, _II, _OI) [with _II = std::_Rb_tree_const_iterator<PhysicsTools::MVAComputer::InputVar>; _OI = PhysicsTools::MVAComputer::InputVar*; bool _IsMove = false; bool _IsSimple = false; _Category = std::bidirectional_iterator_tag]':
/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/stl_algobase.h:495:30:   required from '_OI std::__copy_move_a2(_II, _II, _OI) [with bool _IsMove = false; _II = _Rb_tree_const_iterator<PhysicsTools::MVAComputer::InputVar>; _OI = PhysicsTools::MVAComputer::InputVar*]'
/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/stl_algobase.h:522:42:   required from '_OI std::__copy_move_a1(_II, _II, _OI) [with bool _IsMove = false; _II = _Rb_tree_const_iterator<PhysicsTools::MVAComputer::InputVar>; _OI = PhysicsTools::MVAComputer::InputVar*]'
/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/stl_algobase.h:530:31:   required from '_OI std::__copy_move_a(_II, _II, _OI) [with bool _IsMove = false; _II = _Rb_tree_const_iterator<PhysicsTools::MVAComputer::InputVar>; _OI = __gnu_cxx::__normal_iterator<PhysicsTools::MVAComputer::InputVar*, vector<PhysicsTools::MVAComputer::InputVar> >]'
/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/stl_algobase.h:620:7:   required from '_OI std::copy(_II, _II, _OI) [with _II = _Rb_tree_const_iterator<PhysicsTools::MVAComputer::InputVar>; _OI = __gnu_cxx::__normal_iterator<PhysicsTools::MVAComputer::InputVar*, vector<PhysicsTools::MVAComputer::InputVar> >]'
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/PhysicsTools/MVAComputer/src/MVAComputer.cc:112:14:   required from here
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/PhysicsTools/MVAComputer/interface/MVAComputer.h:92:12: warning: implicitly-declared 'PhysicsTools::Variable& PhysicsTools::Variable::operator=(const PhysicsTools::Variable&)' is deprecated [-Wdeprecated-copy]
    92 |     struct InputVar {
      |            ^~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/PhysicsTools/MVAComputer/interface/Variable.h:133:12: note: because 'PhysicsTools::Variable' has user-provided 'PhysicsTools::Variable::Variable(const PhysicsTools::Variable&)'
  133 |     inline Variable(const Variable &orig) : name(orig.name), flags(orig.flags) {}
      |            ^~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/string:50,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/locale_classes.h:40,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/ios_base.h:41,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/ios:42,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/ostream:38,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/iostream:39,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/PhysicsTools/MVAComputer/src/MVAComputer.cc:1:
/data/cmsbld/jenkins/workspace/build-any-ib/w/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/stl_algobase.h:353:23: note: synthesized method 'PhysicsTools::MVAComputer::InputVar& PhysicsTools::MVAComputer::InputVar::operator=(const PhysicsTools::MVAComputer::InputVar&)' first required here
  353 |             *__result = *__first;
      |             ~~~~~~~~~~^~~~~~~~~~

PR validation:

Bot tests

…hysicsTools/MVAComputer

iarspider · 2023-11-27T14:25:24Z

please test for CMSSW_14_0_DEVEL_X

cmsbuild · 2023-11-27T14:32:46Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43400/37901

This PR adds an extra 20KB to repository

cmsbuild · 2023-11-27T14:33:15Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

CondFormats/PhysicsToolsObjects (alca, db)
PhysicsTools/MVAComputer (analysis)

@saumyaphor4252, @consuegs, @tvami, @perrotta, @francescobrivio can you please review it and eventually sign? Thanks.
@seemasharmafnal, @JyothsnaKomaragiri, @AlexDeMoor, @Ming-Yan, @tocheng, @AnnikaStein, @andrzejnovak, @demuller, @emilbols, @mmusich, @yuanchao, @PonIlya, @Senphy, @rsreds this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

iarspider · 2023-11-27T14:34:51Z

please test

cmsbuild · 2023-11-27T17:10:32Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-108941/36086/summary.html
COMMIT: faf0aaa
CMSSW: CMSSW_14_0_DEVEL_X_2023-11-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43400/36086/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 192 lines to the logs
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3367918
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3367895
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

cmsbuild · 2023-11-27T17:13:02Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-108941/36087/summary.html
COMMIT: faf0aaa
CMSSW: CMSSW_14_0_X_2023-11-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43400/36087/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 130 lines to the logs
Reco comparison results: 20 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3367918
DQMHistoTests: Total failures: 1113
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3366783
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

tvami · 2023-11-27T17:15:49Z

+analysis

technical PR, code compiles/runs in DEVEL version of CMSSW
diffs in 12434.7 are understood, see spurious differences in outputs of Run-3 wfs *.7 #39803 , otherwise clean diffs (MsgLogger)

perrotta · 2023-11-27T22:36:26Z

+1

iarspider · 2023-12-04T13:24:47Z

please test

cmsbuild · 2023-12-04T13:31:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43400/38059

This PR adds an extra 16KB to repository

cmsbuild · 2023-12-04T13:31:47Z

Pull request #43400 was updated. @consuegs, @perrotta, @saumyaphor4252, @francescobrivio, @tvami can you please check and sign again.

iarspider · 2023-12-04T13:32:37Z

please test for CMSSW_14_0_DEVEL_X

cmsbuild · 2023-12-04T19:02:21Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-108941/36311/summary.html
COMMIT: df1b495
CMSSW: CMSSW_14_0_DEVEL_X_2023-12-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43400/36311/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@bsunanda Phase2-hgx350 Make modifications for the HGCal version V18 in the case of mouse bite, guard rings, ... #43449
@swagata87 Migrate calotower code to use HCAL thresholds from GT #43329
@aandvalenzuela [SIMULATION-UPGRADE] Define missing assignment operator to fix warnings reported in DEVEL IBs #43459
@srimanob Add placeholders of phase2 geometry config files #43476
@Dr15Jones Added ActivityRegistry signals for EDProducer transforms #43442
@bsunanda Phase2-hcx359 Define modules for HFNose following the structure of updated HGCal (as in V17 version) #43445
@mmusich supply empty SiPixelLorentzAngle palyoads for forWidth and fromAlignment in autoCondPhase2 for geometry T33 #43482
@cerminar Phase-2 L1T: Consolidation of e/g object interface #43317
@iarspider Fix deprecated-copy warnings in L1Trigger/L1CaloTrigger #43396
@hgc-tpg [HGCAL trigger] Update ECON-T BestChoice NData #43431
@bsunanda Run3-gex174 Add RPD in the latest version of 2023 Gemetry as requested by the ZDC group for the next HI simulation effort #43418

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-108941/36311/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-108941/36311/git-merge-result

Comparison Summary

Summary:

You potentially added 72 lines to the logs
Reco comparison results: 796 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3370032
DQMHistoTests: Total failures: 4869
DQMHistoTests: Total nulls: 3
DQMHistoTests: Total successes: 3365138
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.02 KiB( 49 files compared)
DQMHistoSizes: changed ( 141.044 ): 0.020 KiB JetMET/SUSYDQM
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

cmsbuild · 2023-12-04T19:05:35Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-108941/36310/summary.html
COMMIT: df1b495
CMSSW: CMSSW_14_0_X_2023-12-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43400/36310/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@bsunanda Phase2-hgx350 Make modifications for the HGCal version V18 in the case of mouse bite, guard rings, ... #43449
@swagata87 Migrate calotower code to use HCAL thresholds from GT #43329
@aandvalenzuela [SIMULATION-UPGRADE] Define missing assignment operator to fix warnings reported in DEVEL IBs #43459
@srimanob Add placeholders of phase2 geometry config files #43476
@Dr15Jones Added ActivityRegistry signals for EDProducer transforms #43442
@bsunanda Phase2-hcx359 Define modules for HFNose following the structure of updated HGCal (as in V17 version) #43445
@mmusich supply empty SiPixelLorentzAngle palyoads for forWidth and fromAlignment in autoCondPhase2 for geometry T33 #43482
@cerminar Phase-2 L1T: Consolidation of e/g object interface #43317
@iarspider Fix deprecated-copy warnings in L1Trigger/L1CaloTrigger #43396
@hgc-tpg [HGCAL trigger] Update ECON-T BestChoice NData #43431
@bsunanda Run3-gex174 Add RPD in the latest version of 2023 Gemetry as requested by the ZDC group for the next HI simulation effort #43418

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-108941/36310/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-108941/36310/git-merge-result

Comparison Summary

Summary:

You potentially removed 310 lines from the logs
Reco comparison results: 810 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3370032
DQMHistoTests: Total failures: 5828
DQMHistoTests: Total nulls: 3
DQMHistoTests: Total successes: 3364179
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.02 KiB( 49 files compared)
DQMHistoSizes: changed ( 141.044 ): 0.020 KiB JetMET/SUSYDQM
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

tvami · 2023-12-04T21:21:56Z

+1

resign, see Fix deprecated-copy warnings in CondFormats/PhysicsToolsObjects and PhysicsTools/MVAComputer #43400 (comment)

perrotta · 2023-12-05T06:42:44Z

+1

cmsbuild · 2023-12-05T06:43:06Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2023-12-05T15:07:28Z

+1

Fix deprecated-copy warnings in CondFormats/PhysicsToolsObjects and P…

faf0aaa

…hysicsTools/MVAComputer

cmsbuild added this to the CMSSW_14_0_X milestone Nov 27, 2023

cmsbuild added analysis-pending alca-pending db-pending pending-signatures tests-pending orp-pending code-checks-pending labels Nov 27, 2023

cmsbuild added tests-started and removed tests-pending labels Nov 27, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 27, 2023

cmsbuild added tests-approved and removed tests-started labels Nov 27, 2023

cmsbuild added analysis-approved and removed analysis-pending labels Nov 27, 2023

cmsbuild mentioned this pull request Nov 27, 2023

[ALCA][DB] Fix copy-constructor warnings reported in DEVEL IBs #43410

Merged

cmsbuild added alca-approved and removed alca-pending db-pending pending-signatures labels Nov 27, 2023

cmsbuild added pending-signatures tests-pending code-checks-pending labels Dec 4, 2023

cmsbuild added tests-started and removed tests-pending labels Dec 4, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 4, 2023

cmsbuild added tests-approved and removed tests-started labels Dec 4, 2023

cmsbuild added analysis-approved and removed analysis-pending labels Dec 4, 2023

cmsbuild added alca-approved fully-signed db-approved and removed alca-pending db-pending pending-signatures labels Dec 5, 2023

cmsbuild added orp-approved and removed orp-pending labels Dec 5, 2023

cmsbuild merged commit 316ce5b into cms-sw:master Dec 5, 2023

Fix deprecated-copy warnings in CondFormats/PhysicsToolsObjects and PhysicsTools/MVAComputer #43400

Fix deprecated-copy warnings in CondFormats/PhysicsToolsObjects and PhysicsTools/MVAComputer #43400

Uh oh!

Conversation

iarspider commented Nov 27, 2023

PR description:

PR validation:

Uh oh!

iarspider commented Nov 27, 2023

Uh oh!

cmsbuild commented Nov 27, 2023

Uh oh!

cmsbuild commented Nov 27, 2023

Uh oh!

iarspider commented Nov 27, 2023

Uh oh!

cmsbuild commented Nov 27, 2023

Comparison Summary

Uh oh!

cmsbuild commented Nov 27, 2023

Comparison Summary

Uh oh!

tvami commented Nov 27, 2023

Uh oh!

perrotta commented Nov 27, 2023

Uh oh!

iarspider commented Dec 4, 2023

Uh oh!

cmsbuild commented Dec 4, 2023

Uh oh!

cmsbuild commented Dec 4, 2023

Uh oh!

iarspider commented Dec 4, 2023

Uh oh!

cmsbuild commented Dec 4, 2023

Comparison Summary

Uh oh!

cmsbuild commented Dec 4, 2023

Comparison Summary

Uh oh!

tvami commented Dec 4, 2023

Uh oh!

perrotta commented Dec 5, 2023

Uh oh!

cmsbuild commented Dec 5, 2023

Uh oh!

rappoccio commented Dec 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants