Skip to content

Conversation

@aandvalenzuela
Copy link
Contributor

Hello,

This PR solves the DEVEL warnings on deprecated copy-constructors present in the IBs on some ALCA-DB modules.

Thanks,
Andrea

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43410/37914

@aandvalenzuela
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for master.

It involves the following packages:

  • CondFormats/PhysicsToolsObjects (db, alca)
  • CondFormats/SiStripObjects (db, alca)

@francescobrivio, @consuegs, @saumyaphor4252, @perrotta can you please review it and eventually sign? Thanks.
@threus, @tocheng, @rsreds, @seemasharmafnal, @PonIlya, @erikbutz, @yuanchao, @mmusich, @VinInn this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@aandvalenzuela
Copy link
Contributor Author

please test for CMSSW_14_0_DEVEL_X

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-606338/36100/summary.html
COMMIT: 922429a
CMSSW: CMSSW_14_0_X_2023-11-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43410/36100/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-606338/36101/summary.html
COMMIT: 922429a
CMSSW: CMSSW_14_0_DEVEL_X_2023-11-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43410/36101/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

+1

  • Implementation looks correct, i.e. removed constructors can be replaced by the default ones

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants