Skip to content

Fix deprecated-copy warnings in CondFormats/PhysicsToolsObjects and PhysicsTools/MVAComputer #43400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 2 commits into from
Dec 5, 2023
Merged

Fix deprecated-copy warnings in CondFormats/PhysicsToolsObjects and PhysicsTools/MVAComputer #43400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
faf0aaa
Fix deprecated-copy warnings in CondFormats/PhysicsToolsObjects and P…
iarspider Nov 27, 2023
df1b495
Merge branch 'master' into fix-deprecated-copy-mvacomputer
iarspider Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CondFormats/PhysicsToolsObjects/interface/MVAComputer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,16 @@ namespace PhysicsTools {

class BitSet {
public:
// help that poor ROOT to copy bitsets... (workaround)
BitSet &operator=(const BitSet &other) {
store = other.store;
bitsInLast = other.bitsInLast;
return *this;
}
BitSet(const BitSet &other) = default;
BitSet() = default;
~BitSet() = default;

std::vector<unsigned char> store;
unsigned int bitsInLast;

Expand Down Expand Up @@ -61,6 +71,7 @@ namespace PhysicsTools {
inline Variable() {}
inline Variable(const std::string &name) : name(name) {}
inline ~Variable() {}
Variable &operator=(const Variable &other) = default;

std::string name;

Expand Down
1 change: 1 addition & 0 deletions PhysicsTools/MVAComputer/interface/Variable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ namespace PhysicsTools {
inline Variable() {}
inline Variable(const Variable &orig) : name(orig.name), flags(orig.flags) {}
inline Variable(AtomicId name, Flags flags = FLAG_NONE) : name(name), flags(flags) {}
Variable &operator=(const Variable &other) = default;

const AtomicId getName() const { return name; }
Flags getFlags() const { return flags; }
Expand Down