-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Miscellaneous improvements for DQM/Integration unit tests
#42953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous improvements for DQM/Integration unit tests
#42953
Conversation
…ed for GPUvsCPU clients
…redefine binning of h_totFEDErrors_
|
test parameters: |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42953/37101
|
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@tjavaid, @nothingface0, @cmsbuild, @syuvivida, @rvenditti, @antoniovagnerini can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-62366d/35059/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
A note for @cms-sw/orp-l2, this needs to be merged together with cms-data/DQM-Integration#5 in order to avoid failures in IB tests. |
|
+1 |
PR description:
This PR proposes 4 updates:
SiStripMonitorApproximateCluster(commit 06dd05e)sistrip_approx_dqm_sourceclientintroduced in PR Add more diagnostics toSiStripMonitorApproximateCluster#42881 (commit 093de3f)sistrip_approx_dqm_sourceclientand refresh runs used for the GPUvsCPU clients (this last point is necessary since (as pointed out in Addpixelgpuonline DQM client and augment DQM/Integration unit tests #42542 the old streamers lack the proper pixel collectionsSiPixelRawDataErroredmDetSetVector_hltSiPixelDigisFromSoA_*_*andSiPixelRawDataErroredmDetSetVector_hltSiPixelDigisLegacy_*_*) (commit 13fa084)SiPixelPhase1RawDataErrorComparator: demoteLogPrinttoLogDebugand redefine binning ofh_totFEDErrors_(commit 9cb0dd8)Note to reviewers: to pass tests this PR needs to be tested with cms-data/DQM-Integration#5
PR validation:
Run successfully the unit tests of this package:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A