Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 5, 2023

PR description:

This PR proposes 4 updates:

Note to reviewers: to pass tests this PR needs to be tested with cms-data/DQM-Integration#5

PR validation:

Run successfully the unit tests of this package:

scram b runtests_TestDQMOnlineClient-sistrip_approx_dqm_sourceclient
scram b runtests_pixelgpu_dqm_sourceclient
scram b runtests_ecalgpu_dqm_sourceclient
scram b runtests_hcalgpu_dqm_sourceclient

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@mmusich
Copy link
Contributor Author

mmusich commented Oct 5, 2023

test parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42953/37101

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2023

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • DQM/Integration (dqm)
  • DQM/SiPixelHeterogeneous (dqm)
  • DQM/SiStripMonitorApproximateCluster (dqm)

@tjavaid, @nothingface0, @cmsbuild, @syuvivida, @rvenditti, @antoniovagnerini can you please review it and eventually sign? Thanks.
@fioriNTU, @jandrea, @idebruyn, @francescobrivio, @batinkov, @threus this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 5, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-62366d/35059/summary.html
COMMIT: 9cb0dd8
CMSSW: CMSSW_13_3_X_2023-10-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42953/35059/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-62366d/35059/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-62366d/35059/git-merge-result

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3356920
  • DQMHistoTests: Total failures: 148
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356750
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 3 / 48 workflows

@tjavaid
Copy link

tjavaid commented Oct 7, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Oct 9, 2023

A note for @cms-sw/orp-l2, this needs to be merged together with cms-data/DQM-Integration#5 in order to avoid failures in IB tests.

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bc82b34 into cms-sw:master Oct 9, 2023
@mmusich mmusich deleted the miscellaneous_improvements_DQM_integration_and_unit_tests branch October 9, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants