Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 5, 2023

This is a companion of PR cms-sw/cmssw#42953.
Goals are:

  • refresh the streamDQMGPUvsCPU unit tests files in order to include also Pixel FED errors for SiPixelPhase1RawDataErrorComparator;
  • add streamDQM file for sistrip_appror sistrip_approx_dqm_sourceclient-live unit test;
  • update README file

Note to reviewers: to pass tests this PR needs to be tested with cms-sw/cmssw#42953

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2023

A new Pull Request was created by @mmusich (Marco Musich) for branch main.

@rvenditti, @syuvivida, @tjavaid, @nothingface0, @antoniovagnerini, @cmsbuild, @iarspider, @smuzaffar, @aandvalenzuela can you please review it and eventually sign? Thanks.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 6, 2023

test parameters:

@mmusich
Copy link
Contributor Author

mmusich commented Oct 6, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd07ec/35085/summary.html
COMMIT: e1b17d9
CMSSW: CMSSW_13_3_X_2023-10-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/DQM-Integration/5/35085/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd07ec/35085/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd07ec/35085/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3356920
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356889
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Oct 9, 2023

@tjavaid,since you signed also the cmssw PR cms-sw/cmssw#42953, do you have objections to this update of the externals?

@tjavaid
Copy link

tjavaid commented Oct 9, 2023

+1

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2023

This pull request is fully signed and it will be integrated in one of the next main IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link

+1

@rappoccio
Copy link

merge

@cmsbuild cmsbuild merged commit 71f01b4 into cms-data:main Oct 9, 2023
@mmusich mmusich deleted the updateStreamerFilesForUnitTests branch October 9, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants